| Message ID | 20151022155942.GA15548@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/builtin-run.c b/builtin-run.c index ab1fc2a..6e4491c 100644 --- a/builtin-run.c +++ b/builtin-run.c @@ -590,7 +590,7 @@ static struct kvm *kvm_cmd_run_init(int argc, const char **argv) } if (kvm->cfg.using_rootfs) { - strcat(real_cmdline, " root=/dev/root rw rootflags=rw,trans=virtio,version=9p2000.L rootfstype=9p"); + strcat(real_cmdline, " rw rootflags=trans=virtio,version=9p2000.L rootfstype=9p"); if (kvm->cfg.custom_rootfs) { kvm_run_set_sandbox(kvm);
1. kvm_cmd_run_init() appends "root=/dev/root" to real_cmdline if cfg.using_rootfs == T. This doesn't hurt but makes no sense and looks confusing. We do not need to initialiaze the kernel's saved_root_name[] and "/dev/root" means nothing to name_to_dev_t(). We only need to pass this mount-tag to 9p but the kernel always uses dev_name="/dev/root" in mount_root() path, so we can safely remove this option from the command line. 2. "rw" in rootflags looks confusing too, it is silently ignored by v9fs_parse_options() and has no effect. We need to clear MS_RDONLY from root_mountflags, this is what the "standalone" kernel parameter correctly does. Signed-off-by: Oleg Nesterov <oleg@redhat.com> --- builtin-run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)