From patchwork Mon Nov 2 11:16:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cornelia Huck X-Patchwork-Id: 7535671 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 52B03BEEA4 for ; Mon, 2 Nov 2015 11:17:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 68E7420576 for ; Mon, 2 Nov 2015 11:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EC0F20573 for ; Mon, 2 Nov 2015 11:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbbKBLR3 (ORCPT ); Mon, 2 Nov 2015 06:17:29 -0500 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:45955 "EHLO e06smtp05.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbbKBLR1 (ORCPT ); Mon, 2 Nov 2015 06:17:27 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Nov 2015 11:17:24 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 2 Nov 2015 11:17:13 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: cornelia.huck@de.ibm.com X-IBM-RcptTo: kvm@vger.kernel.org;linux-s390@vger.kernel.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 03A931B0804B; Mon, 2 Nov 2015 11:17:26 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA2BHCAA1376556; Mon, 2 Nov 2015 11:17:12 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA2BH2SM012185; Mon, 2 Nov 2015 04:17:12 -0700 Received: from gondolin (dyn-9-152-224-100.boeblingen.de.ibm.com [9.152.224.100]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tA2BH0fm012098; Mon, 2 Nov 2015 04:17:00 -0700 Date: Mon, 2 Nov 2015 12:16:58 +0100 From: Cornelia Huck To: Andy Lutomirski Cc: Christian Borntraeger , Andy Lutomirski , Sebastian Ott , Paolo Bonzini , Christoph Hellwig , Benjamin Herrenschmidt , KVM , David Woodhouse , Joerg Roedel , Martin Schwidefsky , linux-s390 Subject: Re: [PATCH/RFC 0/4] dma ops and virtio Message-ID: <20151102121658.11aa3375.cornelia.huck@de.ibm.com> In-Reply-To: References: <1445986131-239566-1-git-send-email-borntraeger@de.ibm.com> <5631629B.2050505@de.ibm.com> <20151030092548.7abd51e1.cornelia.huck@de.ibm.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110211-0021-0000-0000-000004AC8DEC Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 30 Oct 2015 13:33:07 -0700 Andy Lutomirski wrote: > On Fri, Oct 30, 2015 at 1:25 AM, Cornelia Huck wrote: > > On Thu, 29 Oct 2015 15:50:38 -0700 > > Andy Lutomirski wrote: > > > >> Progress! After getting that sort-of-working, I figured out what was > >> wrong with my earlier command, and I got that working, too. Now I > >> get: > >> > >> qemu-system-s390x -fsdev > >> local,id=virtfs1,path=/,security_model=none,readonly -device > >> virtio-9p-ccw,fsdev=virtfs1,mount_tag=/dev/root -M s390-ccw-virtio > >> -nodefaults -device sclpconsole,chardev=console -parallel none -net > >> none -echr 1 -serial none -chardev stdio,id=console,signal=off,mux=on > >> -serial chardev:console -mon chardev=console -vga none -display none > >> -kernel arch/s390/boot/bzImage -append > >> 'init=/home/luto/devel/virtme/virtme/guest/virtme-init > >> psmouse.proto=exps "virtme_stty_con=rows 24 cols 150 iutf8" > >> TERM=xterm-256color rootfstype=9p > >> rootflags=ro,version=9p2000.L,trans=virtio,access=any > >> raid=noautodetect debug' > > > > The commandline looks sane AFAICS. > > > > (...) > > > >> vrfy: device 0.0.0000: rc=0 pgroup=0 mpath=0 vpm=80 > >> virtio_ccw 0.0.0000: Failed to set online: -5 > >> > >> ^^^ bad news! > > > > I'd like to see where in the onlining process this fails. Could you set > > up qemu tracing for css_* and virtio_ccw_* (instructions in > > qemu/docs/tracing.txt)? > > I have a file called events that contains: > > css_* > virtio_ccw_* > > pointing -trace events= at it results in a trace- file that's 549 > bytes long and contains nothing. Are wildcards not as well-supported > as the docs suggest? Just tried it, seemed to work for me as expected. And as your messages indicate, at least some of the css tracepoints are guaranteed to be hit. Odd. Can you try the following sophisticated printf debug patch? > > Which qemu version is this, btw.? > > > > git from yesterday. Hm. Might be worth trying the s390-ccw-virtio-2.4 machine instead. --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/hw/s390x/css.c b/hw/s390x/css.c index c033612..6a87bd6 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -308,6 +308,8 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr) sch->ccw_no_data_cnt++; } + fprintf(stderr, "CH DBG: %s: cmd_code=%x\n", __func__, ccw.cmd_code); + /* Look at the command. */ switch (ccw.cmd_code) { case CCW_CMD_NOOP: @@ -375,6 +377,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr) } break; } + fprintf(stderr, "CH DBG: %s: ret=%d\n", __func__, ret); sch->last_cmd = ccw; sch->last_cmd_valid = true; if (ret == 0) {