From patchwork Fri Dec 11 08:06:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ingo Molnar X-Patchwork-Id: 7826941 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5F937BEEE1 for ; Fri, 11 Dec 2015 08:06:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 70A3A20573 for ; Fri, 11 Dec 2015 08:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68F062045E for ; Fri, 11 Dec 2015 08:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbbLKIG3 (ORCPT ); Fri, 11 Dec 2015 03:06:29 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33627 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753712AbbLKIG2 (ORCPT ); Fri, 11 Dec 2015 03:06:28 -0500 Received: by mail-wm0-f49.google.com with SMTP id c201so65387980wme.0; Fri, 11 Dec 2015 00:06:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Z5hDukEqWUWJz1PPLyEcQ2RV6I7yxkFJbh5QPmcT4oo=; b=loRHwizCVFjSHpAw5ITeG08+NF8c7B+xZ5wFW+0RFHZ6pagLLfCeeFazBlTmBQVHm+ MiWbEmMAHM9lO5USe0LV3BBw3LBqkfxsKTAw6jMA53AfwET2RY20i7CLkmnRy2ZOGj8A tujJDEKKosxv8PfTuYwiUSnMetSrt26XxtxpwbCJ1b0yH3UKxaEbo7/RimuuKqZfcteg Jg2WYuNX8N6nvSMIlX3jD6Nq4Zi3EcARYHuoJ/KLhB/Q76ngQ3S6EvQVneaiCOQFHRzu J157DDJZByYOwDTaCSov8sDQdIeP00U0CN1xky+dOza+e9J10iQNWjxZiGOkE75nJiGQ tI1w== X-Received: by 10.28.176.200 with SMTP id z191mr4228014wme.102.1449821186823; Fri, 11 Dec 2015 00:06:26 -0800 (PST) Received: from gmail.com (54033495.catv.pool.telekom.hu. [84.3.52.149]) by smtp.gmail.com with ESMTPSA id b84sm2243320wmh.15.2015.12.11.00.06.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Dec 2015 00:06:25 -0800 (PST) Date: Fri, 11 Dec 2015 09:06:23 +0100 From: Ingo Molnar To: Andy Lutomirski Cc: x86@kernel.org, Marcelo Tosatti , Radim Krcmar , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Alexander Graf Subject: [PATCH] x86/platform/uv: Include clocksource.h for clocksource_touch_watchdog() Message-ID: <20151211080623.GA14386@gmail.com> References: <4933029991103ae44672c82b97a20035f5c1fe4f.1449702533.git.luto@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4933029991103ae44672c82b97a20035f5c1fe4f.1449702533.git.luto@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Andy Lutomirski wrote: > diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h > index f80d70009ff8..6d7d0e52ed5a 100644 > --- a/arch/x86/include/asm/fixmap.h > +++ b/arch/x86/include/asm/fixmap.h > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #ifdef CONFIG_X86_32 > #include > #include So this change triggered a build failure on 64-bit allmodconfig - fixed via the patch below. Your change unearthed a latent bug, a missing header inclusion. Thanks, Ingo --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ============> From d51953b0873358d13b189996e6976dfa12a9b59d Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Fri, 11 Dec 2015 09:01:30 +0100 Subject: [PATCH] x86/platform/uv: Include clocksource.h for clocksource_touch_watchdog() This build failure triggers on 64-bit allmodconfig: arch/x86/platform/uv/uv_nmi.c:493:2: error: implicit declaration of function ‘clocksource_touch_watchdog’ [-Werror=implicit-function-declaration] which is caused by recent changes exposing a missing clocksource.h include in uv_nmi.c: cc1e24fdb064 x86/vdso: Remove pvclock fixmap machinery this file got clocksource.h indirectly via fixmap.h - that stealth route of header inclusion is now gone. Cc: Borislav Petkov Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Thomas Gleixner Signed-off-by: Ingo Molnar --- arch/x86/platform/uv/uv_nmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c index 327f21c3bde1..8dd80050d705 100644 --- a/arch/x86/platform/uv/uv_nmi.c +++ b/arch/x86/platform/uv/uv_nmi.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include