From patchwork Mon Dec 21 18:47:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin O'Connor X-Patchwork-Id: 7897421 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 31E729F318 for ; Mon, 21 Dec 2015 18:48:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 48210205CB for ; Mon, 21 Dec 2015 18:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63E4C205C4 for ; Mon, 21 Dec 2015 18:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbbLUSrW (ORCPT ); Mon, 21 Dec 2015 13:47:22 -0500 Received: from mail-qg0-f42.google.com ([209.85.192.42]:36188 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbbLUSrV (ORCPT ); Mon, 21 Dec 2015 13:47:21 -0500 Received: by mail-qg0-f42.google.com with SMTP id c96so93722297qgd.3 for ; Mon, 21 Dec 2015 10:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koconnor-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=83hhQfdx5hPNCHGxtrtCZNmwkaY1NYAeDL4j2WVWJZE=; b=JcMgcU60idIzJl2nA7K7+L9L8j17jnhZNwEKLXYnXPmaedS4Tby2HTFVHjIPPtQhGa M9jVgfN0QMGRtTox0f+2LM6azG2ZKgEuks6feTurZ0XNzbERqAKjHvLlPeu7CvP2VsZ5 iKTk0Oj+sVECSGUFG4xTfO8D5xGDI63KwbB61fiMcL6nhziSNKgHx0FXJkBpdxzqU6j6 x2bKngQIAYKqHF6LC4fJsV/mD3zIYEFcevYTdN3I5oLRRQqqIKVWqPI//V8m51oDAbip 8UGwXC1kR/z2MYxufsERAPVFIHHO7nG9UhrXO2fIvuOm22yYI6fHWj8C8XxHbo7QcHNn Xe7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=83hhQfdx5hPNCHGxtrtCZNmwkaY1NYAeDL4j2WVWJZE=; b=RNuJVpY4dIlsojv2RsO7H4JCPIEht5NWyU0i1a3ITKBbrbQjiD79Zplr16AzMfin8+ 98nX/+U9MVL2DkBNJ4HuzNSVmrpgnvIJOUdoS3um9RVmiklkVIwaJc2mvdrR1SdHyxsi UtQBCoOwrY2dox4vbwuIjIPqI89wrc2DvF5ZdUxwwQsGOLg8BEDp8esd7YtFnzhPaBJl LpshUSHSKXjijLiQFGFsoRty9lmItOzzGdeifAUss0xm5701UTsVXJLuyY1zze0BvqKW 9Sk2T7FeA923l45nQplk0YZa53Bew80WC8UIdiRaD4mHh6So1Lp/r4FI9wj4KvPqvlOE 7xiw== X-Gm-Message-State: ALoCoQkkUigRKbIS/5PLSAGEeWCBqBc88mJ3XUFEqWIf1asMeIiSjcmEBNeaBO9uVlMufXb6oKwuBEL4WRLOsPqws1J8f7l82w== X-Received: by 10.140.109.33 with SMTP id k30mr26854558qgf.75.1450723640871; Mon, 21 Dec 2015 10:47:20 -0800 (PST) Received: from localhost (209-122-232-221.c3-0.avec-ubr1.nyr-avec.ny.cable.rcn.com. [209.122.232.221]) by smtp.gmail.com with ESMTPSA id e10sm14672912qka.1.2015.12.21.10.47.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Dec 2015 10:47:20 -0800 (PST) Date: Mon, 21 Dec 2015 13:47:14 -0500 From: Kevin O'Connor To: "Gonglei (Arei)" Cc: "Xulei (Stone)" , Paolo Bonzini , qemu-devel , "seabios@seabios.org" , "Huangweidong (C)" , "kvm@vger.kernel.org" , Radim Krcmar Subject: Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform Message-ID: <20151221184714.GB27329@morn.lan> References: <8E78D212B8C25246BE4CE7EA0E645FE52B5BE3@SZXEMI504-MBS.china.huawei.com> <8E78D212B8C25246BE4CE7EA0E645FE52B72B7@SZXEMI504-MBS.china.huawei.com> <20151119134039.GA27717@morn.lan> <33183CC9F5247A488A2544077AF19020B02B72BA@SZXEMA503-MBS.china.huawei.com> <20151218231326.GA4138@morn.lan> <33183CC9F5247A488A2544077AF19020B02B7A73@SZXEMA503-MBS.china.huawei.com> <20151219151159.GA22542@morn.lan> <33183CC9F5247A488A2544077AF19020B02B7BC2@SZXEMA503-MBS.china.huawei.com> <20151220143320.GA23942@morn.lan> <33183CC9F5247A488A2544077AF19020B02B7D39@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020B02B7D39@SZXEMA503-MBS.china.huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Dec 21, 2015 at 09:41:32AM +0000, Gonglei (Arei) wrote: > When the gurb of OS is booting, then the softirq and C function send_disk_op() > may use extra stack of SeaBIOS. If we inject a NMI, romlayout.S: irqentry_extrastack > is invoked, and the extra stack will be used again. And the stack of first calling > will be broken, so that the SeaBIOS stuck. > > You can easily reproduce the problem. > > 1. start on guest > 2. reset the guest > 3. inject a NMI when the guest show the grub surface > 4. then the guest stuck Does the SeaBIOS patch below help? I'm not familiar with how to "inject a NMI" - can you describe the process in more detail? -Kevin --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/src/romlayout.S +++ b/src/romlayout.S @@ -548,7 +548,9 @@ entry_post: ENTRY_INTO32 _cfunc32flat_handle_post // Normal entry point ORG 0xe2c3 - IRQ_ENTRY 02 + .global entry_02 +entry_02: + ENTRY handle_02 // NMI handler does not switch onto extra stack ORG 0xe3fe .global entry_13_official