| Message ID | 20160212193353.GH4099@pd.tnic (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Borislav Petkov <bp@alien8.de> wrote: > On Fri, Feb 12, 2016 at 07:56:59PM +0100, Paolo Bonzini wrote: > > Ok, next examples: MSR_VM_CR and MSR_VM_IGNNE. :) > > I knew you were going to dig out some. :-) > > > Are you okay with moving all the SVM MSRs to virtext.h instead? > > So I would not move any now and cause unnecessary churn. I think it > should be enough if we agree on a strategy wrt msr-index.h and then > follow it. I think we should do something similar to pci_ids.h. > > Let me add tip guys to CC. > > --- > diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h > index 552346598dab..75a5bb61d32f 100644 > --- a/arch/x86/include/asm/msr-index.h > +++ b/arch/x86/include/asm/msr-index.h > @@ -1,7 +1,12 @@ > #ifndef _ASM_X86_MSR_INDEX_H > #define _ASM_X86_MSR_INDEX_H > > -/* CPU model specific register (MSR) numbers */ > +/* > + * CPU model specific register (MSR) numbers. > + * > + * Do not add new entries to this file unless the definitions are shared > + * between multiple compilation units. > + */ This sounds good to me. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 552346598dab..75a5bb61d32f 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -1,7 +1,12 @@ #ifndef _ASM_X86_MSR_INDEX_H #define _ASM_X86_MSR_INDEX_H -/* CPU model specific register (MSR) numbers */ +/* + * CPU model specific register (MSR) numbers. + * + * Do not add new entries to this file unless the definitions are shared + * between multiple compilation units. + */ /* x86-64 specific MSRs */ #define MSR_EFER 0xc0000080 /* extended feature register */