| Message ID | 20160523102010.GB10712@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 23/05/2016 12:20, Dan Carpenter wrote: > This was supposed to be a bitwise AND but there is a typo. > > Fixes: 18f40c53e10f ('svm: Add VMEXIT handlers for AVIC') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 2214214..2eb615e 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -3597,7 +3597,7 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm) > u32 icrh = svm->vmcb->control.exit_info_1 >> 32; > u32 icrl = svm->vmcb->control.exit_info_1; > u32 id = svm->vmcb->control.exit_info_2 >> 32; > - u32 index = svm->vmcb->control.exit_info_2 && 0xFF; > + u32 index = svm->vmcb->control.exit_info_2 & 0xFF; > struct kvm_lapic *apic = svm->vcpu.arch.apic; > > trace_kvm_avic_incomplete_ipi(svm->vcpu.vcpu_id, icrh, icrl, id, index); > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Looks good, thanks. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 2214214..2eb615e 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -3597,7 +3597,7 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm) u32 icrh = svm->vmcb->control.exit_info_1 >> 32; u32 icrl = svm->vmcb->control.exit_info_1; u32 id = svm->vmcb->control.exit_info_2 >> 32; - u32 index = svm->vmcb->control.exit_info_2 && 0xFF; + u32 index = svm->vmcb->control.exit_info_2 & 0xFF; struct kvm_lapic *apic = svm->vcpu.arch.apic; trace_kvm_avic_incomplete_ipi(svm->vcpu.vcpu_id, icrh, icrl, id, index);
This was supposed to be a bitwise AND but there is a typo. Fixes: 18f40c53e10f ('svm: Add VMEXIT handlers for AVIC') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html