diff mbox

[kvm-unit-tests,v4,02/13] x86/*: report skipped tests

Message ID 20160525172352.GB8077@potion (mailing list archive)
State New, archived
Headers show

Commit Message

Radim Krčmář May 25, 2016, 5:23 p.m. UTC 
2016-05-25 19:19+0200, Radim Krčmář:
> is that summary will now print
> 
>   SKIP pku (1 tests, 1 skipped)
> 
> instead of previous
> 
>   SKIP pku (0 tests)
> 
> I like "0 tests" summary better and only x86/hyperv_synic does the
> opposite, so a fix could go both ways.

The fixup below does the other way.  And the commit message could read
"Some care to consistency [...]" with either of them. :)

---8<---
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Paolo Bonzini May 26, 2016, 7:22 a.m. UTC | #1 
On 25/05/2016 19:23, Radim Krčmář wrote:
> diff --git a/x86/hyperv_synic.c b/x86/hyperv_synic.c
> index f5eb82bb7336..5a06fb724a87 100644
> --- a/x86/hyperv_synic.c
> +++ b/x86/hyperv_synic.c
> @@ -202,7 +202,7 @@ int main(int ac, char **av)
>  
>          report("Hyper-V SynIC test", ok);
>      } else {
> -        report_skip("Hyper-V SynIC is not supported");
> +        printf("Hyper-V SynIC is not supported");
>      }
>  
>      return report_summary();
> diff --git a/x86/pku.c b/x86/pku.c
> index 6214f0bc151f..488cce3c6fdf 100644
> --- a/x86/pku.c
> +++ b/x86/pku.c
> @@ -67,7 +67,7 @@ int main(int ac, char **av)
>      unsigned int pkru_wd = 0x20;
>  
>      if (!(cpuid_indexed(7, 0).c & (1 << X86_FEATURE_PKU))) {
> -        printf("PKU not enabled, aborting\n");
> +        printf("PKU not enabled\n");
>          return report_summary();
>      }
>  
> diff --git a/x86/smap.c b/x86/smap.c
> index c9de081a474b..69dd80915c4a 100644
> --- a/x86/smap.c
> +++ b/x86/smap.c
> @@ -92,7 +92,7 @@ int main(int ac, char **av)
>  	unsigned long i;
>  
>  	if (!(cpuid_indexed(7, 0).b & (1 << X86_FEATURE_SMAP))) {
> -		printf("SMAP not enabled, aborting\n");
> +		printf("SMAP not enabled\n");
>  		return report_summary();
>  	}
>  

This one looks good.

Thanks,

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/x86/hyperv_synic.c b/x86/hyperv_synic.c
index f5eb82bb7336..5a06fb724a87 100644
--- a/x86/hyperv_synic.c
+++ b/x86/hyperv_synic.c
@@ -202,7 +202,7 @@  int main(int ac, char **av)
 
         report("Hyper-V SynIC test", ok);
     } else {
-        report_skip("Hyper-V SynIC is not supported");
+        printf("Hyper-V SynIC is not supported");
     }
 
     return report_summary();
diff --git a/x86/pku.c b/x86/pku.c
index 6214f0bc151f..488cce3c6fdf 100644
--- a/x86/pku.c
+++ b/x86/pku.c
@@ -67,7 +67,7 @@  int main(int ac, char **av)
     unsigned int pkru_wd = 0x20;
 
     if (!(cpuid_indexed(7, 0).c & (1 << X86_FEATURE_PKU))) {
-        printf("PKU not enabled, aborting\n");
+        printf("PKU not enabled\n");
         return report_summary();
     }
 
diff --git a/x86/smap.c b/x86/smap.c
index c9de081a474b..69dd80915c4a 100644
--- a/x86/smap.c
+++ b/x86/smap.c
@@ -92,7 +92,7 @@  int main(int ac, char **av)
 	unsigned long i;
 
 	if (!(cpuid_indexed(7, 0).b & (1 << X86_FEATURE_SMAP))) {
-		printf("SMAP not enabled, aborting\n");
+		printf("SMAP not enabled\n");
 		return report_summary();
 	}