From patchwork Wed May 25 17:23:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= X-Patchwork-Id: 9135863 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B9AC5607D5 for ; Wed, 25 May 2016 17:24:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A733A27E72 for ; Wed, 25 May 2016 17:24:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A54E28299; Wed, 25 May 2016 17:24:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,HK_RANDOM_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42CDD27E72 for ; Wed, 25 May 2016 17:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755305AbcEYRX5 (ORCPT ); Wed, 25 May 2016 13:23:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43575 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754167AbcEYRX4 (ORCPT ); Wed, 25 May 2016 13:23:56 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF6FCD6D20 for ; Wed, 25 May 2016 17:23:55 +0000 (UTC) Received: from potion (dhcp-1-116.brq.redhat.com [10.34.1.116]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u4PHNrrD031507; Wed, 25 May 2016 13:23:54 -0400 Received: by potion (sSMTP sendmail emulation); Wed, 25 May 2016 19:23:53 +0200 Date: Wed, 25 May 2016 19:23:53 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: kvm@vger.kernel.org, Andrew Jones Subject: Re: [kvm-unit-tests PATCH v4 02/13] x86/*: report skipped tests Message-ID: <20160525172352.GB8077@potion> References: <1462983171-4208-1-git-send-email-rkrcmar@redhat.com> <1462983171-4208-3-git-send-email-rkrcmar@redhat.com> <573B0C67.8010707@redhat.com> <20160525171927.GA8077@potion> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160525171927.GA8077@potion> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 25 May 2016 17:23:55 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 2016-05-25 19:19+0200, Radim Krčmář: > is that summary will now print > > SKIP pku (1 tests, 1 skipped) > > instead of previous > > SKIP pku (0 tests) > > I like "0 tests" summary better and only x86/hyperv_synic does the > opposite, so a fix could go both ways. The fixup below does the other way. And the commit message could read "Some care to consistency [...]" with either of them. :) ---8<--- --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/x86/hyperv_synic.c b/x86/hyperv_synic.c index f5eb82bb7336..5a06fb724a87 100644 --- a/x86/hyperv_synic.c +++ b/x86/hyperv_synic.c @@ -202,7 +202,7 @@ int main(int ac, char **av) report("Hyper-V SynIC test", ok); } else { - report_skip("Hyper-V SynIC is not supported"); + printf("Hyper-V SynIC is not supported"); } return report_summary(); diff --git a/x86/pku.c b/x86/pku.c index 6214f0bc151f..488cce3c6fdf 100644 --- a/x86/pku.c +++ b/x86/pku.c @@ -67,7 +67,7 @@ int main(int ac, char **av) unsigned int pkru_wd = 0x20; if (!(cpuid_indexed(7, 0).c & (1 << X86_FEATURE_PKU))) { - printf("PKU not enabled, aborting\n"); + printf("PKU not enabled\n"); return report_summary(); } diff --git a/x86/smap.c b/x86/smap.c index c9de081a474b..69dd80915c4a 100644 --- a/x86/smap.c +++ b/x86/smap.c @@ -92,7 +92,7 @@ int main(int ac, char **av) unsigned long i; if (!(cpuid_indexed(7, 0).b & (1 << X86_FEATURE_SMAP))) { - printf("SMAP not enabled, aborting\n"); + printf("SMAP not enabled\n"); return report_summary(); }