diff mbox

[v1,07/11] KVM: VMX: optimize APIC ID read with APICv

Message ID 20160630205429.16480-8-rkrcmar@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Radim Krčmář June 30, 2016, 8:54 p.m. UTC
The register is in hardware-compatible format now, so there is not need
to intercept.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 v1: new, split from the previous patch

 arch/x86/kvm/vmx.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Paolo Bonzini July 1, 2016, 8:42 a.m. UTC | #1
On 30/06/2016 22:54, Radim Krčmář wrote:
> The register is in hardware-compatible format now, so there is not need
> to intercept.
> 
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  v1: new, split from the previous patch
> 
>  arch/x86/kvm/vmx.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 85e2f0a882ca..a10038258b80 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6447,9 +6447,6 @@ static __init int hardware_setup(void)
>  	for (msr = 0x800; msr <= 0x8ff; msr++)
>  		vmx_disable_intercept_msr_read_x2apic(msr);
>  
> -	/* According SDM, in x2apic mode, the whole id reg is used.  But in
> -	 * KVM, it only use the highest eight bits. Need to intercept it */
> -	vmx_enable_intercept_msr_read_x2apic(0x802);
>  	/* TMCCT */
>  	vmx_enable_intercept_msr_read_x2apic(0x839);
>  	/* TPR */
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 85e2f0a882ca..a10038258b80 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -6447,9 +6447,6 @@  static __init int hardware_setup(void)
 	for (msr = 0x800; msr <= 0x8ff; msr++)
 		vmx_disable_intercept_msr_read_x2apic(msr);
 
-	/* According SDM, in x2apic mode, the whole id reg is used.  But in
-	 * KVM, it only use the highest eight bits. Need to intercept it */
-	vmx_enable_intercept_msr_read_x2apic(0x802);
 	/* TMCCT */
 	vmx_enable_intercept_msr_read_x2apic(0x839);
 	/* TPR */