diff mbox

vfio-mdev: fix some error codes in the sample code

Message ID 20161124112726.GN17225@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter Nov. 24, 2016, 11:27 a.m. UTC 
This is just sample code.  We forget to set the error codes in a couple
places.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kirti Wankhede Nov. 28, 2016, noon UTC | #1 
On 11/24/2016 4:57 PM, Dan Carpenter wrote:
> This is just sample code.  We forget to set the error codes in a couple
> places.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index 6b633a4..40ed3c0 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -1447,6 +1447,7 @@ static int __init mtty_dev_init(void)
>  
>  	if (IS_ERR(mtty_dev.vd_class)) {
>  		pr_err("Error: failed to register mtty_dev class\n");
> +		ret = PTR_ERR(mtty_dev.vd_class);
>  		goto failed1;
>  	}
>  
> @@ -1458,7 +1459,8 @@ static int __init mtty_dev_init(void)
>  	if (ret)
>  		goto failed2;
>  
> -	if (mdev_register_device(&mtty_dev.dev, &mdev_fops) != 0)
> +	ret = mdev_register_device(&mtty_dev.dev, &mdev_fops);
> +	if (ret)
>  		goto failed3;
>  
>  	mutex_init(&mdev_list_lock);
> 

Thanks for fixing this. Looks good to me.

Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
index 6b633a4..40ed3c0 100644
--- a/samples/vfio-mdev/mtty.c
+++ b/samples/vfio-mdev/mtty.c
@@ -1447,6 +1447,7 @@  static int __init mtty_dev_init(void)
 
 	if (IS_ERR(mtty_dev.vd_class)) {
 		pr_err("Error: failed to register mtty_dev class\n");
+		ret = PTR_ERR(mtty_dev.vd_class);
 		goto failed1;
 	}
 
@@ -1458,7 +1459,8 @@  static int __init mtty_dev_init(void)
 	if (ret)
 		goto failed2;
 
-	if (mdev_register_device(&mtty_dev.dev, &mdev_fops) != 0)
+	ret = mdev_register_device(&mtty_dev.dev, &mdev_fops);
+	if (ret)
 		goto failed3;
 
 	mutex_init(&mdev_list_lock);