| Message ID | 20171027142855.21584-15-marc.zyngier@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 27/10/2017 16:28, Marc Zyngier wrote: > Handling CLEAR is pretty easy. Just ask the ITS driver to clear > the corresponding pending bit (which will turn into a CLEAR > command on the physical side). > > Acked-by: Christoffer Dall <cdall@linaro.org> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > virt/kvm/arm/vgic/vgic-its.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index 42ffb9084bb7..5778b50911e8 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -1070,6 +1070,10 @@ static int vgic_its_cmd_handle_clear(struct kvm *kvm, struct vgic_its *its, > > ite->irq->pending_latch = false; > > + if (ite->irq->hw) > + return irq_set_irqchip_state(ite->irq->host_irq, > + IRQCHIP_STATE_PENDING, false); > + nit: could be done before the pending_latch setting as this latter is not used in that case. Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > return 0; > } > >
diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index 42ffb9084bb7..5778b50911e8 100644 --- a/virt/kvm/arm/vgic/vgic-its.c +++ b/virt/kvm/arm/vgic/vgic-its.c @@ -1070,6 +1070,10 @@ static int vgic_its_cmd_handle_clear(struct kvm *kvm, struct vgic_its *its, ite->irq->pending_latch = false; + if (ite->irq->hw) + return irq_set_irqchip_state(ite->irq->host_irq, + IRQCHIP_STATE_PENDING, false); + return 0; }