From patchwork Sun Oct 29 20:48:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 10031663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4BAEA603B5 for ; Sun, 29 Oct 2017 20:49:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3EE4F2873A for ; Sun, 29 Oct 2017 20:49:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3343028762; Sun, 29 Oct 2017 20:49:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1958D28754 for ; Sun, 29 Oct 2017 20:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbdJ2Usu (ORCPT ); Sun, 29 Oct 2017 16:48:50 -0400 Received: from mail-bl2nam02on0088.outbound.protection.outlook.com ([104.47.38.88]:16608 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751483AbdJ2Usr (ORCPT ); Sun, 29 Oct 2017 16:48:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7Zj3JQhx6xo8qu7N06HHV9ygpPqCfEzCkIx9tPH54zM=; b=fGMexkrOHIL/E/Wy/hT7rFFkgKJ/OhKJWRfH4Crwy65lmJ3jYX/4abFSfJElyXSBzLXtH3gOtryva+H2G/Fl1RoN2UrgHId4DCZFU6uBkk/ppZ4Q7YZh+985z8puRP1lmpwmtUwNOcHop1MICS7al6xJyamYhSapIJGcKw3vYlE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from ubuntu-010236106000.amd.com (165.204.78.1) by BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Sun, 29 Oct 2017 20:48:39 +0000 From: Brijesh Singh To: bp@alien8.de Cc: Brijesh Singh , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Borislav Petkov , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support Date: Sun, 29 Oct 2017 15:48:25 -0500 Message-Id: <20171029204825.18260-1-brijesh.singh@amd.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20171020023413.122280-14-brijesh.singh@amd.com> References: <20171020023413.122280-14-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR2201CA0091.namprd22.prod.outlook.com (10.174.103.44) To BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fbbf5fe-7ed6-45a8-664d-08d51f0e6fdf X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199); SRVR:BY2PR12MB0147; X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 3:UGHJCTeVWR/e+TrA870D4aSxxbJLGOqlajlEdpvirR2OShpSeyMFR7ZTm2npxhcgb97N3UzaduSSQdqqPJiRk4XfFxyn4JLzXm43K1+7YMMH/09GyKTK3jJAvTp8RtPmJJFAb3AJeB8iD4MbEJG2vgZTUFbiueoUvUE8J/dg8B5aKZuytyrU0cEXgJ/ruwW1TF3qo1PCJTIRSH8/MVGCHJDOnoYro9B4ewFIyF0XCfUwQBKuGofiEaaaMw6ZNq8x; 25:nMzsbrcX9rogX9/vi9LwsXt4xBo69RYfiBNmEHzQwb9Hxt4SDv+XLBr3ROGy8Hblrp5fFhjXAGvZPJQHxm18ueHD/AToCjX0mZ9w5Zdanam/qs4NDy3aNlfLEsx/S5Y7om/tii5vyThviKeDts2RnutfZ6Y3lMGiXCjZF3doi/YxgdwfoW6M6veJhJgvZ7u6aHl72iUXP4qcn3yoOj+gt/i83OKDXyR+UMebDjE0x9xIqeIxue7zFTxMLPv/mwRHfwAh7AzYvbybploeqj1PM+7tXy2aGa6fntz0jkkmqLScd7ntl3RXemjp6iIlnbMS8+MNS7BGzIv6BLMyNtm9Uw==; 31:JUZCLAPeMD9KjwNQfr+vwWz7WnT7pYjgORUOG/LI80ZV7oRneq2d9GfQ7wGd0fGgMXC7RBlEArVRSPJNINVUFKltAOYqMezLYB9ikNv8tAYCI/LA46MAMMO7p70MVm4Zq855pgJuZco5hQgJznJvrVh7VpFhntXDjcYfM+yrJaV/U2GkgoxPkz9MyEl640t5d2kdz1dbHpfnK+YddxZz/EupWPBN6Pr4rqfBzqa00w4= X-MS-TrafficTypeDiagnostic: BY2PR12MB0147: X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 20:DTvfjunVgteENnLvkdE2TlpnkH+HmaNnMfsILhxqVV1FNB66FEAi9na7fytmaL8Xffe8UAEO1GjpbW3+NbYxD3yq3bwEnhFYuIreIgN5RfZnI6YWvhCf8IdGofGVuvmUKQgmrI1wTbk3y4XwunBN93lIDuAca9YyMYNbAPS8F4uFazqW6Sjjw0kpdUKlKObqQZddyiguhES6thxV7jcfR2IuxVLcOsNqum/9W7ZUuRm7R6FEH1oc1wCEeqv6huhJF+XE02wyuhijYEbImaVBbcygbGJyz9GYgkrVxWIy0BAJbb2QO9FS+5lo4x0miqcAa7c9ne3KizirKVRjkJq7FEZSB3UBz4HSH+cG/AjNuamXb105fwSiuFP3N8wIUeklDRHpCDSC5W8AEUjFhhsSo6gFKO/hjbwBNKB+41AW4ZgsEXizdsrhi5EDawGqCjBLfwMetnkJr5EONN7eptxXPJMctmh0W4Gx1qyN1fcBxLMFeK2ORw4Qn0qkp9E08Kp4; 4:hM8nXAYoTySttIpL0MPMgyLXHPb3lWgYlurKt5GyZCe1Dpe4NlcC8lJRPzqmWGnSvM4thPo7FesVEwOZ4726W0R8Jws5h8fxF5TXivQfknHCVde0vCuPvrqea05h/dq/KtL0QVZEW4WLCvfX49NH311Z6MjyODFFoYLXT69yufSR2n8krHqt4CGqpGfaZrPCWt63c4qbsEsfs6FrA/V0QVjf6VTHV7O9tJRaYOPCCvQX8kaJ4CShZyyRoWBK0RcpFs8yckJWVrpZKS/HJKPxa7b8jL6tzvrpeRGjo7x/8G/E/wGPsko0WzWLMJ94pC8ioilEuJ+b/vyfA0QDJpPT9g== X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3231020)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR12MB0147; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR12MB0147; X-Forefront-PRVS: 0475418F50 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(199003)(189002)(8936002)(4326008)(2906002)(50466002)(6116002)(3846002)(1076002)(23676002)(316002)(54906003)(86362001)(575784001)(25786009)(2870700001)(36756003)(50986999)(2361001)(106356001)(53416004)(53936002)(305945005)(7736002)(50226002)(966005)(97736004)(33646002)(2950100002)(6666003)(5660300001)(76176999)(6486002)(478600001)(6916009)(6306002)(68736007)(101416001)(81166006)(81156014)(2351001)(47776003)(189998001)(16526018)(8676002)(105586002)(66066001)(134885004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR12MB0147; H:ubuntu-010236106000.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ3OzIzOmtlY2VSNkhmVFE3WnA5ZDRSajFvYmdRdGdo?= =?utf-8?B?eWhvZ0ZvS3Yrc2JVSEVlTHRZMFhuaVBvQnVQcHFHVGhqN2JSekJHcHMrR21t?= =?utf-8?B?OHN2WXRKMXRlL1lFNlVRTTJGVVNYaWpHMjV4bHBxdEQ2Y1QycGZLTDV4MnVF?= =?utf-8?B?bGMzYkhtL0wwdisxVDR4Yld5V29YbnArSmgxYk9JRVgzRmJHSjBxRnFybUUr?= =?utf-8?B?RWIycXZEQjdEY2kyemhEZ2c5ZGRrdU15K0xYdDVSTnpPYytjcURnendJeUJn?= =?utf-8?B?bVdZbmdpTEJDL1lhTzFXa1ZlQzduK0tLN0pNSU4xV3NqK3NIVFczS3htYlQr?= =?utf-8?B?MVREdktsemVEVTBrMFpFdkdzRWt2a3JvOHFrVWpEandYNmJzbUNQUWw5Ukdo?= =?utf-8?B?TzRvemV1ek56bUJzZXZna3lOZk5zSDI2WWI5bmxRK0hqMG5kc0NkYXR3eGJj?= =?utf-8?B?OWpOSlJzMEJKclZyWUZlMk5GN2JmR0tGd2RkNElMRUtuWjFWUnkrbVJWcDls?= =?utf-8?B?emtUS2Y0L3d2eUdrMG5tVytrVlJneDNBVXBRZmJEVnNUTTFNcmVkYU5uM0dS?= =?utf-8?B?RHZGQnE4b1hwckJtMDRLc1NIODBrV1pUc2ltWFdlbkNmT3BwR09vdWN1QnFB?= =?utf-8?B?OEFpVWd0TEQwTkNLMHU2ZTNKTjRYNGdMMDhva1pUcmttNnFwNDU2OEdsT0JT?= =?utf-8?B?OFJnTVlEd1N0bHRiQkErQURKK1NqL2VvQXZFYllwSU9HenJ0UjFkb0V2eGFS?= =?utf-8?B?ZnNVSGtoaDZnYzRZRXZObWswT2NaR2hRZzNmdTVXcFVEdTNCbGEwRi9JUm1Q?= =?utf-8?B?L1BOMlBmTDBwVHJka042bW80ZWc3a3ZackR5eG42VU9QN1VvNUtZdXdZTkNp?= =?utf-8?B?K096bGNIQkR0dE5aS3NTcXBWbUptMVVyNDMrZ1BCTWd2YzNSTEhocGhFa1Jk?= =?utf-8?B?SGU3TWQ4ZkRSVTlnK3BnWXBCemRMcDZWSXg2K2dTeEpYR1F1OGk5VUwzSllX?= =?utf-8?B?RWlQaG1XUkFpc1lBMktEV2tTVHkva0R2WEJqMkNXeDl3YnlOZ3d3RTg5Q3Nq?= =?utf-8?B?SDVsMWdUQm9mSkU0b1E1a1craVhSdDRHUjN5cCs1eHRGVWIyMHY1cXJZcEZB?= =?utf-8?B?VWVTVXlJV2RpVXorNVkvNlZKbkNTYjUxTGV0bXIvOGtnTmU0VGRpNWJqdndu?= =?utf-8?B?NnJDOFhxTTJaQWpkczFXRDd3ZnlPUWdoVzFVS1NIdlJCSVJNRE1SQUxORGxw?= =?utf-8?B?WEsrZFMwY29Na1Y3Y3NwM2JIOXd2cExTYWs3Zi9xTVRyRkJlb2tCdFhhTEs4?= =?utf-8?B?TzZDdGw4QjlqTUo2VUFabFBmR296Q2VuSGtWT0NTbDJWVmRNVjhSemI0VXN4?= =?utf-8?B?Wi9yV1VieURMMWJibllDeVk2K0RubGMzNWxjMEVLcmhYOGl5ZVhMc1Q5UHhU?= =?utf-8?B?ZE9KeG4vYWZKWUNhdXE4eWhaTVkyRTZLeU53aGttclNkdVRBR0FHMENUd2t0?= =?utf-8?B?dDZhMWg5SWtaZnB5ZmNla0R6UWtTYWJqOStxNVVoUGk4MnNxd2F6UXBYZWdX?= =?utf-8?B?ZFRxeGxXcU1td1RWWFV6NlhvWjdDMTNOS05qVS9TK1Y1SjZSQ3NzMWdoSzA1?= =?utf-8?Q?h8wxxMr2JiXJ84jUfUjn?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 6:xrlP2pezdR6kqZQohAH0p77LME97cqNDNTOPLPr/Mol12Cnm4hWjsgiq4dfGECV0rdV4/Y9/Hi3y+wwB35OoEwkHRM9z5ADHMPDlI5KRgFVbBvgThX/zY23RAu8SkqjOJsU7pp+QzsnSYObi6d/iGtg/9dKeD8pKLpvotf65UT7UAZNtNdy5X83DSVBhZeRYk+QFSeheByEUJm3trk01HFMD3Rbu6dZk1RFiAqj+tPJ90XTpkLqRp9EOT4eKPLTCQcZDgcYhBWKTA1AmcbZSWGxxprpsTNA30Ce+4j5HkTevy5acqtzeG/WscU05Fnixict1xdTa2XZNj1lKqQpQN76Sn3RS5lgBb0l0nxsDjRU=; 5:DkNzq64Rw0FdFt3A77GOzAnOH85I8QDP1W+9bKcrZ/1GsfVsDsRb+TO9yGYSZttXu/1tE9+ePvu9Kc9i6U3i7dYaqcCDL2xkiA8Vgo/4U22pW2c429VuvDggGHpk8riyuVnx72whIQLFHIf7Ov5eslbDWrIvDy9BYYuYksZlgmM=; 24:gzHCofKFmgp2xDig4KP1KjL7hiyR7lv380wailZmvFIR3i4n0nf6T1wnqHfIoZHK0y4M4AkKmL00ClmakAP6quv4FZNOh0voDEcC1mI1AOA=; 7:Brd9mRWqHqlqluHyTv9xUtxN1/y/rHAWIssoDmBy71FFbE9EAa+uhUiQueE2TcV5HZ1wEjCYm4YhplZGYrCYTkXkorJLraFw/rwnn5DxhnFsoraE69nYjj/yxi+Il+vfTHiyGz8nKIAJ73RFDmRxikqBEcivnzNloXJOVkch7cj+nj3O3IAkRnw+Y+ogn+ubLarsGzKlju0IoulPC0+06cnSyS7j0NYbUXoFjsYIYn5WjwO1ksPvCCoRfbQ4i3gb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0147; 20:ZjJ5WlLlRl8Lcuh6t9Wtwlu/OR7PWJ7p5tP/vGyHl95UEv5xqksS1eS8TaQ6MFxQdm7bM6giaRnOYJ6omn3NibL+c8EOq2MPojhUEOpiXb18vr3EL4MsUdpc/XdsGzKqZUVAsX/k2MHKNzeOKu53c8KBwcyr1fqaFT/gp5nnnY0lWYJNdcIWt8RNeWxptUv1Imfd5hk5ffxFCJDLgoNRzseZnURpZ7/v+MaMU/+dfMjBzkeisFjh3cMSaazB3Az8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2017 20:48:39.7832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbbf5fe-7ed6-45a8-664d-08d51f0e6fdf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0147 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP AMD's new Secure Encrypted Virtualization (SEV) feature allows the memory contents of virtual machines to be transparently encrypted with a key unique to the VM. The programming and management of the encryption keys are handled by the AMD Secure Processor (AMD-SP) which exposes the commands for these tasks. The complete spec is available at: http://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf Extend the AMD-SP driver to provide the following support: - an in-kernel API to communicate with the SEV firmware. The API can be used by the hypervisor to create encryption context for a SEV guest. - a userspace IOCTL to manage the platform certificates. Cc: Paolo Bonzini Cc: "Radim Krčmář" Cc: Borislav Petkov Cc: Herbert Xu Cc: Gary Hook Cc: Tom Lendacky Cc: linux-crypto@vger.kernel.org Cc: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Improvements-by: Borislav Petkov Signed-off-by: Brijesh Singh --- Boris, I have tried to minimize the INIT -> SHUTDOWN transition by keeping state information in sev_state variable. Since we INIT the platform during the modprobe time hence we no longer need the kref count and init mutex. Here are list of changes. Changes since v6: * Add functions to init and shutdown firmware during modprobe * Add sev_state variable in psp_device to keep track of the INIT and SHUTDOWN state * Don't allow caller to shutdown the FW because SHUTDOWN will be done during the module removal. * Drop the fw_init_mutex and init_refcount because we no longer allow apps to INIT and UINIT the platform drivers/crypto/ccp/psp-dev.c | 360 +++++++++++++++++++++++++++++++++++++++++++ drivers/crypto/ccp/psp-dev.h | 22 +++ drivers/crypto/ccp/sp-dev.c | 9 ++ drivers/crypto/ccp/sp-dev.h | 4 + include/linux/psp-sev.h | 158 +++++++++++++++++++ 5 files changed, 553 insertions(+) diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c index b5789f878560..060f57ac08b3 100644 --- a/drivers/crypto/ccp/psp-dev.c +++ b/drivers/crypto/ccp/psp-dev.c @@ -26,6 +26,15 @@ #include "sp-dev.h" #include "psp-dev.h" +#define DEVICE_NAME "sev" + +static DEFINE_MUTEX(sev_cmd_mutex); +static struct sev_misc_dev *misc_dev; +static struct psp_device *psp_master; + +static int sev_platform_shutdown_locked(int *error); +static int sev_platform_init_locked(struct sev_data_init *data, int *error); + static struct psp_device *psp_alloc_struct(struct sp_device *sp) { struct device *dev = sp->dev; @@ -45,9 +54,304 @@ static struct psp_device *psp_alloc_struct(struct sp_device *sp) static irqreturn_t psp_irq_handler(int irq, void *data) { + struct psp_device *psp = data; + unsigned int status; + int reg; + + /* Read the interrupt status: */ + status = ioread32(psp->io_regs + PSP_P2CMSG_INTSTS); + + /* Check if it is command completion: */ + if (!(status & BIT(PSP_CMD_COMPLETE_REG))) + goto done; + + /* Check if it is SEV command completion: */ + reg = ioread32(psp->io_regs + PSP_CMDRESP); + if (reg & PSP_CMDRESP_RESP) { + psp->sev_int_rcvd = 1; + wake_up(&psp->sev_int_queue); + } + +done: + /* Clear the interrupt status by writing the same value we read. */ + iowrite32(status, psp->io_regs + PSP_P2CMSG_INTSTS); + return IRQ_HANDLED; } +static void sev_wait_cmd_ioc(struct psp_device *psp, unsigned int *reg) +{ + psp->sev_int_rcvd = 0; + + wait_event(psp->sev_int_queue, psp->sev_int_rcvd); + *reg = ioread32(psp->io_regs + PSP_CMDRESP); +} + +static int sev_cmd_buffer_len(int cmd) +{ + switch (cmd) { + case SEV_CMD_INIT: return sizeof(struct sev_data_init); + case SEV_CMD_PLATFORM_STATUS: return sizeof(struct sev_user_data_status); + case SEV_CMD_PEK_CSR: return sizeof(struct sev_data_pek_csr); + case SEV_CMD_PEK_CERT_IMPORT: return sizeof(struct sev_data_pek_cert_import); + case SEV_CMD_PDH_CERT_EXPORT: return sizeof(struct sev_data_pdh_cert_export); + case SEV_CMD_LAUNCH_START: return sizeof(struct sev_data_launch_start); + case SEV_CMD_LAUNCH_UPDATE_DATA: return sizeof(struct sev_data_launch_update_data); + case SEV_CMD_LAUNCH_UPDATE_VMSA: return sizeof(struct sev_data_launch_update_vmsa); + case SEV_CMD_LAUNCH_FINISH: return sizeof(struct sev_data_launch_finish); + case SEV_CMD_LAUNCH_MEASURE: return sizeof(struct sev_data_launch_measure); + case SEV_CMD_ACTIVATE: return sizeof(struct sev_data_activate); + case SEV_CMD_DEACTIVATE: return sizeof(struct sev_data_deactivate); + case SEV_CMD_DECOMMISSION: return sizeof(struct sev_data_decommission); + case SEV_CMD_GUEST_STATUS: return sizeof(struct sev_data_guest_status); + case SEV_CMD_DBG_DECRYPT: return sizeof(struct sev_data_dbg); + case SEV_CMD_DBG_ENCRYPT: return sizeof(struct sev_data_dbg); + case SEV_CMD_SEND_START: return sizeof(struct sev_data_send_start); + case SEV_CMD_SEND_UPDATE_DATA: return sizeof(struct sev_data_send_update_data); + case SEV_CMD_SEND_UPDATE_VMSA: return sizeof(struct sev_data_send_update_vmsa); + case SEV_CMD_SEND_FINISH: return sizeof(struct sev_data_send_finish); + case SEV_CMD_RECEIVE_START: return sizeof(struct sev_data_receive_start); + case SEV_CMD_RECEIVE_FINISH: return sizeof(struct sev_data_receive_finish); + case SEV_CMD_RECEIVE_UPDATE_DATA: return sizeof(struct sev_data_receive_update_data); + case SEV_CMD_RECEIVE_UPDATE_VMSA: return sizeof(struct sev_data_receive_update_vmsa); + case SEV_CMD_LAUNCH_UPDATE_SECRET: return sizeof(struct sev_data_launch_secret); + default: return 0; + } + + return 0; +} + +static int sev_do_cmd_locked(int cmd, void *data, int *psp_ret) +{ + struct psp_device *psp = psp_master; + unsigned int phys_lsb, phys_msb; + unsigned int reg, ret = 0; + + if (!psp) + return -ENODEV; + + /* Get the physical address of the command buffer */ + phys_lsb = data ? lower_32_bits(__psp_pa(data)) : 0; + phys_msb = data ? upper_32_bits(__psp_pa(data)) : 0; + + dev_dbg(psp->dev, "sev command id %#x buffer 0x%08x%08x\n", + cmd, phys_msb, phys_lsb); + + print_hex_dump_debug("(in): ", DUMP_PREFIX_OFFSET, 16, 2, data, + sev_cmd_buffer_len(cmd), false); + + iowrite32(phys_lsb, psp->io_regs + PSP_CMDBUFF_ADDR_LO); + iowrite32(phys_msb, psp->io_regs + PSP_CMDBUFF_ADDR_HI); + + reg = cmd; + reg <<= PSP_CMDRESP_CMD_SHIFT; + reg |= PSP_CMDRESP_IOC; + iowrite32(reg, psp->io_regs + PSP_CMDRESP); + + /* wait for command completion */ + sev_wait_cmd_ioc(psp, ®); + + if (psp_ret) + *psp_ret = reg & PSP_CMDRESP_ERR_MASK; + + if (reg & PSP_CMDRESP_ERR_MASK) { + dev_dbg(psp->dev, "sev command %#x failed (%#010x)\n", + cmd, reg & PSP_CMDRESP_ERR_MASK); + ret = -EIO; + } + + print_hex_dump_debug("(out): ", DUMP_PREFIX_OFFSET, 16, 2, data, + sev_cmd_buffer_len(cmd), false); + + return ret; +} + +static int sev_do_cmd(int cmd, void *data, int *psp_ret) +{ + int rc; + + mutex_lock(&sev_cmd_mutex); + rc = sev_do_cmd_locked(cmd, data, psp_ret); + mutex_unlock(&sev_cmd_mutex); + + return rc; +} + +static long sev_ioctl(struct file *file, unsigned int ioctl, unsigned long arg) +{ + return -ENOTTY; +} + +static const struct file_operations sev_fops = { + .owner = THIS_MODULE, + .unlocked_ioctl = sev_ioctl, +}; + +static int sev_platform_init_locked(struct sev_data_init *data, int *error) +{ + struct psp_device *psp = psp_master; + struct sev_data_init *input = NULL; + int rc = 0; + + if (!psp) + return -ENODEV; + + if (psp->sev_state == SEV_STATE_INIT) + return 0; + + if (!data) { + input = kzalloc(sizeof(*input), GFP_KERNEL); + if (!input) + return -ENOMEM; + + data = input; + } + + rc = sev_do_cmd_locked(SEV_CMD_INIT, data, error); + if (rc) + goto e_free; + + psp->sev_state = SEV_STATE_INIT; + dev_dbg(psp->dev, "SEV firmware intialized\n"); + +e_free: + kfree(input); + return rc; +} + +int sev_platform_init(struct sev_data_init *data, int *error) +{ + int rc; + + mutex_lock(&sev_cmd_mutex); + rc = sev_platform_init_locked(data, error); + mutex_unlock(&sev_cmd_mutex); + + return rc; +} +EXPORT_SYMBOL_GPL(sev_platform_init); + +static int sev_platform_shutdown_locked(int *error) +{ + int ret; + + ret = sev_do_cmd_locked(SEV_CMD_SHUTDOWN, 0, error); + if (ret) + return ret; + + psp_master->sev_state = SEV_STATE_UNINIT; + dev_dbg(psp_master->dev, "SEV firmware shutdown\n"); + + return ret; +} + +int sev_platform_shutdown(int *error) +{ + if (error) + *error = 0; + + return 0; +} +EXPORT_SYMBOL_GPL(sev_platform_shutdown); + +int sev_platform_status(struct sev_user_data_status *data, int *error) +{ + return sev_do_cmd(SEV_CMD_PLATFORM_STATUS, data, error); +} +EXPORT_SYMBOL_GPL(sev_platform_status); + +int sev_issue_cmd_external_user(struct file *filep, unsigned int cmd, + void *data, int *error) +{ + if (!filep || filep->f_op != &sev_fops) + return -EBADF; + + return sev_do_cmd(cmd, data, error); +} +EXPORT_SYMBOL_GPL(sev_issue_cmd_external_user); + +int sev_guest_deactivate(struct sev_data_deactivate *data, int *error) +{ + return sev_do_cmd(SEV_CMD_DEACTIVATE, data, error); +} +EXPORT_SYMBOL_GPL(sev_guest_deactivate); + +int sev_guest_activate(struct sev_data_activate *data, int *error) +{ + return sev_do_cmd(SEV_CMD_ACTIVATE, data, error); +} +EXPORT_SYMBOL_GPL(sev_guest_activate); + +int sev_guest_decommission(struct sev_data_decommission *data, int *error) +{ + return sev_do_cmd(SEV_CMD_DECOMMISSION, data, error); +} +EXPORT_SYMBOL_GPL(sev_guest_decommission); + +int sev_guest_df_flush(int *error) +{ + return sev_do_cmd(SEV_CMD_DF_FLUSH, 0, error); +} +EXPORT_SYMBOL_GPL(sev_guest_df_flush); + +static int sev_ops_init(struct psp_device *psp) +{ + struct device *dev = psp->dev; + int ret; + + /* + * SEV feature support can be detected on multiple devices but the SEV + * FW commands must be issued on the master. During probe, we do not + * know the master hence we create /dev/sev on the first device probe. + * sev_do_cmd() finds the right master device to which to issue the + * command to the firmware. + */ + if (!misc_dev) { + struct miscdevice *misc; + + misc_dev = devm_kzalloc(dev, sizeof(*misc_dev), GFP_KERNEL); + if (!misc_dev) + return -ENOMEM; + + misc = &misc_dev->misc; + misc->minor = MISC_DYNAMIC_MINOR; + misc->name = DEVICE_NAME; + misc->fops = &sev_fops; + + ret = misc_register(misc); + if (ret) + return ret; + + kref_init(&misc_dev->refcount); + } else { + kref_get(&misc_dev->refcount); + } + + init_waitqueue_head(&psp->sev_int_queue); + psp->sev_misc = misc_dev; + dev_dbg(dev, "registered SEV device\n"); + + return 0; +} + +static int sev_init(struct psp_device *psp) +{ + /* Check if device supports SEV feature */ + if (!(ioread32(psp->io_regs + PSP_FEATURE_REG) & 1)) { + dev_dbg(psp->dev, "device does not support SEV\n"); + return 1; + } + + return sev_ops_init(psp); +} + +static void sev_exit(struct kref *ref) +{ + struct sev_misc_dev *misc_dev = container_of(ref, struct sev_misc_dev, refcount); + + misc_deregister(&misc_dev->misc); +} + int psp_dev_init(struct sp_device *sp) { struct device *dev = sp->dev; @@ -84,11 +388,17 @@ int psp_dev_init(struct sp_device *sp) if (sp->set_psp_master_device) sp->set_psp_master_device(sp); + ret = sev_init(psp); + if (ret) + goto e_irq; + /* Enable interrupt */ iowrite32(-1, psp->io_regs + PSP_P2CMSG_INTEN); return 0; +e_irq: + sp_free_psp_irq(psp->sp, psp); e_err: sp->psp_data = NULL; @@ -101,5 +411,55 @@ void psp_dev_destroy(struct sp_device *sp) { struct psp_device *psp = sp->psp_data; + if (psp->sev_misc) + kref_put(&misc_dev->refcount, sev_exit); + sp_free_psp_irq(sp, psp); } + +void psp_pci_init(void) +{ + struct sev_user_data_status *data; + struct sp_device *sp; + int error, rc; + + sp = sp_get_psp_master_device(); + if (!sp) + return; + + psp_master = sp->psp_data; + + /* Initialize the platform */ + rc = sev_platform_init(NULL, &error); + if (rc) { + dev_err(sp->dev, "SEV: failed to INIT error %#x\n", error); + return; + } + + /* Display SEV firmware version */ + data = kzalloc(sizeof (*data), GFP_KERNEL); + if (!data) + return; + + rc = sev_platform_status(data, &error); + if (rc) { + dev_err(sp->dev, "SEV: failed to get status error %#x\n", error); + goto e_free; + } + + dev_info(sp->dev, "SEV API:%d.%d build:%d\n", + data->api_major, data->api_minor, data->build); + +e_free: + kfree(data); +} + +void psp_pci_exit(void) +{ + if (!psp_master) + return; + + mutex_lock(&sev_cmd_mutex); + sev_platform_shutdown_locked(NULL); + mutex_unlock(&sev_cmd_mutex); +} diff --git a/drivers/crypto/ccp/psp-dev.h b/drivers/crypto/ccp/psp-dev.h index 55b7808367c3..98889b721904 100644 --- a/drivers/crypto/ccp/psp-dev.h +++ b/drivers/crypto/ccp/psp-dev.h @@ -25,9 +25,21 @@ #include #include #include +#include +#include #include "sp-dev.h" +#define PSP_C2PMSG(_num) ((_num) << 2) +#define PSP_CMDRESP PSP_C2PMSG(32) +#define PSP_CMDBUFF_ADDR_LO PSP_C2PMSG(56) +#define PSP_CMDBUFF_ADDR_HI PSP_C2PMSG(57) +#define PSP_FEATURE_REG PSP_C2PMSG(63) + +#define PSP_P2CMSG(_num) ((_num) << 2) +#define PSP_CMD_COMPLETE_REG 1 +#define PSP_CMD_COMPLETE PSP_P2CMSG(PSP_CMD_COMPLETE_REG) + #define PSP_P2CMSG_INTEN 0x0110 #define PSP_P2CMSG_INTSTS 0x0114 @@ -44,6 +56,11 @@ #define MAX_PSP_NAME_LEN 16 +struct sev_misc_dev { + struct kref refcount; + struct miscdevice misc; +}; + struct psp_device { struct list_head entry; @@ -54,6 +71,11 @@ struct psp_device { struct sp_device *sp; void __iomem *io_regs; + + int sev_state; + unsigned int sev_int_rcvd; + wait_queue_head_t sev_int_queue; + struct sev_misc_dev *sev_misc; }; #endif /* __PSP_DEV_H */ diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c index cf101c039c8f..eb0da6572720 100644 --- a/drivers/crypto/ccp/sp-dev.c +++ b/drivers/crypto/ccp/sp-dev.c @@ -272,6 +272,10 @@ static int __init sp_mod_init(void) if (ret) return ret; +#ifdef CONFIG_CRYPTO_DEV_SP_PSP + psp_pci_init(); +#endif + return 0; #endif @@ -291,6 +295,11 @@ static int __init sp_mod_init(void) static void __exit sp_mod_exit(void) { #ifdef CONFIG_X86 + +#ifdef CONFIG_CRYPTO_DEV_SP_PSP + psp_pci_exit(); +#endif + sp_pci_exit(); #endif diff --git a/drivers/crypto/ccp/sp-dev.h b/drivers/crypto/ccp/sp-dev.h index 909cf3e436b4..acb197b66ced 100644 --- a/drivers/crypto/ccp/sp-dev.h +++ b/drivers/crypto/ccp/sp-dev.h @@ -143,12 +143,16 @@ static inline int ccp_dev_resume(struct sp_device *sp) #ifdef CONFIG_CRYPTO_DEV_SP_PSP int psp_dev_init(struct sp_device *sp); +void psp_pci_init(void); void psp_dev_destroy(struct sp_device *sp); +void psp_pci_exit(void); #else /* !CONFIG_CRYPTO_DEV_SP_PSP */ static inline int psp_dev_init(struct sp_device *sp) { return 0; } +static inline void psp_pci_init(void) { } static inline void psp_dev_destroy(struct sp_device *sp) { } +static inline void psp_pci_exit(void) { } #endif /* CONFIG_CRYPTO_DEV_SP_PSP */ diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h index 15bda519538e..7ddce7dec464 100644 --- a/include/linux/psp-sev.h +++ b/include/linux/psp-sev.h @@ -491,4 +491,162 @@ struct sev_data_dbg { u32 len; /* In */ } __packed; +#ifdef CONFIG_CRYPTO_DEV_SP_PSP + +/** + * sev_platform_init - perform SEV INIT command + * + * @init: sev_data_init structure to be processed + * @error: SEV command return code + * + * Returns: + * 0 if the SEV successfully processed the command + * -%ENODEV if the SEV device is not available + * -%ENOTSUPP if the SEV does not support SEV + * -%ETIMEDOUT if the SEV command timed out + * -%EIO if the SEV returned a non-zero return code + */ +int sev_platform_init(struct sev_data_init *init, int *error); + +/** + * sev_platform_shutdown - perform SEV SHUTDOWN command + * @error: SEV command return code + * + * Returns: + * 0 if the SEV successfully processed the command + * -%ENODEV if the SEV device is not available + * -%ENOTSUPP if the SEV does not support SEV + * -%ETIMEDOUT if the SEV command timed out + * -%EIO if the SEV returned a non-zero return code + */ +int sev_platform_shutdown(int *error); + +/** + * sev_platform_status - perform SEV PLATFORM_STATUS command + * + * @status: sev_user_data_status structure to be processed + * @error: SEV command return code + * + * Returns: + * 0 if the SEV successfully processed the command + * -%ENODEV if the SEV device is not available + * -%ENOTSUPP if the SEV does not support SEV + * -%ETIMEDOUT if the SEV command timed out + * -%EIO if the SEV returned a non-zero return code + */ +int sev_platform_status(struct sev_user_data_status *status, int *error); + +/** + * sev_issue_cmd_external_user - issue SEV command by other driver with a file + * handle. + * + * This function can be used by other drivers to issue a SEV command on + * behalf of userspace. The caller must pass a valid SEV file descriptor + * so that we know that it has access to SEV device. + * + * @filep - SEV device file pointer + * @cmd - command to issue + * @data - command buffer + * @error: SEV command return code + * + * Returns: + * 0 if the SEV successfully processed the command + * -%ENODEV if the SEV device is not available + * -%ENOTSUPP if the SEV does not support SEV + * -%ETIMEDOUT if the SEV command timed out + * -%EIO if the SEV returned a non-zero return code + * -%EINVAL if the SEV file descriptor is not valid + */ +int sev_issue_cmd_external_user(struct file *filep, unsigned int id, + void *data, int *error); + +/** + * sev_guest_deactivate - perform SEV DEACTIVATE command + * + * @deactivate: sev_data_deactivate structure to be processed + * @sev_ret: sev command return code + * + * Returns: + * 0 if the sev successfully processed the command + * -%ENODEV if the sev device is not available + * -%ENOTSUPP if the sev does not support SEV + * -%ETIMEDOUT if the sev command timed out + * -%EIO if the sev returned a non-zero return code + */ +int sev_guest_deactivate(struct sev_data_deactivate *data, int *error); + +/** + * sev_guest_activate - perform SEV ACTIVATE command + * + * @activate: sev_data_activate structure to be processed + * @sev_ret: sev command return code + * + * Returns: + * 0 if the sev successfully processed the command + * -%ENODEV if the sev device is not available + * -%ENOTSUPP if the sev does not support SEV + * -%ETIMEDOUT if the sev command timed out + * -%EIO if the sev returned a non-zero return code + */ +int sev_guest_activate(struct sev_data_activate *data, int *error); + +/** + * sev_guest_df_flush - perform SEV DF_FLUSH command + * + * @sev_ret: sev command return code + * + * Returns: + * 0 if the sev successfully processed the command + * -%ENODEV if the sev device is not available + * -%ENOTSUPP if the sev does not support SEV + * -%ETIMEDOUT if the sev command timed out + * -%EIO if the sev returned a non-zero return code + */ +int sev_guest_df_flush(int *error); + +/** + * sev_guest_decommission - perform SEV DECOMMISSION command + * + * @decommission: sev_data_decommission structure to be processed + * @sev_ret: sev command return code + * + * Returns: + * 0 if the sev successfully processed the command + * -%ENODEV if the sev device is not available + * -%ENOTSUPP if the sev does not support SEV + * -%ETIMEDOUT if the sev command timed out + * -%EIO if the sev returned a non-zero return code + */ +int sev_guest_decommission(struct sev_data_decommission *data, int *error); + +#else /* !CONFIG_CRYPTO_DEV_SP_PSP */ + +static inline int +sev_platform_status(struct sev_user_data_status *status, int *error) { return -ENODEV; } + +static inline int +sev_platform_init(struct sev_data_init *init, int *error) { return -ENODEV; } + +static inline int sev_platform_shutdown(int *error) { return -ENODEV; } + +static inline int +sev_guest_deactivate(struct sev_data_deactivate *data, int *error) { return -ENODEV; } + +static inline int +sev_guest_decommission(struct sev_data_decommission *data, int *error) { return -ENODEV; } + +static inline int +sev_guest_activate(struct sev_data_activate *data, int *error) { return -ENODEV; } + +static inline int sev_guest_df_flush(int *error) { return -ENODEV; } + +static inline int +sev_issue_cmd_external_user(struct file *filep, + unsigned int id, void *data, int *error) +{ + return -ENODEV; +} + +#endif /* CONFIG_CRYPTO_DEV_SP_PSP */ + #endif /* __PSP_SEV_H__ */