[05/12] s390/css: expose the AIV facility

Commit Message

Christian Borntraeger Jan. 16, 2018, 8:02 p.m. UTC

From: Michael Mueller <[e-mail]>

The patch exposes the Adapter Interruption Virtualization facility (AIV)
of the general channel subsystem characteristics.

Signed-off-by: Michael Mueller <[e-mail]>
Reviewed-by: Halil Pasic <[e-mail]>
Reviewed-by: Christian Borntraeger <[e-mail]>
Signed-off-by: Christian Borntraeger <[e-mail]>
---
 arch/s390/include/asm/css_chars.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

David Hildenbrand Jan. 17, 2018, 3:19 p.m. UTC | #1

On 16.01.2018 21:02, Christian Borntraeger wrote:
> From: Michael Mueller <[e-mail]>
> 
> The patch exposes the Adapter Interruption Virtualization facility (AIV)
> of the general channel subsystem characteristics.
> 
> Signed-off-by: Michael Mueller <[e-mail]>
> Reviewed-by: Halil Pasic <[e-mail]>
> Reviewed-by: Christian Borntraeger <[e-mail]>
> Signed-off-by: Christian Borntraeger <[e-mail]>
> ---
>  arch/s390/include/asm/css_chars.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
> index a478eb61aaf7..fb56fa3283a2 100644
> --- a/arch/s390/include/asm/css_chars.h
> +++ b/arch/s390/include/asm/css_chars.h
> @@ -20,7 +20,9 @@ struct css_general_char {
>  	u32 aif_tdd : 1; /* bit 56 */
>  	u32 : 1;
>  	u32 qebsm : 1;	 /* bit 58 */
> -	u32 : 8;
> +	u32 : 2;
> +	u32 aiv : 1;     /* bit 61 */
> +	u32 : 5;
>  	u32 aif_osa : 1; /* bit 67 */
>  	u32 : 12;
>  	u32 eadm_rf : 1; /* bit 80 */
> 

"Expose" sounds like actually forwarding something / enabling a bit.
Wonder if this can be squashed with another patch?

Or rename to something like "define" ...

Michael Mueller Jan. 18, 2018, 12:02 p.m. UTC | #2

On 17.01.18 16:19, David Hildenbrand wrote:
> On 16.01.2018 21:02, Christian Borntraeger wrote:
>> From: Michael Mueller <[e-mail]>
>>
>> The patch exposes the Adapter Interruption Virtualization facility (AIV)
>> of the general channel subsystem characteristics.
>>
>> Signed-off-by: Michael Mueller <[e-mail]>
>> Reviewed-by: Halil Pasic <[e-mail]>
>> Reviewed-by: Christian Borntraeger <[e-mail]>
>> Signed-off-by: Christian Borntraeger <[e-mail]>
>> ---
>>   arch/s390/include/asm/css_chars.h | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
>> index a478eb61aaf7..fb56fa3283a2 100644
>> --- a/arch/s390/include/asm/css_chars.h
>> +++ b/arch/s390/include/asm/css_chars.h
>> @@ -20,7 +20,9 @@ struct css_general_char {
>>   	u32 aif_tdd : 1; /* bit 56 */
>>   	u32 : 1;
>>   	u32 qebsm : 1;	 /* bit 58 */
>> -	u32 : 8;
>> +	u32 : 2;
>> +	u32 aiv : 1;     /* bit 61 */
>> +	u32 : 5;
>>   	u32 aif_osa : 1; /* bit 67 */
>>   	u32 : 12;
>>   	u32 eadm_rf : 1; /* bit 80 */
>>
> "Expose" sounds like actually forwarding something / enabling a bit.
Expose here basically means to make sth. visible what was already available.
> Wonder if this can be squashed with another patch?
>
> Or rename to something like "define" ...
I don't plan to change anything.
>
Thanks,
Michael

Cornelia Huck Jan. 18, 2018, 5:54 p.m. UTC | #3

On Thu, 18 Jan 2018 13:02:45 +0100
Michael Mueller <[e-mail]> wrote:

> On 17.01.18 16:19, David Hildenbrand wrote:
> > On 16.01.2018 21:02, Christian Borntraeger wrote:  
> >> From: Michael Mueller <[e-mail]>
> >>
> >> The patch exposes the Adapter Interruption Virtualization facility (AIV)
> >> of the general channel subsystem characteristics.
> >>
> >> Signed-off-by: Michael Mueller <[e-mail]>
> >> Reviewed-by: Halil Pasic <[e-mail]>
> >> Reviewed-by: Christian Borntraeger <[e-mail]>
> >> Signed-off-by: Christian Borntraeger <[e-mail]>
> >> ---
> >>   arch/s390/include/asm/css_chars.h | 4 +++-
> >>   1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
> >> index a478eb61aaf7..fb56fa3283a2 100644
> >> --- a/arch/s390/include/asm/css_chars.h
> >> +++ b/arch/s390/include/asm/css_chars.h
> >> @@ -20,7 +20,9 @@ struct css_general_char {
> >>   	u32 aif_tdd : 1; /* bit 56 */
> >>   	u32 : 1;
> >>   	u32 qebsm : 1;	 /* bit 58 */
> >> -	u32 : 8;
> >> +	u32 : 2;
> >> +	u32 aiv : 1;     /* bit 61 */
> >> +	u32 : 5;
> >>   	u32 aif_osa : 1; /* bit 67 */
> >>   	u32 : 12;
> >>   	u32 eadm_rf : 1; /* bit 80 */
> >>  
> > "Expose" sounds like actually forwarding something / enabling a bit.  
> Expose here basically means to make sth. visible what was already available.
> > Wonder if this can be squashed with another patch?
> >
> > Or rename to something like "define" ...  
> I don't plan to change anything.

I'd prefer to simply squash this with the next patch, where the bit is
actually checked.

Christian Borntraeger Jan. 25, 2018, 11:42 a.m. UTC | #4

On 01/18/2018 06:54 PM, Cornelia Huck wrote:
> On Thu, 18 Jan 2018 13:02:45 +0100
> Michael Mueller <[e-mail]> wrote:
> 
>> On 17.01.18 16:19, David Hildenbrand wrote:
>>> On 16.01.2018 21:02, Christian Borntraeger wrote:  
>>>> From: Michael Mueller <[e-mail]>
>>>>
>>>> The patch exposes the Adapter Interruption Virtualization facility (AIV)
>>>> of the general channel subsystem characteristics.
>>>>
>>>> Signed-off-by: Michael Mueller <[e-mail]>
>>>> Reviewed-by: Halil Pasic <[e-mail]>
>>>> Reviewed-by: Christian Borntraeger <[e-mail]>
>>>> Signed-off-by: Christian Borntraeger <[e-mail]>
>>>> ---
>>>>   arch/s390/include/asm/css_chars.h | 4 +++-
>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
>>>> index a478eb61aaf7..fb56fa3283a2 100644
>>>> --- a/arch/s390/include/asm/css_chars.h
>>>> +++ b/arch/s390/include/asm/css_chars.h
>>>> @@ -20,7 +20,9 @@ struct css_general_char {
>>>>   	u32 aif_tdd : 1; /* bit 56 */
>>>>   	u32 : 1;
>>>>   	u32 qebsm : 1;	 /* bit 58 */
>>>> -	u32 : 8;
>>>> +	u32 : 2;
>>>> +	u32 aiv : 1;     /* bit 61 */
>>>> +	u32 : 5;
>>>>   	u32 aif_osa : 1; /* bit 67 */
>>>>   	u32 : 12;
>>>>   	u32 eadm_rf : 1; /* bit 80 */
>>>>  
>>> "Expose" sounds like actually forwarding something / enabling a bit.  
>> Expose here basically means to make sth. visible what was already available.
>>> Wonder if this can be squashed with another patch?
>>>
>>> Or rename to something like "define" ...  
>> I don't plan to change anything.
> 
> I'd prefer to simply squash this with the next patch, where the bit is
> actually checked.

Its a separate code (not KVM) so I keep it separate.
What about


s390/css: indicate the availability of the AIV facility
  
The patch adds an indication for the presence Adapter Interruption
Virtualization facility (AIV) of the general channel subsystem
characteristics.

Signed-off-by: Michael Mueller <[e-mail]>
Reviewed-by: Halil Pasic <[e-mail]>
Reviewed-by: Christian Borntraeger <[e-mail]>
Signed-off-by: Christian Borntraeger <[e-mail]>
[change wording]

Cornelia Huck Jan. 25, 2018, noon UTC | #5

On Thu, 25 Jan 2018 12:42:28 +0100
Christian Borntraeger <[e-mail]> wrote:

> On 01/18/2018 06:54 PM, Cornelia Huck wrote:
> > On Thu, 18 Jan 2018 13:02:45 +0100
> > Michael Mueller <[e-mail]> wrote:
> >   
> >> On 17.01.18 16:19, David Hildenbrand wrote:  
> >>> On 16.01.2018 21:02, Christian Borntraeger wrote:    
> >>>> From: Michael Mueller <[e-mail]>
> >>>>
> >>>> The patch exposes the Adapter Interruption Virtualization facility (AIV)
> >>>> of the general channel subsystem characteristics.
> >>>>
> >>>> Signed-off-by: Michael Mueller <[e-mail]>
> >>>> Reviewed-by: Halil Pasic <[e-mail]>
> >>>> Reviewed-by: Christian Borntraeger <[e-mail]>
> >>>> Signed-off-by: Christian Borntraeger <[e-mail]>
> >>>> ---
> >>>>   arch/s390/include/asm/css_chars.h | 4 +++-
> >>>>   1 file changed, 3 insertions(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
> >>>> index a478eb61aaf7..fb56fa3283a2 100644
> >>>> --- a/arch/s390/include/asm/css_chars.h
> >>>> +++ b/arch/s390/include/asm/css_chars.h
> >>>> @@ -20,7 +20,9 @@ struct css_general_char {
> >>>>   	u32 aif_tdd : 1; /* bit 56 */
> >>>>   	u32 : 1;
> >>>>   	u32 qebsm : 1;	 /* bit 58 */
> >>>> -	u32 : 8;
> >>>> +	u32 : 2;
> >>>> +	u32 aiv : 1;     /* bit 61 */
> >>>> +	u32 : 5;
> >>>>   	u32 aif_osa : 1; /* bit 67 */
> >>>>   	u32 : 12;
> >>>>   	u32 eadm_rf : 1; /* bit 80 */
> >>>>    
> >>> "Expose" sounds like actually forwarding something / enabling a bit.    
> >> Expose here basically means to make sth. visible what was already available.  
> >>> Wonder if this can be squashed with another patch?
> >>>
> >>> Or rename to something like "define" ...    
> >> I don't plan to change anything.  
> > 
> > I'd prefer to simply squash this with the next patch, where the bit is
> > actually checked.  
> 
> Its a separate code (not KVM) so I keep it separate.

I would just have collected an ack from the relevant maintainers, but
fair enough.

> What about
> 
> 
> s390/css: indicate the availability of the AIV facility
>   
> The patch adds an indication for the presence Adapter Interruption
> Virtualization facility (AIV) of the general channel subsystem
> characteristics.
> 
> Signed-off-by: Michael Mueller <[e-mail]>
> Reviewed-by: Halil Pasic <[e-mail]>
> Reviewed-by: Christian Borntraeger <[e-mail]>
> Signed-off-by: Christian Borntraeger <[e-mail]>
> [change wording]
> 

Also works for me.

Acked-by: Cornelia Huck <[e-mail]>

Christian Borntraeger Jan. 25, 2018, 12:04 p.m. UTC | #6

On 01/25/2018 01:00 PM, Cornelia Huck wrote:
> On Thu, 25 Jan 2018 12:42:28 +0100
> Christian Borntraeger <[e-mail]> wrote:
> 
>> On 01/18/2018 06:54 PM, Cornelia Huck wrote:
>>> On Thu, 18 Jan 2018 13:02:45 +0100
>>> Michael Mueller <[e-mail]> wrote:
>>>   
>>>> On 17.01.18 16:19, David Hildenbrand wrote:  
>>>>> On 16.01.2018 21:02, Christian Borntraeger wrote:    
>>>>>> From: Michael Mueller <[e-mail]>
>>>>>>
>>>>>> The patch exposes the Adapter Interruption Virtualization facility (AIV)
>>>>>> of the general channel subsystem characteristics.
>>>>>>
>>>>>> Signed-off-by: Michael Mueller <[e-mail]>
>>>>>> Reviewed-by: Halil Pasic <[e-mail]>
>>>>>> Reviewed-by: Christian Borntraeger <[e-mail]>
>>>>>> Signed-off-by: Christian Borntraeger <[e-mail]>
>>>>>> ---
>>>>>>   arch/s390/include/asm/css_chars.h | 4 +++-
>>>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
>>>>>> index a478eb61aaf7..fb56fa3283a2 100644
>>>>>> --- a/arch/s390/include/asm/css_chars.h
>>>>>> +++ b/arch/s390/include/asm/css_chars.h
>>>>>> @@ -20,7 +20,9 @@ struct css_general_char {
>>>>>>   	u32 aif_tdd : 1; /* bit 56 */
>>>>>>   	u32 : 1;
>>>>>>   	u32 qebsm : 1;	 /* bit 58 */
>>>>>> -	u32 : 8;
>>>>>> +	u32 : 2;
>>>>>> +	u32 aiv : 1;     /* bit 61 */
>>>>>> +	u32 : 5;
>>>>>>   	u32 aif_osa : 1; /* bit 67 */
>>>>>>   	u32 : 12;
>>>>>>   	u32 eadm_rf : 1; /* bit 80 */
>>>>>>    
>>>>> "Expose" sounds like actually forwarding something / enabling a bit.    
>>>> Expose here basically means to make sth. visible what was already available.  
>>>>> Wonder if this can be squashed with another patch?
>>>>>
>>>>> Or rename to something like "define" ...    
>>>> I don't plan to change anything.  
>>>
>>> I'd prefer to simply squash this with the next patch, where the bit is
>>> actually checked.  
>>
>> Its a separate code (not KVM) so I keep it separate.
> 
> I would just have collected an ack from the relevant maintainers, but
> fair enough.

I need that anyway and its easier if I just have this hunk.

Heiko Martin, can any of you ack

this patch ([PATCH 05/12] s390/css: expose the AIV facility)
as well as
[PATCH 03/12] s390/bitops: add test_and_clear_bit_inv()
and
[PATCH 11/12] s390/sclp: expose the GISA format facility

for handling these patches via the KVM tree.


>>
>>
>> s390/css: indicate the availability of the AIV facility
>>   
>> The patch adds an indication for the presence Adapter Interruption
>> Virtualization facility (AIV) of the general channel subsystem
>> characteristics.
>>
>> Signed-off-by: Michael Mueller <[e-mail]>
>> Reviewed-by: Halil Pasic <[e-mail]>
>> Reviewed-by: Christian Borntraeger <[e-mail]>
>> Signed-off-by: Christian Borntraeger <[e-mail]>
>> [change wording]
>>
> 
> Also works for me.
> 
> Acked-by: Cornelia Huck <[e-mail]>
Thanks.

Heiko Carstens Jan. 25, 2018, 3:13 p.m. UTC | #7

On Thu, Jan 25, 2018 at 01:04:42PM +0100, Christian Borntraeger wrote:
> >> Its a separate code (not KVM) so I keep it separate.
> > 
> > I would just have collected an ack from the relevant maintainers, but
> > fair enough.
> 
> I need that anyway and its easier if I just have this hunk.
> 
> Heiko Martin, can any of you ack
> 
> this patch ([PATCH 05/12] s390/css: expose the AIV facility)
> as well as
> [PATCH 03/12] s390/bitops: add test_and_clear_bit_inv()
> and
> [PATCH 11/12] s390/sclp: expose the GISA format facility
> 
> for handling these patches via the KVM tree.

Acked-by: Heiko Carstens <[e-mail]>

Patch

diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
index a478eb61aaf7..fb56fa3283a2 100644
--- a/arch/s390/include/asm/css_chars.h
+++ b/arch/s390/include/asm/css_chars.h
@@ -20,7 +20,9 @@  struct css_general_char {
 	u32 aif_tdd : 1; /* bit 56 */
 	u32 : 1;
 	u32 qebsm : 1;	 /* bit 58 */
-	u32 : 8;
+	u32 : 2;
+	u32 aiv : 1;     /* bit 61 */
+	u32 : 5;
 	u32 aif_osa : 1; /* bit 67 */
 	u32 : 12;
 	u32 eadm_rf : 1; /* bit 80 */