From patchwork Mon Jun 4 09:08:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tianyu Lan X-Patchwork-Id: 10446141 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9D87460284 for ; Mon, 4 Jun 2018 09:09:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FEA928947 for ; Mon, 4 Jun 2018 09:09:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 83E642896A; Mon, 4 Jun 2018 09:09:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35DFF28947 for ; Mon, 4 Jun 2018 09:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbeFDJIk (ORCPT ); Mon, 4 Jun 2018 05:08:40 -0400 Received: from mail-hk2apc01on0110.outbound.protection.outlook.com ([104.47.124.110]:6711 "EHLO APC01-HK2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752126AbeFDJIg (ORCPT ); Mon, 4 Jun 2018 05:08:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=av7xdj+sxVOWvidt3y44IWfTkkTbl0A4fKwrOWqjO6U=; b=ARelC5SEmOLkl7XpN9xQhukhQXZMNtOc9Mg6EUyEkNJwUer6vy9QadMDo95ol7lUw0mTj5g94XxY6yin78EapX8691kL/s0zob+/pJQ2xh5g2F1GWIb5Ninkwlaiz7Okifj8lB4DBKQI54IPdrAOv2GckBTwM2XXJGrfdqGK5kQ= Received: from SG2P15301MB0062.APCP153.PROD.OUTLOOK.COM (10.170.136.18) by SG2P15301MB0094.APCP153.PROD.OUTLOOK.COM (10.170.136.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.7; Mon, 4 Jun 2018 09:08:29 +0000 Received: from SG2P15301MB0062.APCP153.PROD.OUTLOOK.COM ([fe80::1cae:4bd:cf5d:6e8d]) by SG2P15301MB0062.APCP153.PROD.OUTLOOK.COM ([fe80::1cae:4bd:cf5d:6e8d%5]) with mapi id 15.20.0841.011; Mon, 4 Jun 2018 09:08:29 +0000 From: Tianyu Lan CC: Tianyu Lan , "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , KY Srinivasan , "vkuznets@redhat.com" Subject: [RFC Patch 2/3] KVM: Add tlb remote flush callback in kvm_x86_ops. Thread-Topic: [RFC Patch 2/3] KVM: Add tlb remote flush callback in kvm_x86_ops. Thread-Index: AQHT++OaghvAztGQfkKjrBIBb1LvJQ== Date: Mon, 4 Jun 2018 09:08:28 +0000 Message-ID: <20180604090749.489-3-Tianyu.Lan@microsoft.com> References: <20180604090749.489-1-Tianyu.Lan@microsoft.com> In-Reply-To: <20180604090749.489-1-Tianyu.Lan@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tianyu.Lan@microsoft.com; x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SG2P15301MB0094; 7:kl9FhTUo5/kUDulPw9SPTyJFQ2G8RNUb6n4bLwEIsEoVZucn/cWhnxEfcti/iFxrWdrjMh7933Pp/8YelVOoCHuL9gCozjmXLUUH6hxUcMe642fSstAjAVt2Nc3nvkuarHdf1IigZRSoI94W6X6Cc0C2YlSCrQKEc4JrZL7eEXfNPoWefig+Y5L3NQLMBUQDSePwF9ClkW7TJ+yMqOf6GNpbhJWxo6g4TClZ77SoKemd48RPllqdvkz1ayrqVnCI; 20:nvsUf+N5PzkTG93RdOjdbSDenE/OghbBK6BjBHKoZ3tIr32bLSETNPBTktQjX1xtKe/zwQhcVWkLz3kI8jKnPwKvo4HKVlzxMGH0B6bjTV4lfLilX1Pw/ZMaXp3kR32K2J55CeA/wkTR9Zp4dJU2Cb6nLtG3x0ze2H1hIZ4eDbk= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7193020); SRVR:SG2P15301MB0094; x-ms-traffictypediagnostic: SG2P15301MB0094: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:SG2P15301MB0094; BCL:0; PCL:0; RULEID:; SRVR:SG2P15301MB0094; x-forefront-prvs: 069373DFB6 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(396003)(39380400002)(376002)(346002)(189003)(199004)(1076002)(5250100002)(6436002)(10290500003)(2906002)(6486002)(3846002)(53936002)(6116002)(86362001)(86612001)(36756003)(25786009)(72206003)(478600001)(6512007)(10090500001)(109986005)(76176011)(106356001)(59450400001)(99286004)(68736007)(5660300001)(81166006)(81156014)(4326008)(6506007)(26005)(8936002)(8676002)(105586002)(7736002)(446003)(2616005)(11346002)(97736004)(14454004)(305945005)(2900100001)(66066001)(3660700001)(3280700002)(486006)(476003)(1671002)(22452003)(316002)(102836004)(59246006)(54906003)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2P15301MB0094; H:SG2P15301MB0062.APCP153.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: UF3sYdohWzJGDCGuKQkwnAmWOSFs8pLfIFo9rX86EvJaELDsDYcbKVG9hmce2lY724yLE4tJ5PgAIMgDAa1WqQ8b8xDS3t89Z4dodRjqeoMnOYeAZCzXUj6g74g7hfkKlYnzvpF8W6+Lwi7KGGqjwMVg95/M6e6pPQi7RtHorUScHTNiH4xmGLmkAskC9Ps5 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1f61d2cd-c07f-4a15-c575-08d5c9fabcf0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f61d2cd-c07f-4a15-c575-08d5c9fabcf0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2018 09:08:28.7008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2P15301MB0094 To: unlisted-recipients:; (no To-header on input) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is to provide a way for platforms to register tlb remote flush callback and this helps to optimize operation of tlb flush among vcpus for nested virtualization case. Signed-off-by: Lan Tianyu --- arch/x86/include/asm/kvm_host.h | 1 + virt/kvm/kvm_main.c | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 0ebe659f2802..aaad43916f9d 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -973,6 +973,7 @@ struct kvm_x86_ops { void (*set_rflags)(struct kvm_vcpu *vcpu, unsigned long rflags); void (*tlb_flush)(struct kvm_vcpu *vcpu, bool invalidate_gpa); + int (*tlb_remote_flush)(struct kvm *kvm); void (*run)(struct kvm_vcpu *vcpu); int (*handle_exit)(struct kvm_vcpu *vcpu); diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index c5f6a552e486..31e2b54c6049 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -251,11 +251,21 @@ bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req) #ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL void kvm_flush_remote_tlbs(struct kvm *kvm) { + long dirty_count; + + /* + * Call tlb_remote_flush first and go back old way when + * return failure. + */ + if (kvm_x86_ops->tlb_remote_flush && + !kvm_x86_ops->tlb_remote_flush(kvm)) + return; + /* * Read tlbs_dirty before setting KVM_REQ_TLB_FLUSH in * kvm_make_all_cpus_request. */ - long dirty_count = smp_load_acquire(&kvm->tlbs_dirty); + dirty_count = smp_load_acquire(&kvm->tlbs_dirty); /* * We want to publish modifications to the page tables before reading