| Message ID | 20180625064453.19768-1-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 25 Jun 2018 08:44:51 +0200 Gerd Hoffmann <kraxel@redhat.com> wrote: > Atomic mapping interface for dmabufs will be removed. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Fixes: f664a5269542 ("dma-buf: remove kmap_atomic interface") Though really the above commit needs to be updated to include this fix to preserve bisection since the mbochs sample driver is already upstream, suggests we only compile tested removing kmap_atomic without looking for other users. drm folks, please update. Thanks, Alex > --- > samples/vfio-mdev/mbochs.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c > index 2960e26c6e..aa25cda21d 100644 > --- a/samples/vfio-mdev/mbochs.c > +++ b/samples/vfio-mdev/mbochs.c > @@ -803,15 +803,6 @@ static void mbochs_release_dmabuf(struct dma_buf *buf) > mutex_unlock(&mdev_state->ops_lock); > } > > -static void *mbochs_kmap_atomic_dmabuf(struct dma_buf *buf, > - unsigned long page_num) > -{ > - struct mbochs_dmabuf *dmabuf = buf->priv; > - struct page *page = dmabuf->pages[page_num]; > - > - return kmap_atomic(page); > -} > - > static void *mbochs_kmap_dmabuf(struct dma_buf *buf, unsigned long page_num) > { > struct mbochs_dmabuf *dmabuf = buf->priv; > @@ -824,7 +815,6 @@ static struct dma_buf_ops mbochs_dmabuf_ops = { > .map_dma_buf = mbochs_map_dmabuf, > .unmap_dma_buf = mbochs_unmap_dmabuf, > .release = mbochs_release_dmabuf, > - .map_atomic = mbochs_kmap_atomic_dmabuf, > .map = mbochs_kmap_dmabuf, > .mmap = mbochs_mmap_dmabuf, > };
diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c index 2960e26c6e..aa25cda21d 100644 --- a/samples/vfio-mdev/mbochs.c +++ b/samples/vfio-mdev/mbochs.c @@ -803,15 +803,6 @@ static void mbochs_release_dmabuf(struct dma_buf *buf) mutex_unlock(&mdev_state->ops_lock); } -static void *mbochs_kmap_atomic_dmabuf(struct dma_buf *buf, - unsigned long page_num) -{ - struct mbochs_dmabuf *dmabuf = buf->priv; - struct page *page = dmabuf->pages[page_num]; - - return kmap_atomic(page); -} - static void *mbochs_kmap_dmabuf(struct dma_buf *buf, unsigned long page_num) { struct mbochs_dmabuf *dmabuf = buf->priv; @@ -824,7 +815,6 @@ static struct dma_buf_ops mbochs_dmabuf_ops = { .map_dma_buf = mbochs_map_dmabuf, .unmap_dma_buf = mbochs_unmap_dmabuf, .release = mbochs_release_dmabuf, - .map_atomic = mbochs_kmap_atomic_dmabuf, .map = mbochs_kmap_dmabuf, .mmap = mbochs_mmap_dmabuf, };
Atomic mapping interface for dmabufs will be removed. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- samples/vfio-mdev/mbochs.c | 10 ---------- 1 file changed, 10 deletions(-)