| Message ID | 20180718202651.19802-5-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/18/2018 01:26 PM, Sean Christopherson wrote: > KVM disables "virtualize APIC-accesses" if the APIC-access page > cannot be mapped (the feature is effectively disabled anyways if > the guest can't access the page), i.e. KVM doesn't incorrectly > signal VMFail on a legal-but-unbacked APIC-access page. > > Cc: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > x86/vmx_tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c > index 031bf66..196c00d 100644 > --- a/x86/vmx_tests.c > +++ b/x86/vmx_tests.c > @@ -3579,7 +3579,7 @@ static void test_apic_access_addr(void) > > test_vmcs_page_reference(CPU_VIRT_APIC_ACCESSES, APIC_ACCS_ADDR, > "APIC-access address", > - "virtualize APIC-accesses", true, false); > + "virtualize APIC-accesses", false, false); > } > > static bool set_bit_pattern(u8 mask, u32 *secondary) Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
On Wed, Jul 18, 2018 at 5:37 PM Krish Sadhukhan <krish.sadhukhan@oracle.com> wrote: > > > > On 07/18/2018 01:26 PM, Sean Christopherson wrote: > > KVM disables "virtualize APIC-accesses" if the APIC-access page > > cannot be mapped (the feature is effectively disabled anyways if > > the guest can't access the page), i.e. KVM doesn't incorrectly > > signal VMFail on a legal-but-unbacked APIC-access page. > > > Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com> Reviewed-by: Peter Shier <pshier@google.com>
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index 031bf66..196c00d 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -3579,7 +3579,7 @@ static void test_apic_access_addr(void) test_vmcs_page_reference(CPU_VIRT_APIC_ACCESSES, APIC_ACCS_ADDR, "APIC-access address", - "virtualize APIC-accesses", true, false); + "virtualize APIC-accesses", false, false); } static bool set_bit_pattern(u8 mask, u32 *secondary)
KVM disables "virtualize APIC-accesses" if the APIC-access page cannot be mapped (the feature is effectively disabled anyways if the guest can't access the page), i.e. KVM doesn't incorrectly signal VMFail on a legal-but-unbacked APIC-access page. Cc: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- x86/vmx_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)