From patchwork Wed Dec 5 23:29:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Mattson X-Patchwork-Id: 10715053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 162D91731 for ; Wed, 5 Dec 2018 23:29:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07CB62E0B8 for ; Wed, 5 Dec 2018 23:29:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F05032E0DF; Wed, 5 Dec 2018 23:29:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F95A2E0B8 for ; Wed, 5 Dec 2018 23:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbeLEX3Q (ORCPT ); Wed, 5 Dec 2018 18:29:16 -0500 Received: from mail-qk1-f202.google.com ([209.85.222.202]:33220 "EHLO mail-qk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727794AbeLEX3Q (ORCPT ); Wed, 5 Dec 2018 18:29:16 -0500 Received: by mail-qk1-f202.google.com with SMTP id 80so21756356qkd.0 for ; Wed, 05 Dec 2018 15:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=r5aDJDBOexkPknRaeDrpjroigSkuctKmlwLBNy1If9k=; b=I/tGu8MHrJjQOWXxtEXXhQuz/+UdU6qlQEmfbC0hDbYC3I17lm8kXDUs8bEVXV//je 0PJKO6nw+JsJ6RafGJUMU92rKX5IEhy4d6u2fAaLf/MkqWfr+9jOHsph7c0zxMU0i7vs aYUatc2HvO3cATvsODHv9faYktWi4u1+urZ6DElgiPzKipeNxi9voLmeOBudAABSlIx0 5hGTHksgcC9e5QW+C0LSRdGSMQW+ann7P+cpoXUnEXwD39ykjMCVgxNxOtx8p6qOEeDa u/w0QkX4IG5UCSo5J3HqjXtvjDq1zo5KwAoYakVq3hIQFJEiJ46wm9So7BnsTU4qZHUf 3O/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=r5aDJDBOexkPknRaeDrpjroigSkuctKmlwLBNy1If9k=; b=V2/C+UuARR8z7snziDlEzIBopNhPwnYSVksrygDWdA9jvRn6+jwH2D0Sfk6znifyuF ETSfatiZqYcx01e244Lc7gW2KEUZvY5Sp6zgKNSV6QDr6cIzJpdhTAHrg4tSqPeNoppV Wh3CwkiP+HifMFDtlxj4FVjS7yFjRdTHu6UN6XzydcCKELUtSBBOgDveKmpUleCUVmV1 jOlPGNrixSJqKuePBnCiM7Qv+mOU6K1H6+FpOtCF9JrbNjHpRKxWos2HTkVfXdlGPuHk q8vN+ErPSftDBFRSZzoty2WP7NiZwNssUyUcCUILo5xBsdCBMFc+IFDY/bwfFcMGM+ca FHWw== X-Gm-Message-State: AA+aEWbJnhw+Y8v1CnZVuNihHT1SL3FZdI8uQWy4LFwq+Djs0yi9XEOP rG0mSHHbEI2HGqQj1i7vOcLSaT13OJ8lGKqfCRDKHhTFVChcut9PNp7vgBPYBPxkNVShrZRyG13 U06jcaITCIEFi00ziVqmisWesP2xipgj88cnrXISdQ4i07zjpPXewckHAJLLnXa0= X-Google-Smtp-Source: AFSGD/Uw2h3Fm9VmR0FwrDtZJlNN4qf9MPCWgvdK+BJ2blrf+KHETcTpNxdLSEldS7rMK288dasDSdSY4zRQCg== X-Received: by 2002:a37:4cd0:: with SMTP id z199mr18765521qka.44.1544052555201; Wed, 05 Dec 2018 15:29:15 -0800 (PST) Date: Wed, 5 Dec 2018 15:29:00 -0800 In-Reply-To: <20181205232902.1431-1-jmattson@google.com> Message-Id: <20181205232902.1431-4-jmattson@google.com> Mime-Version: 1.0 References: <20181205232902.1431-1-jmattson@google.com> X-Mailer: git-send-email 2.20.0.rc1.387.gf8505762e3-goog Subject: [PATCH v4 3/5] kvm: vmx: Don't set hardware IA32_CSTAR MSR on VM-entry From: Jim Mattson To: kvm@vger.kernel.org Cc: Jim Mattson , Peter Shier Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP SYSCALL raises #UD in compatibility mode on Intel CPUs, so it's pointless to load the guest's IA32_CSTAR value into the hardware MSR. IA32_CSTAR still provides 48 bits of storage on Intel CPUs that have CPUID.80000001:EDX.LM[bit 29] set, so we cannot remove it from the vmx_msr_index[] array. Signed-off-by: Jim Mattson Reviewed-by: Peter Shier --- arch/x86/kvm/vmx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index b58c3952c5dfb..12430486e911e 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3434,9 +3434,6 @@ static void setup_msrs(struct vcpu_vmx *vmx) if (index >= 0) move_msr_up(vmx, index, save_nmsrs++); index = __find_msr_index(vmx, MSR_LSTAR); - if (index >= 0) - move_msr_up(vmx, index, save_nmsrs++); - index = __find_msr_index(vmx, MSR_CSTAR); if (index >= 0) move_msr_up(vmx, index, save_nmsrs++); /*