From patchwork Wed Jan 23 06:43:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krish Sadhukhan X-Patchwork-Id: 10776605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B78D21515 for ; Wed, 23 Jan 2019 07:08:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A783A2B5B2 for ; Wed, 23 Jan 2019 07:08:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 994C22B7F7; Wed, 23 Jan 2019 07:08:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A1222B5B2 for ; Wed, 23 Jan 2019 07:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726200AbfAWHII (ORCPT ); Wed, 23 Jan 2019 02:08:08 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:46784 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbfAWHIH (ORCPT ); Wed, 23 Jan 2019 02:08:07 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0N74ent108569; Wed, 23 Jan 2019 07:08:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=d96EoEWKknpkv+9BRL4KnWUGTMqEvHn75NLCjzGm6S4=; b=ZAELPYqnrFIduamBo96NFQ++CGZQEhDWDt7Nd2Z8H5FhlEEk3gXrCXQJMVNWmIhPCtPw uqCXc5knnFcHDUnnwdK1ikeMzbfgF3awSt0dOOPd6E2EPfVrRO8+70SUYL6NkMFJg1nf a0HOHgVRzV9oKPBTnLMqHpLh8Wv5ozIrZ6ND2HUnqp63gePWs2ScA0xOa4QgTMpV8sOv 3V0+NbsiIROe/eTywNa4OE3u2PagqNI+aOXRedNv593fg4/iyoXNLyvrLSrdAxgeUqtR Sv0Gu6I3JBQJ7bZ8gt41Gj0aMBZHz3lQg5uo6dVtntnb6kh94tRgqKN4PdbQGA/7JjRh eA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2q3vhrqv5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jan 2019 07:08:01 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0N780Sl028577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jan 2019 07:08:01 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x0N780ej028646; Wed, 23 Jan 2019 07:08:00 GMT Received: from ban25x6uut29.us.oracle.com (/10.153.73.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Jan 2019 23:08:00 -0800 From: Krish Sadhukhan To: kvm@vger.kernel.org Cc: pbonzini@redhat.com, rkrcmar@redhat.com, jmattson@google.com Subject: [kvm-unit-test nVMX] If "enable EPT" is enabled in a test, EPT pointer must also be set up Date: Wed, 23 Jan 2019 01:43:08 -0500 Message-Id: <20190123064308.6868-2-krish.sadhukhan@oracle.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190123064308.6868-1-krish.sadhukhan@oracle.com> References: <20190123064308.6868-1-krish.sadhukhan@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9144 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=965 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901230055 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit, 5b8ba41dafd7 KVM: nVMX: move vmcs12 EPTP consistency check to check_vmentry_prereqs() moved the check for EPT pointer, from nested_ept_get_cr3() to check_vmentry_prereqs(). As a result, if "enabled EPT" is set in a test but EPT pointer is not, vmentry will fail even if EPT pointer is not tested in that particular test. Signed-off-by: Krish Sadhukhan Reviewed-by: Mark Kanda --- x86/vmx_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index ee0c9ff..1e987e6 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -4682,6 +4682,7 @@ static void test_ept_eptp(void) report_prefix_pop(); secondary |= CPU_EPT; + setup_ept(false); vmcs_write(CPU_EXEC_CTRL1, secondary); report_prefix_pushf("Enable-EPT enabled, unrestricted-guest enabled"); test_vmx_controls(true, false); @@ -4737,6 +4738,7 @@ static void test_pml(void) report_prefix_pop(); secondary |= CPU_EPT; + setup_ept(false); vmcs_write(CPU_EXEC_CTRL1, secondary); report_prefix_pushf("enable-PML enabled, enable-EPT enabled"); test_vmx_controls(true, false);