[v3,06/33] KVM: VMX: Manually load RDX in vCPU-run asm blob

Message ID	20190125154120.19385-7-sean.j.christopherson@intel.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <kvm-owner@kernel.org> From: Sean Christopherson <sean.j.christopherson@intel.com> To: Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com> Cc: kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Subject: [PATCH v3 06/33] KVM: VMX: Manually load RDX in vCPU-run asm blob Date: Fri, 25 Jan 2019 07:40:53 -0800 Message-Id: <20190125154120.19385-7-sean.j.christopherson@intel.com> In-Reply-To: <20190125154120.19385-1-sean.j.christopherson@intel.com> References: <20190125154120.19385-1-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk
Series	KVM: VMX: Move vCPU-run to proper asm sub-routine \| expand [v3,00/33] KVM: VMX: Move vCPU-run to proper asm sub-routine [v3,01/33] KVM: VMX: Compare only a single byte for VMCS' "launched" in vCPU-run [v3,02/33] KVM: nVMX: Check a single byte for VMCS "launched" in nested early checks [v3,03/33] KVM: VMX: Zero out all general purpose registers after VM-Exit [v3,04/33] KVM: VMX: Modify only RSP when creating a placeholder for guest's RCX [v3,05/33] KVM: VMX: Save RSI to an unused output in the vCPU-run asm blob [v3,06/33] KVM: VMX: Manually load RDX in vCPU-run asm blob [v3,07/33] KVM: VMX: Let the compiler save/load RDX during vCPU-run [v3,08/33] KVM: nVMX: Remove a rogue "rax" clobber from nested_vmx_check_vmentry_hw() [v3,09/33] KVM: nVMX: Drop STACK_FRAME_NON_STANDARD from nested_vmx_check_vmentry_hw() [v3,10/33] KVM: nVMX: Explicitly reference the scratch reg in nested early checks [v3,11/33] KVM: nVMX: Capture VM-Fail to a local var in nested_vmx_check_vmentry_hw() [v3,12/33] KVM: nVMX: Capture VM-Fail via CC_{SET,OUT} in nested early checks [v3,13/33] KVM: nVMX: Reference vmx->loaded_vmcs->launched directly [v3,14/33] KVM: nVMX: Let the compiler select the reg for holding HOST_RSP [v3,15/33] KVM: nVMX: Cache host_rsp on a per-VMCS basis [v3,16/33] KVM: VMX: Load/save guest CR2 via C code in __vmx_vcpu_run() [v3,17/33] KVM: VMX: Update VMCS.HOST_RSP via helper C function [v3,18/33] KVM: VMX: Pass "launched" directly to the vCPU-run asm blob [v3,19/33] KVM: VMX: Invert the ordering of saving guest/host scratch reg at VM-Enter [v3,20/33] KVM: VMX: Don't save guest registers after VM-Fail [v3,21/33] KVM: VMX: Use vcpu->arch.regs directly when saving/loading guest state [v3,22/33] KVM: x86: Explicitly #define the VCPU_REGS_* indices [v3,23/33] KVM: VMX: Use #defines in place of immediates in VM-Enter inline asm [v3,24/33] KVM: VMX: Create a stack frame in vCPU-run [v3,25/33] KVM: VMX: Move vCPU-run code to a proper assembly routine [v3,26/33] KVM: VMX: Fold __vmx_vcpu_run() back into vmx_vcpu_run() [v3,27/33] KVM: VMX: Rename ____vmx_vcpu_run() to __vmx_vcpu_run() [v3,28/33] KVM: VMX: Use RAX as the scratch register during vCPU-run [v3,29/33] KVM: VMX: Pass @launched to the vCPU-run asm via standard ABI regs [v3,30/33] KVM: VMX: Return VM-Fail from vCPU-run assembly via standard ABI reg [v3,31/33] KVM: VMX: Preserve callee-save registers in vCPU-run asm sub-routine [v3,32/33] KVM: VMX: Call vCPU-run asm sub-routine from C and remove clobbering [v3,33/33] KVM: VMX: Reorder clearing of registers in the vCPU-run assembly flow

Message ID

20190125154120.19385-7-sean.j.christopherson@intel.com (mailing list archive)

State

New, archived

Headers

From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
 =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v3 06/33] KVM: VMX: Manually load RDX in vCPU-run asm blob
Date: Fri, 25 Jan 2019 07:40:53 -0800
Message-Id: <20190125154120.19385-7-sean.j.christopherson@intel.com>
In-Reply-To: <20190125154120.19385-1-sean.j.christopherson@intel.com>
References: <20190125154120.19385-1-sean.j.christopherson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: kvm-owner@vger.kernel.org
Precedence: bulk

Series

KVM: VMX: Move vCPU-run to proper asm sub-routine | expand

Commit Message

Sean Christopherson Jan. 25, 2019, 3:40 p.m. UTC

Load RDX with the VMCS.HOST_RSP field encoding on-demand instead of
delegating to the compiler via an input constraint.  In addition to
saving one whole MOV instruction, this allows RDX to be properly
clobbered (in a future patch) instead of being saved/loaded to/from
the stack.

Despite nested_vmx_check_vmentry_hw() having similar code, leave it
alone, for now.  In that case, RDX is unconditionally used and isn't
clobbered, i.e. sending in HOST_RSP as an input is simpler.

Note that because HOST_RSP is an enum and not a define, it must be
redefined as an immediate instead of using __stringify(HOST_RSP).  The
naming "conflict" between host_rsp and HOST_RSP is slightly confusing,
but the former will be removed in a future patch, at which point
HOST_RSP is absolutely what is desired.

Reviewed-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
 arch/x86/kvm/vmx/vmx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 6f3cd19cbe3a..5dcd38a74ef4 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -6389,6 +6389,7 @@  static void __vmx_vcpu_run(struct kvm_vcpu *vcpu, struct vcpu_vmx *vmx)
 		"mov %%" _ASM_SP ", (%%" _ASM_SI ") \n\t"
 		"jmp 1f \n\t"
 		"2: \n\t"
+		"mov $%c[HOST_RSP], %%" _ASM_DX " \n\t"
 		__ex("vmwrite %%" _ASM_SP ", %%" _ASM_DX) "\n\t"
 		"1: \n\t"
 		"add $%c[wordsize], %%" _ASM_SP "\n\t" /* un-adjust RSP */
@@ -6481,10 +6482,11 @@  static void __vmx_vcpu_run(struct kvm_vcpu *vcpu, struct vcpu_vmx *vmx)
 		"xor %%ebp, %%ebp \n\t"
 		"pop  %%" _ASM_BP "; pop  %%" _ASM_DX " \n\t"
 	      : ASM_CALL_CONSTRAINT, "=S"((int){0})
-	      : "c"(vmx), "d"((unsigned long)HOST_RSP), "S"(evmcs_rsp),
+	      : "c"(vmx), "S"(evmcs_rsp),
 		[launched]"i"(offsetof(struct vcpu_vmx, __launched)),
 		[fail]"i"(offsetof(struct vcpu_vmx, fail)),
 		[host_rsp]"i"(offsetof(struct vcpu_vmx, host_rsp)),
+		[HOST_RSP]"i"(HOST_RSP),
 		[rax]"i"(offsetof(struct vcpu_vmx, vcpu.arch.regs[VCPU_REGS_RAX])),
 		[rbx]"i"(offsetof(struct vcpu_vmx, vcpu.arch.regs[VCPU_REGS_RBX])),
 		[rcx]"i"(offsetof(struct vcpu_vmx, vcpu.arch.regs[VCPU_REGS_RCX])),

[v3,06/33] KVM: VMX: Manually load RDX in vCPU-run asm blob

Commit Message

Patch