| Message ID | 20190406093658.GA7438@hari-Inspiron-1545 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: x86: fix warning Using plain integer as NULL pointer | expand |
On 4/6/2019 3:06 PM, Hariprasad Kelam wrote: > Changed passing argument as "0 to NULL" which resolves below sparse warning > > arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > arch/x86/kvm/x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 099b851..39034ec 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > break; > case KVM_CAP_NESTED_STATE: > r = kvm_x86_ops->get_nested_state ? > - kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0; > + kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0; > break; > default: > break;
Nit: For future reference, wrapping the warning text with quotes in the
shortlog would be helpful. I initially read it as "fix a warning by
using a plain integer as a NULL pointer". E.g.:
KVM: x86: fix warning "Using plain integer as NULL pointer"
On Sat, Apr 06, 2019 at 03:06:58PM +0530, Hariprasad Kelam wrote:
> Changed passing argument as "0 to NULL" which resolves below sparse warning
Nit: Use imperative mood to state what the patch does, as opposed to
talking about the change in the past tense. That allows using past
tense to describe things that actually did happen in the past. E.g.:
Pass "NULL" instead of "0" for a pointer argument when querying
KVM_CAP_NESTED_STATE to resolve the below sparse warning:
>
> arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Thanks for the fix!
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> arch/x86/kvm/x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 099b851..39034ec 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> case KVM_CAP_NESTED_STATE:
> r = kvm_x86_ops->get_nested_state ?
> - kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0;
> + kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0;
> break;
> default:
> break;
> --
> 2.7.4
>
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 099b851..39034ec 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3093,7 +3093,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) break; case KVM_CAP_NESTED_STATE: r = kvm_x86_ops->get_nested_state ? - kvm_x86_ops->get_nested_state(NULL, 0, 0) : 0; + kvm_x86_ops->get_nested_state(NULL, NULL, 0) : 0; break; default: break;
Changed passing argument as "0 to NULL" which resolves below sparse warning arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)