From patchwork Thu May 9 20:05:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nadav Amit X-Patchwork-Id: 10938173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BFB1A1398 for ; Fri, 10 May 2019 03:26:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B02ED28C02 for ; Fri, 10 May 2019 03:26:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A502E28C09; Fri, 10 May 2019 03:26:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F51428C02 for ; Fri, 10 May 2019 03:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbfEJD0M (ORCPT ); Thu, 9 May 2019 23:26:12 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46456 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbfEJD0M (ORCPT ); Thu, 9 May 2019 23:26:12 -0400 Received: by mail-pf1-f196.google.com with SMTP id y11so2393637pfm.13 for ; Thu, 09 May 2019 20:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tl7VjzHdgtJTQ15zG/VNPKyp4z4cERyhkkjo6X/eOYs=; b=sCzF6jmJ8Vi+ecAUksZR948sBlZlHTmqTK2syYl4+wPW+Q0RyRNSnMGpWZkqL2RtZS k5RFOeapXVURDI2KVPzOnX8V8xUg2tEuv8xgV0m1yhYvWnnQfUVSdAJUYenbfG0zlq8d hF8C9sv6ZdAsFPgX0aPrH469mbsPVXp0SFuhoYrMqNhvlbPRhpQDcEYljdL81c/t/a9E rXkFvrEahrrA3aVt84EVdxbLmyyKRJQT5u20W14KQHvKBmJff+p8HC47sV0hMmhBqq6u Mpgn5xH1dcSpq6GB4uU3M4+yNYl7vjN5f/VFSAOSg2dFI3mvXQTYQaeVME5hTnTBeJVc 6DqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tl7VjzHdgtJTQ15zG/VNPKyp4z4cERyhkkjo6X/eOYs=; b=b34YMMHzWIfqpoPhjCK964SF3pOgr1kIXnL+BRZ2nQ/ue/F44j07plLYb27axPOUjM ZD6m9u5hC+2+Xc8mMZRjxOZSbv7eENKVLOE5moCVNS71D6U3sWLNjhQC/7UPvubbD5iJ aZqGGUiVWxulfBwpAu9mTdT8RW/rD9VI7cbAaDanMp7WPQbtDY9oA3xECwLTU/6B2kNb 1UoE7+wMWr9ZouazFsLpS1V4V55YSN83x5+LnLKM9GuPKX4cdU06gjjAdUA8dwzKR1IA TTs+h9jEFJn41OLBv0m5/qdRlQ1Rq3MNG9ihM8xa/7ji0Xvm0iLzqYp3jjSpGiO4VkMO vDLw== X-Gm-Message-State: APjAAAXilZS/hwzUVv3iR7Orh0tz+2M7nEAPV3KgoV6+t64CtSCm7Go9 cqdbOq/DNwhbWsWYA1DRwt4= X-Google-Smtp-Source: APXvYqzx6NoI1ZVWKBueAT9NzcVcWFE1CuKa1zz62WOp+tiwzPDeeRiW3nxP8rKWvchcLlNasTZUqQ== X-Received: by 2002:a62:7793:: with SMTP id s141mr10742057pfc.21.1557458771341; Thu, 09 May 2019 20:26:11 -0700 (PDT) Received: from sc2-haas01-esx0118.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id z66sm5225592pfz.83.2019.05.09.20.26.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 20:26:09 -0700 (PDT) From: Nadav Amit To: Paolo Bonzini Cc: kvm@vger.kernel.org, Krish Sadhukhan , Andrew Jones , Alexandru Elisei , Nadav Amit Subject: [kvm-unit-tests PATCH v3 3/4] lib: Remove redundant page zeroing Date: Thu, 9 May 2019 13:05:57 -0700 Message-Id: <20190509200558.12347-4-nadav.amit@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190509200558.12347-1-nadav.amit@gmail.com> References: <20190509200558.12347-1-nadav.amit@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now that alloc_page() zeros the page, remove the redundant page zeroing. Reviewed-by: Krish Sadhukhan Suggested-by: Andrew Jones Signed-off-by: Nadav Amit Reviewed-by: Andrew Jones --- lib/virtio-mmio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/virtio-mmio.c b/lib/virtio-mmio.c index 57fe78e..e5e8f66 100644 --- a/lib/virtio-mmio.c +++ b/lib/virtio-mmio.c @@ -56,7 +56,6 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, vq = calloc(1, sizeof(*vq)); assert(VIRTIO_MMIO_QUEUE_SIZE_MIN <= 2*PAGE_SIZE); queue = alloc_pages(1); - memset(queue, 0, 2*PAGE_SIZE); assert(vq && queue); writel(index, vm_dev->base + VIRTIO_MMIO_QUEUE_SEL);