| Message ID | 20190808141255.45236-3-parav@mellanox.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Simplify mtty driver and mdev core | expand |
On Thu, Aug 08, 2019 at 09:12:55AM -0500, Parav Pandit wrote: > There is no single production driver who is interested in mdev device > uuid. Currently UUID is mainly used to derive a device name. > Additionally mdev device name is already available using core kernel > API dev_name(). > > Hence removed unused exported symbol. > > Reviewed-by: Cornelia Huck <cohuck@redhat.com> > Signed-off-by: Parav Pandit <parav@mellanox.com> Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On Thu, 8 Aug 2019 09:12:55 -0500 Parav Pandit <parav@mellanox.com> wrote: > There is no single production driver who is interested in mdev device > uuid. Currently UUID is mainly used to derive a device name. > Additionally mdev device name is already available using core kernel > API dev_name(). > > Hence removed unused exported symbol. FWIW, I just sent https://lore.kernel.org/kvm/20190816151505.9853-1-cohuck@redhat.com/, for which dev_name() is not an option. > > Reviewed-by: Cornelia Huck <cohuck@redhat.com> > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > Changelog: > v0->v1: > - Updated commit log to address comments from Cornelia > --- > drivers/vfio/mdev/mdev_core.c | 6 ------ > include/linux/mdev.h | 1 - > 2 files changed, 7 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b558d4cfd082..c2b809cbe59f 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -57,12 +57,6 @@ struct mdev_device *mdev_from_dev(struct device *dev) > } > EXPORT_SYMBOL(mdev_from_dev); > > -const guid_t *mdev_uuid(struct mdev_device *mdev) > -{ > - return &mdev->uuid; > -} > -EXPORT_SYMBOL(mdev_uuid); > - > /* Should be called holding parent_list_lock */ > static struct mdev_parent *__find_parent_device(struct device *dev) > { > diff --git a/include/linux/mdev.h b/include/linux/mdev.h > index 0ce30ca78db0..375a5830c3d8 100644 > --- a/include/linux/mdev.h > +++ b/include/linux/mdev.h > @@ -131,7 +131,6 @@ struct mdev_driver { > > void *mdev_get_drvdata(struct mdev_device *mdev); > void mdev_set_drvdata(struct mdev_device *mdev, void *data); > -const guid_t *mdev_uuid(struct mdev_device *mdev); > > extern struct bus_type mdev_bus_type; >
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c index b558d4cfd082..c2b809cbe59f 100644 --- a/drivers/vfio/mdev/mdev_core.c +++ b/drivers/vfio/mdev/mdev_core.c @@ -57,12 +57,6 @@ struct mdev_device *mdev_from_dev(struct device *dev) } EXPORT_SYMBOL(mdev_from_dev); -const guid_t *mdev_uuid(struct mdev_device *mdev) -{ - return &mdev->uuid; -} -EXPORT_SYMBOL(mdev_uuid); - /* Should be called holding parent_list_lock */ static struct mdev_parent *__find_parent_device(struct device *dev) { diff --git a/include/linux/mdev.h b/include/linux/mdev.h index 0ce30ca78db0..375a5830c3d8 100644 --- a/include/linux/mdev.h +++ b/include/linux/mdev.h @@ -131,7 +131,6 @@ struct mdev_driver { void *mdev_get_drvdata(struct mdev_device *mdev); void mdev_set_drvdata(struct mdev_device *mdev, void *data); -const guid_t *mdev_uuid(struct mdev_device *mdev); extern struct bus_type mdev_bus_type;