| Message ID | 20190927104227.253466-4-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm: Use stable test output lines | expand |
On Fri, Sep 27, 2019 at 11:42:24AM +0100, Andre Przywara wrote: > For some tests we mix variable diagnostic output with the test name, > which leads to variable test line, confusing some higher level > frameworks. > > Split the output to always use the same test name for a certain test, > and put diagnostic output on a separate line using the INFO: tag. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arm/timer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arm/timer.c b/arm/timer.c > index f2f6019..0b808d5 100644 > --- a/arm/timer.c > +++ b/arm/timer.c > @@ -249,7 +249,8 @@ static void test_timer(struct timer_info *info) > local_irq_enable(); > left = info->read_tval(); > report("interrupt received after TVAL/WFI", info->irq_received); > - report("timer has expired (%d)", left < 0, left); > + report("timer has expired", left < 0); > + report_info("TVAL is %d ticks", left); > } > > static void test_vtimer(void) > -- > 2.17.1 > Reviewed-by: Andrew Jones <drjones@redhat.com>
diff --git a/arm/timer.c b/arm/timer.c index f2f6019..0b808d5 100644 --- a/arm/timer.c +++ b/arm/timer.c @@ -249,7 +249,8 @@ static void test_timer(struct timer_info *info) local_irq_enable(); left = info->read_tval(); report("interrupt received after TVAL/WFI", info->irq_received); - report("timer has expired (%d)", left < 0, left); + report("timer has expired", left < 0); + report_info("TVAL is %d ticks", left); } static void test_vtimer(void)
For some tests we mix variable diagnostic output with the test name, which leads to variable test line, confusing some higher level frameworks. Split the output to always use the same test name for a certain test, and put diagnostic output on a separate line using the INFO: tag. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arm/timer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)