| Message ID | 20190927104227.253466-7-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm: Use stable test output lines | expand |
On Fri, Sep 27, 2019 at 11:42:27AM +0100, Andre Przywara wrote: > When running the unit tests in TAP mode (./run_tests.sh -t), every single > test result is printed. This works fine for most tests which use the > reporting prefix feature to indicate the actual test name. > However psci and pci were missing those names, so the reporting left > people scratching their head what was actually tested: > ... > ok 74 - invalid-function > ok 75 - affinity-info-on > ok 76 - affinity-info-off > ok 77 - cpu-on > > Push a "psci" prefix before running those tests to make those report > lines more descriptive. > While at it, do the same for pci, even though it is less ambigious there. > Also the GIC ITARGETSR test was missing a report_prefix_pop(). > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arm/gic.c | 2 ++ > arm/pci-test.c | 2 ++ > arm/psci.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/arm/gic.c b/arm/gic.c > index 66dcafe..ebb6ea2 100644 > --- a/arm/gic.c > +++ b/arm/gic.c > @@ -480,6 +480,8 @@ static void test_targets(int nr_irqs) > test_byte_access(targetsptr + GIC_FIRST_SPI, pattern, cpu_mask); > > writel(orig_targets, targetsptr + GIC_FIRST_SPI); > + > + report_prefix_pop(); > } > > static void gic_test_mmio(void) > diff --git a/arm/pci-test.c b/arm/pci-test.c > index cf128ac..7c3836e 100644 > --- a/arm/pci-test.c > +++ b/arm/pci-test.c > @@ -19,6 +19,8 @@ int main(void) > return report_summary(); > } > > + report_prefix_push("pci"); > + > pci_print(); > > ret = pci_testdev(); > diff --git a/arm/psci.c b/arm/psci.c > index 5cb4d5c..536c9b7 100644 > --- a/arm/psci.c > +++ b/arm/psci.c > @@ -126,6 +126,8 @@ int main(void) > { > int ver = psci_invoke(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); > > + report_prefix_push("psci"); > + > if (nr_cpus < 2) { > report_skip("At least 2 cpus required"); > goto done; > -- > 2.17.1 > Reviewed-by: Andrew Jones <drjones@redhat.com>
diff --git a/arm/gic.c b/arm/gic.c index 66dcafe..ebb6ea2 100644 --- a/arm/gic.c +++ b/arm/gic.c @@ -480,6 +480,8 @@ static void test_targets(int nr_irqs) test_byte_access(targetsptr + GIC_FIRST_SPI, pattern, cpu_mask); writel(orig_targets, targetsptr + GIC_FIRST_SPI); + + report_prefix_pop(); } static void gic_test_mmio(void) diff --git a/arm/pci-test.c b/arm/pci-test.c index cf128ac..7c3836e 100644 --- a/arm/pci-test.c +++ b/arm/pci-test.c @@ -19,6 +19,8 @@ int main(void) return report_summary(); } + report_prefix_push("pci"); + pci_print(); ret = pci_testdev(); diff --git a/arm/psci.c b/arm/psci.c index 5cb4d5c..536c9b7 100644 --- a/arm/psci.c +++ b/arm/psci.c @@ -126,6 +126,8 @@ int main(void) { int ver = psci_invoke(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); + report_prefix_push("psci"); + if (nr_cpus < 2) { report_skip("At least 2 cpus required"); goto done;
When running the unit tests in TAP mode (./run_tests.sh -t), every single test result is printed. This works fine for most tests which use the reporting prefix feature to indicate the actual test name. However psci and pci were missing those names, so the reporting left people scratching their head what was actually tested: ... ok 74 - invalid-function ok 75 - affinity-info-on ok 76 - affinity-info-off ok 77 - cpu-on Push a "psci" prefix before running those tests to make those report lines more descriptive. While at it, do the same for pci, even though it is less ambigious there. Also the GIC ITARGETSR test was missing a report_prefix_pop(). Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arm/gic.c | 2 ++ arm/pci-test.c | 2 ++ arm/psci.c | 2 ++ 3 files changed, 6 insertions(+)