| Message ID | 20191024114059.102802-9-frankja@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: s390: Add support for protected VMs | expand |
On 24.10.19 13:40, Janosch Frank wrote: > From: Claudio Imbrenda <imbrenda@linux.ibm.com> > > gmap.h references radix trees, but does not include linux/radix-tree.h > itself. Sources that include gmap.h but not also radix-tree.h will > therefore fail to compile. > > This simple patch adds the include for linux/radix-tree.h in gmap.h so > that users of gmap.h will be able to compile. > > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > arch/s390/include/asm/gmap.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/s390/include/asm/gmap.h b/arch/s390/include/asm/gmap.h > index eab6a2ec3599..99b3eedda26e 100644 > --- a/arch/s390/include/asm/gmap.h > +++ b/arch/s390/include/asm/gmap.h > @@ -10,6 +10,7 @@ > #define _ASM_S390_GMAP_H > > #include <linux/refcount.h> > +#include <linux/radix-tree.h> > > /* Generic bits for GMAP notification on DAT table entry changes. */ > #define GMAP_NOTIFY_SHADOW 0x2 > Not sure if that's worth a separate patch, just squash it into the patch that needs it? We usually don't care about includes as long as it compiles ...
On 24/10/2019 13.40, Janosch Frank wrote: > From: Claudio Imbrenda <imbrenda@linux.ibm.com> > > gmap.h references radix trees, but does not include linux/radix-tree.h > itself. Sources that include gmap.h but not also radix-tree.h will > therefore fail to compile. > > This simple patch adds the include for linux/radix-tree.h in gmap.h so > that users of gmap.h will be able to compile. > > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > arch/s390/include/asm/gmap.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/s390/include/asm/gmap.h b/arch/s390/include/asm/gmap.h > index eab6a2ec3599..99b3eedda26e 100644 > --- a/arch/s390/include/asm/gmap.h > +++ b/arch/s390/include/asm/gmap.h > @@ -10,6 +10,7 @@ > #define _ASM_S390_GMAP_H > > #include <linux/refcount.h> > +#include <linux/radix-tree.h> > > /* Generic bits for GMAP notification on DAT table entry changes. */ > #define GMAP_NOTIFY_SHADOW 0x2 > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/arch/s390/include/asm/gmap.h b/arch/s390/include/asm/gmap.h index eab6a2ec3599..99b3eedda26e 100644 --- a/arch/s390/include/asm/gmap.h +++ b/arch/s390/include/asm/gmap.h @@ -10,6 +10,7 @@ #define _ASM_S390_GMAP_H #include <linux/refcount.h> +#include <linux/radix-tree.h> /* Generic bits for GMAP notification on DAT table entry changes. */ #define GMAP_NOTIFY_SHADOW 0x2