| Message ID | 20200121134254.4570-8-frankja@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: smp: Improve smp code and reset checks | expand |
On Tue, 21 Jan 2020 08:42:52 -0500 Janosch Frank <frankja@linux.ibm.com> wrote: > Now that we have a loop which is executed after we return from the > main function of a secondary cpu, we can remove the surplus loops. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > s390x/smp.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On 21.01.20 14:42, Janosch Frank wrote: > Now that we have a loop which is executed after we return from the > main function of a secondary cpu, we can remove the surplus loops. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > s390x/smp.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/s390x/smp.c b/s390x/smp.c > index 3e8cf3e..45f1d80 100644 > --- a/s390x/smp.c > +++ b/s390x/smp.c > @@ -35,15 +35,9 @@ static void set_flag(int val) > mb(); > } > > -static void cpu_loop(void) > -{ > - for (;;) {} > -} > - > static void test_func(void) > { > set_flag(1); > - cpu_loop(); > } > > static void test_start(void) > @@ -241,7 +235,7 @@ int main(void) > > /* Setting up the cpu to give it a stack and lowcore */ > psw.mask = extract_psw_mask(); > - psw.addr = (unsigned long)cpu_loop; > + psw.addr = (unsigned long)test_func; > smp_cpu_setup(1, psw); > smp_cpu_stop(1); > > Acked-by: David Hildenbrand <david@redhat.com>
diff --git a/s390x/smp.c b/s390x/smp.c index 3e8cf3e..45f1d80 100644 --- a/s390x/smp.c +++ b/s390x/smp.c @@ -35,15 +35,9 @@ static void set_flag(int val) mb(); } -static void cpu_loop(void) -{ - for (;;) {} -} - static void test_func(void) { set_flag(1); - cpu_loop(); } static void test_start(void) @@ -241,7 +235,7 @@ int main(void) /* Setting up the cpu to give it a stack and lowcore */ psw.mask = extract_psw_mask(); - psw.addr = (unsigned long)cpu_loop; + psw.addr = (unsigned long)test_func; smp_cpu_setup(1, psw); smp_cpu_stop(1);
Now that we have a loop which is executed after we return from the main function of a secondary cpu, we can remove the surplus loops. Signed-off-by: Janosch Frank <frankja@linux.ibm.com> --- s390x/smp.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)