diff mbox series

KVM: x86: Unexport x86_fpu_cache and make it static

Message ID 20200127001330.27741-1-sean.j.christopherson@intel.com (mailing list archive)
State New, archived
Headers show
Series KVM: x86: Unexport x86_fpu_cache and make it static | expand

Commit Message

Sean Christopherson Jan. 27, 2020, 12:13 a.m. UTC
Make x86_fpu_cache static now that FPU allocation and destruction is
handled entirely by common x86 code.

Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---

Pretty sure I meant to include this in the vCPU creation cleanup, but
completely forgot about it.

 arch/x86/include/asm/kvm_host.h | 1 -
 arch/x86/kvm/x86.c              | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Vitaly Kuznetsov Jan. 27, 2020, 8:58 a.m. UTC | #1
Sean Christopherson <sean.j.christopherson@intel.com> writes:

> Make x86_fpu_cache static now that FPU allocation and destruction is
> handled entirely by common x86 code.
>

git grep on kvm/next agrees :-)

> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

> ---
>
> Pretty sure I meant to include this in the vCPU creation cleanup, but
> completely forgot about it.
>
>  arch/x86/include/asm/kvm_host.h | 1 -
>  arch/x86/kvm/x86.c              | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 77d206a93658..f300a250ab51 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1266,7 +1266,6 @@ struct kvm_arch_async_pf {
>  };
>  
>  extern struct kvm_x86_ops *kvm_x86_ops;
> -extern struct kmem_cache *x86_fpu_cache;
>  
>  #define __KVM_HAVE_ARCH_VM_ALLOC
>  static inline struct kvm *kvm_arch_alloc_vm(void)
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 7e3f1d937224..78b7e1f08845 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -227,8 +227,7 @@ struct kvm_stats_debugfs_item debugfs_entries[] = {
>  
>  u64 __read_mostly host_xcr0;
>  
> -struct kmem_cache *x86_fpu_cache;
> -EXPORT_SYMBOL_GPL(x86_fpu_cache);
> +static struct kmem_cache *x86_fpu_cache;
>  
>  static int emulator_fix_hypercall(struct x86_emulate_ctxt *ctxt);
diff mbox series

Patch

diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 77d206a93658..f300a250ab51 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -1266,7 +1266,6 @@  struct kvm_arch_async_pf {
 };
 
 extern struct kvm_x86_ops *kvm_x86_ops;
-extern struct kmem_cache *x86_fpu_cache;
 
 #define __KVM_HAVE_ARCH_VM_ALLOC
 static inline struct kvm *kvm_arch_alloc_vm(void)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 7e3f1d937224..78b7e1f08845 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -227,8 +227,7 @@  struct kvm_stats_debugfs_item debugfs_entries[] = {
 
 u64 __read_mostly host_xcr0;
 
-struct kmem_cache *x86_fpu_cache;
-EXPORT_SYMBOL_GPL(x86_fpu_cache);
+static struct kmem_cache *x86_fpu_cache;
 
 static int emulator_fix_hypercall(struct x86_emulate_ctxt *ctxt);