| Message ID | 20200406151641.67698-1-ubizjak@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: VMX: Remove unnecessary exception trampoline in vmx_vmenter | expand |
On Mon, Apr 06, 2020 at 05:16:41PM +0200, Uros Bizjak wrote: > The exception trampoline in .fixup section is not needed, the exception handling code can jump directly to the label in .text section. Changelog need to be wrapped at 75 chars, and "label in .text section" should be "label in the .text section". Nits aside, Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com> > Cc: Sean Christopherson <sean.j.christopherson@intel.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Uros Bizjak <ubizjak@gmail.com> > --- > arch/x86/kvm/vmx/vmenter.S | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S > index 81ada2ce99e7..56d701db8734 100644 > --- a/arch/x86/kvm/vmx/vmenter.S > +++ b/arch/x86/kvm/vmx/vmenter.S > @@ -58,12 +58,8 @@ SYM_FUNC_START(vmx_vmenter) > ret > 4: ud2 > > - .pushsection .fixup, "ax" > -5: jmp 3b > - .popsection > - > - _ASM_EXTABLE(1b, 5b) > - _ASM_EXTABLE(2b, 5b) > + _ASM_EXTABLE(1b, 3b) > + _ASM_EXTABLE(2b, 3b) > > SYM_FUNC_END(vmx_vmenter) > > -- > 2.25.1 >
diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S index 81ada2ce99e7..56d701db8734 100644 --- a/arch/x86/kvm/vmx/vmenter.S +++ b/arch/x86/kvm/vmx/vmenter.S @@ -58,12 +58,8 @@ SYM_FUNC_START(vmx_vmenter) ret 4: ud2 - .pushsection .fixup, "ax" -5: jmp 3b - .popsection - - _ASM_EXTABLE(1b, 5b) - _ASM_EXTABLE(2b, 5b) + _ASM_EXTABLE(1b, 3b) + _ASM_EXTABLE(2b, 3b) SYM_FUNC_END(vmx_vmenter)
The exception trampoline in .fixup section is not needed, the exception handling code can jump directly to the label in .text section. Cc: Sean Christopherson <sean.j.christopherson@intel.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Uros Bizjak <ubizjak@gmail.com> --- arch/x86/kvm/vmx/vmenter.S | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)