| Message ID | 20200617034123.25647-1-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: VMX: Remove vcpu_vmx's defunct copy of host_pkru | expand |
Sean Christopherson <sean.j.christopherson@intel.com> writes: > Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was > moved to common x86 code. > > No functional change intended. > > Fixes: 37486135d3a7b ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c") > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > arch/x86/kvm/vmx/vmx.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > index 8a83b5edc820..639798e4a6ca 100644 > --- a/arch/x86/kvm/vmx/vmx.h > +++ b/arch/x86/kvm/vmx/vmx.h > @@ -288,8 +288,6 @@ struct vcpu_vmx { > > u64 current_tsc_ratio; > > - u32 host_pkru; > - > unsigned long host_debugctlmsr; > > /* (Is there a better [automated] way to figure out whether the particular field is being used or not than just dropping it and trying to compile the whole thing? Leaving #define-s, configs,... aside ...) Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
On Wed, Jun 17, 2020 at 2:19 AM Vitaly Kuznetsov <vkuznets@redhat.com> wrote: > > Sean Christopherson <sean.j.christopherson@intel.com> writes: > > > Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was > > moved to common x86 code. > > > > No functional change intended. > > > > Fixes: 37486135d3a7b ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c") > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > > --- > > arch/x86/kvm/vmx/vmx.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > > index 8a83b5edc820..639798e4a6ca 100644 > > --- a/arch/x86/kvm/vmx/vmx.h > > +++ b/arch/x86/kvm/vmx/vmx.h > > @@ -288,8 +288,6 @@ struct vcpu_vmx { > > > > u64 current_tsc_ratio; > > > > - u32 host_pkru; > > - > > unsigned long host_debugctlmsr; > > > > /* > > (Is there a better [automated] way to figure out whether the particular > field is being used or not than just dropping it and trying to compile > the whole thing? Leaving #define-s, configs,... aside ...) > > Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com> Reviewed-by: Jim Mattson <jmattson@google.com>
On 17/06/20 05:41, Sean Christopherson wrote: > Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was > moved to common x86 code. > > No functional change intended. > > Fixes: 37486135d3a7b ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c") > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > arch/x86/kvm/vmx/vmx.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > index 8a83b5edc820..639798e4a6ca 100644 > --- a/arch/x86/kvm/vmx/vmx.h > +++ b/arch/x86/kvm/vmx/vmx.h > @@ -288,8 +288,6 @@ struct vcpu_vmx { > > u64 current_tsc_ratio; > > - u32 host_pkru; > - > unsigned long host_debugctlmsr; > > /* > Queued, thanks. Paolo
diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h index 8a83b5edc820..639798e4a6ca 100644 --- a/arch/x86/kvm/vmx/vmx.h +++ b/arch/x86/kvm/vmx/vmx.h @@ -288,8 +288,6 @@ struct vcpu_vmx { u64 current_tsc_ratio; - u32 host_pkru; - unsigned long host_debugctlmsr; /*
Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was moved to common x86 code. No functional change intended. Fixes: 37486135d3a7b ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c") Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- arch/x86/kvm/vmx/vmx.h | 2 -- 1 file changed, 2 deletions(-)