| Message ID | 20200714041905.12848-1-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests] cstart: Fix typo in i386's cstart assembly | expand |
> On Jul 13, 2020, at 9:19 PM, Sean Christopherson <sean.j.christopherson@intel.com> wrote: > > Replace a '%' with a '$' to encode a literal in when initializing CR4. > This fixes the build on i386 as gcc complains about a non-existent > register. Reviewed-by: Nadav Amit <namit@vmware.com> ( I should have noticed it before )
On Mon, 13 Jul 2020 21:19:05 -0700 Sean Christopherson <sean.j.christopherson@intel.com> wrote: > Replace a '%' with a '$' to encode a literal in when initializing CR4. > This fixes the build on i386 as gcc complains about a non-existent > register. > > x86/cstart.S: Assembler messages: > x86/cstart.S:128: Error: bad register name `%(1<<4)' > Makefile:101: recipe for target 'x86/cstart.o' failed > > Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero") > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > x86/cstart.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/cstart.S b/x86/cstart.S > index e63e4e2..c0efc5f 100644 > --- a/x86/cstart.S > +++ b/x86/cstart.S > @@ -125,7 +125,7 @@ start: > jmpl $8, $start32 > > prepare_32: > - mov %(1 << 4), %eax // pse > + mov $(1 << 4), %eax // pse > mov %eax, %cr4 > > mov $pt, %eax
diff --git a/x86/cstart.S b/x86/cstart.S index e63e4e2..c0efc5f 100644 --- a/x86/cstart.S +++ b/x86/cstart.S @@ -125,7 +125,7 @@ start: jmpl $8, $start32 prepare_32: - mov %(1 << 4), %eax // pse + mov $(1 << 4), %eax // pse mov %eax, %cr4 mov $pt, %eax
Replace a '%' with a '$' to encode a literal in when initializing CR4. This fixes the build on i386 as gcc complains about a non-existent register. x86/cstart.S: Assembler messages: x86/cstart.S:128: Error: bad register name `%(1<<4)' Makefile:101: recipe for target 'x86/cstart.o' failed Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero") Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- x86/cstart.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)