diff mbox series

x86/kvm: hide KVM options from menuconfig when KVM is not compiled

Message ID 20201001112014.9561-1-mcroce@linux.microsoft.com (mailing list archive)
State New, archived
Headers show
Series x86/kvm: hide KVM options from menuconfig when KVM is not compiled | expand

Commit Message

Matteo Croce Oct. 1, 2020, 11:20 a.m. UTC 
From: Matteo Croce <mcroce@microsoft.com>

Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.

Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
 arch/x86/kvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Vitaly Kuznetsov Oct. 1, 2020, 2 p.m. UTC | #1 
Matteo Croce <mcroce@linux.microsoft.com> writes:

> From: Matteo Croce <mcroce@microsoft.com>
>
> Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
>
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>

I'd even say

Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")

> ---
>  arch/x86/kvm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index fbd5bd7a945a..f92dfd8ef10d 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -66,6 +66,7 @@ config KVM_WERROR
>  	default y if X86_64 && !KASAN
>  	# We use the dependency on !COMPILE_TEST to not be enabled
>  	# blindly in allmodconfig or allyesconfig configurations
> +	depends on KVM
>  	depends on (X86_64 && !KASAN) || !COMPILE_TEST
>  	depends on EXPERT
>  	help

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Matteo Croce Oct. 1, 2020, 2:19 p.m. UTC | #2 
On Thu, Oct 1, 2020 at 4:01 PM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> Matteo Croce <mcroce@linux.microsoft.com> writes:
>
> > From: Matteo Croce <mcroce@microsoft.com>
> >
> > Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
> >
> > Signed-off-by: Matteo Croce <mcroce@microsoft.com>
>
> I'd even say
>
> Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")
>

Indeed, thanks

> > ---
> >  arch/x86/kvm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index fbd5bd7a945a..f92dfd8ef10d 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -66,6 +66,7 @@ config KVM_WERROR
> >       default y if X86_64 && !KASAN
> >       # We use the dependency on !COMPILE_TEST to not be enabled
> >       # blindly in allmodconfig or allyesconfig configurations
> > +     depends on KVM
> >       depends on (X86_64 && !KASAN) || !COMPILE_TEST
> >       depends on EXPERT
> >       help
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> --
> Vitaly
>
Paolo Bonzini Oct. 19, 2020, 3:17 p.m. UTC | #3 
On 01/10/20 13:20, Matteo Croce wrote:
> From: Matteo Croce <mcroce@microsoft.com>
> 
> Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
> 
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
>  arch/x86/kvm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index fbd5bd7a945a..f92dfd8ef10d 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -66,6 +66,7 @@ config KVM_WERROR
>  	default y if X86_64 && !KASAN
>  	# We use the dependency on !COMPILE_TEST to not be enabled
>  	# blindly in allmodconfig or allyesconfig configurations
> +	depends on KVM
>  	depends on (X86_64 && !KASAN) || !COMPILE_TEST
>  	depends on EXPERT
>  	help
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index fbd5bd7a945a..f92dfd8ef10d 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -66,6 +66,7 @@  config KVM_WERROR
 	default y if X86_64 && !KASAN
 	# We use the dependency on !COMPILE_TEST to not be enabled
 	# blindly in allmodconfig or allyesconfig configurations
+	depends on KVM
 	depends on (X86_64 && !KASAN) || !COMPILE_TEST
 	depends on EXPERT
 	help