diff mbox series

[v2,5/9] KVM: arm: move has_run_once after the map_resources

Message ID 20210114103708.26763-6-eric.auger@redhat.com (mailing list archive)
State New, archived
Headers show
Series KVM/ARM: Some vgic fixes and init sequence KVM selftests | expand

Commit Message

Auger Eric Jan. 14, 2021, 10:37 a.m. UTC
has_run_once is set to true at the beginning of
kvm_vcpu_first_run_init(). This generally is not an issue
except when exercising the code with KVM selftests. for instance,
if kvm_vgic_map_resources() fails due to erroneous user settings,
has_run_once is set and this prevents from continuing
executing the test. This patch moves the assignment after the

Signed-off-by: Eric Auger <eric.auger@redhat.com>


v1 -> v2:
- slight reword of the commit msg (for instance)
 arch/arm64/kvm/arm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 04c44853b103..580760e58980 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -573,8 +573,6 @@  static int kvm_vcpu_first_run_init(struct kvm_vcpu *vcpu)
 	if (!kvm_arm_vcpu_is_finalized(vcpu))
 		return -EPERM;
-	vcpu->arch.has_run_once = true;
 	if (likely(irqchip_in_kernel(kvm))) {
 		 * Map the VGIC hardware resources before running a vcpu the
@@ -591,6 +589,8 @@  static int kvm_vcpu_first_run_init(struct kvm_vcpu *vcpu)
+	vcpu->arch.has_run_once = true;
 	ret = kvm_timer_enable(vcpu);
 	if (ret)
 		return ret;