| Message ID | 20210204172230.85853-4-sgarzare@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vdpa: add vdpa simulator for block device | expand |
On 2021/2/5 上午1:22, Stefano Garzarella wrote: > __vringh_iov() overwrites the contents of riov and wiov, in fact it > resets the 'i' and 'used' fields, but also the 'consumed' field should > be reset to avoid an inconsistent state. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > drivers/vhost/vringh.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Jason Wang <jasowang@redhat.com> > > diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c > index f68122705719..bee63d68201a 100644 > --- a/drivers/vhost/vringh.c > +++ b/drivers/vhost/vringh.c > @@ -290,9 +290,9 @@ __vringh_iov(struct vringh *vrh, u16 i, > return -EINVAL; > > if (riov) > - riov->i = riov->used = 0; > + riov->i = riov->used = riov->consumed = 0; > if (wiov) > - wiov->i = wiov->used = 0; > + wiov->i = wiov->used = wiov->consumed = 0; > > for (;;) { > void *addr;
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c index f68122705719..bee63d68201a 100644 --- a/drivers/vhost/vringh.c +++ b/drivers/vhost/vringh.c @@ -290,9 +290,9 @@ __vringh_iov(struct vringh *vrh, u16 i, return -EINVAL; if (riov) - riov->i = riov->used = 0; + riov->i = riov->used = riov->consumed = 0; if (wiov) - wiov->i = wiov->used = 0; + wiov->i = wiov->used = wiov->consumed = 0; for (;;) { void *addr;
__vringh_iov() overwrites the contents of riov and wiov, in fact it resets the 'i' and 'used' fields, but also the 'consumed' field should be reset to avoid an inconsistent state. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> --- drivers/vhost/vringh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)