diff mbox series

[2/2] KVM: x86/xen: Remove extra unlock in kvm_xen_hvm_set_attr()

Message ID 20210208232326.1830370-2-dwmw2@infradead.org (mailing list archive)
State New, archived
Headers show
Series [1/2] KVM: x86/xen: Allow reset of Xen attributes | expand

Commit Message

David Woodhouse Feb. 8, 2021, 11:23 p.m. UTC 
From: David Woodhouse <dwmw@amazon.co.uk>

This accidentally ended up locking and then immediately unlocking kvm->lock
at the beginning of the function. Fix it.

Fixes: a76b9641ad1c ("KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR")
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
 arch/x86/kvm/xen.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Paolo Bonzini Feb. 9, 2021, 9:59 a.m. UTC | #1 
On 09/02/21 00:23, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> This accidentally ended up locking and then immediately unlocking kvm->lock
> at the beginning of the function. Fix it.
> 
> Fixes: a76b9641ad1c ("KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR")
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   arch/x86/kvm/xen.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
> index 06fec10ffc4f..d8cdd84b1c0e 100644
> --- a/arch/x86/kvm/xen.c
> +++ b/arch/x86/kvm/xen.c
> @@ -105,8 +105,6 @@ int kvm_xen_hvm_set_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
>   
>   	mutex_lock(&kvm->lock);
>   
> -	mutex_unlock(&kvm->lock);
> -
>   	switch (data->type) {
>   	case KVM_XEN_ATTR_TYPE_LONG_MODE:
>   		if (!IS_ENABLED(CONFIG_64BIT) && data->u.long_mode) {
> 

Queued both, thanks.

Paolo
Joao Martins Feb. 9, 2021, 10:03 a.m. UTC | #2 
On 2/8/21 11:23 PM, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> This accidentally ended up locking and then immediately unlocking kvm->lock
> at the beginning of the function. Fix it.
> 
> Fixes: a76b9641ad1c ("KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR")
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
>  arch/x86/kvm/xen.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
> index 06fec10ffc4f..d8cdd84b1c0e 100644
> --- a/arch/x86/kvm/xen.c
> +++ b/arch/x86/kvm/xen.c
> @@ -105,8 +105,6 @@ int kvm_xen_hvm_set_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
>  
>  	mutex_lock(&kvm->lock);
>  
> -	mutex_unlock(&kvm->lock);
> -
>  	switch (data->type) {
>  	case KVM_XEN_ATTR_TYPE_LONG_MODE:
>  		if (!IS_ENABLED(CONFIG_64BIT) && data->u.long_mode) {
>
diff mbox series

Patch

diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
index 06fec10ffc4f..d8cdd84b1c0e 100644
--- a/arch/x86/kvm/xen.c
+++ b/arch/x86/kvm/xen.c
@@ -105,8 +105,6 @@  int kvm_xen_hvm_set_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
 
 	mutex_lock(&kvm->lock);
 
-	mutex_unlock(&kvm->lock);
-
 	switch (data->type) {
 	case KVM_XEN_ATTR_TYPE_LONG_MODE:
 		if (!IS_ENABLED(CONFIG_64BIT) && data->u.long_mode) {