diff mbox series

[-next] KVM: SVM: Make symbol 'svm_gp_erratum_intercept' static

Message ID 20210210075958.1096317-1-weiyongjun1@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] KVM: SVM: Make symbol 'svm_gp_erratum_intercept' static | expand

Commit Message

Wei Yongjun Feb. 10, 2021, 7:59 a.m. UTC
The sparse tool complains as follows:

arch/x86/kvm/svm/svm.c:204:6: warning:
 symbol 'svm_gp_erratum_intercept' was not declared. Should it be static?

This symbol is not used outside of svm.c, so this
commit marks it static.

Fixes: 82a11e9c6fa2b ("KVM: SVM: Add emulation support for #GP triggered by SVM instructions")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 arch/x86/kvm/svm/svm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paolo Bonzini Feb. 10, 2021, 5:11 p.m. UTC | #1
On 10/02/21 08:59, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> arch/x86/kvm/svm/svm.c:204:6: warning:
>   symbol 'svm_gp_erratum_intercept' was not declared. Should it be static?
> 
> This symbol is not used outside of svm.c, so this
> commit marks it static.
> 
> Fixes: 82a11e9c6fa2b ("KVM: SVM: Add emulation support for #GP triggered by SVM instructions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>   arch/x86/kvm/svm/svm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 4141caea857a..4a41d11aabfe 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -201,7 +201,7 @@ module_param(sev_es, int, 0444);
>   bool __read_mostly dump_invalid_vmcb;
>   module_param(dump_invalid_vmcb, bool, 0644);
>   
> -bool svm_gp_erratum_intercept = true;
> +static bool svm_gp_erratum_intercept = true;
>   
>   static u8 rsm_ins_bytes[] = "\x0f\xaa";
>   
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index 4141caea857a..4a41d11aabfe 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -201,7 +201,7 @@  module_param(sev_es, int, 0444);
 bool __read_mostly dump_invalid_vmcb;
 module_param(dump_invalid_vmcb, bool, 0644);
 
-bool svm_gp_erratum_intercept = true;
+static bool svm_gp_erratum_intercept = true;
 
 static u8 rsm_ins_bytes[] = "\x0f\xaa";