| Message ID | 20210218082449.29876-1-frankja@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests] s390x: Remove sthyi partition number check | expand |
On 18.02.21 09:24, Janosch Frank wrote: > Turns out that partition numbers start from 0 and not from 1 so a 0 > check doesn't make sense here. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > s390x/sthyi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/s390x/sthyi.c b/s390x/sthyi.c > index d8dfc854..db90b56f 100644 > --- a/s390x/sthyi.c > +++ b/s390x/sthyi.c > @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par) > report(sum, "core counts"); > > if (par->INFPVAL1 & PART_STSI_SUC) { > - report(par->INFPPNUM, "number"); > report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)), > "name"); > } > Reviewed-by: David Hildenbrand <david@redhat.com>
On Thu, 18 Feb 2021 03:24:49 -0500 Janosch Frank <frankja@linux.ibm.com> wrote: > Turns out that partition numbers start from 0 and not from 1 so a 0 > check doesn't make sense here. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> > --- > s390x/sthyi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/s390x/sthyi.c b/s390x/sthyi.c > index d8dfc854..db90b56f 100644 > --- a/s390x/sthyi.c > +++ b/s390x/sthyi.c > @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par) > report(sum, "core counts"); > > if (par->INFPVAL1 & PART_STSI_SUC) { > - report(par->INFPPNUM, "number"); > report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)), > "name"); > } Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On Thu, 18 Feb 2021 03:24:49 -0500 Janosch Frank <frankja@linux.ibm.com> wrote: > Turns out that partition numbers start from 0 and not from 1 so a 0 > check doesn't make sense here. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > s390x/sthyi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/s390x/sthyi.c b/s390x/sthyi.c > index d8dfc854..db90b56f 100644 > --- a/s390x/sthyi.c > +++ b/s390x/sthyi.c > @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn > *par) report(sum, "core counts"); > > if (par->INFPVAL1 & PART_STSI_SUC) { > - report(par->INFPPNUM, "number"); > report(memcmp(par->INFPPNAM, null_buf, > sizeof(par->INFPPNAM)), "name"); > }
diff --git a/s390x/sthyi.c b/s390x/sthyi.c index d8dfc854..db90b56f 100644 --- a/s390x/sthyi.c +++ b/s390x/sthyi.c @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par) report(sum, "core counts"); if (par->INFPVAL1 & PART_STSI_SUC) { - report(par->INFPPNUM, "number"); report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)), "name"); }
Turns out that partition numbers start from 0 and not from 1 so a 0 check doesn't make sense here. Signed-off-by: Janosch Frank <frankja@linux.ibm.com> --- s390x/sthyi.c | 1 - 1 file changed, 1 deletion(-)