| Message ID | 20210224022931.14094-1-yejune.deng@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: x86: Remove the best->function == 0x7 assignment | expand |
Hmm, the shortlog should provide a higher level overview of the change. Stating the literal code change doesn't provide much context. Maybe: KVM: x86: Remove an unnecessary best->function check On Wed, Feb 24, 2021, Yejune Deng wrote: > In kvm_update_cpuid_runtime(), there is no need the best->function > == 0x7 assignment, because there is e->function == function in s/assignment/check, here and in the shortlog. > cpuid_entry2_find(). > > Signed-off-by: Yejune Deng <yejune.deng@gmail.com> With the shortlog and changelog cleaned up: Reviewed-by: Sean Christopherson <seanjc@google.com> > --- > arch/x86/kvm/cpuid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > index c8f2592ccc99..eb7a01b1907b 100644 > --- a/arch/x86/kvm/cpuid.c > +++ b/arch/x86/kvm/cpuid.c > @@ -120,7 +120,7 @@ void kvm_update_cpuid_runtime(struct kvm_vcpu *vcpu) > } > > best = kvm_find_cpuid_entry(vcpu, 7, 0); > - if (best && boot_cpu_has(X86_FEATURE_PKU) && best->function == 0x7) > + if (best && boot_cpu_has(X86_FEATURE_PKU)) > cpuid_entry_change(best, X86_FEATURE_OSPKE, > kvm_read_cr4_bits(vcpu, X86_CR4_PKE)); > > -- > 2.29.0 >
diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index c8f2592ccc99..eb7a01b1907b 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -120,7 +120,7 @@ void kvm_update_cpuid_runtime(struct kvm_vcpu *vcpu) } best = kvm_find_cpuid_entry(vcpu, 7, 0); - if (best && boot_cpu_has(X86_FEATURE_PKU) && best->function == 0x7) + if (best && boot_cpu_has(X86_FEATURE_PKU)) cpuid_entry_change(best, X86_FEATURE_OSPKE, kvm_read_cr4_bits(vcpu, X86_CR4_PKE));
In kvm_update_cpuid_runtime(), there is no need the best->function == 0x7 assignment, because there is e->function == function in cpuid_entry2_find(). Signed-off-by: Yejune Deng <yejune.deng@gmail.com> --- arch/x86/kvm/cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)