| Message ID | 20210225005915.26423-8-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Unify I/O port and MMIO trap handling | expand |
Hi Andre, On 2/25/21 12:59 AM, Andre Przywara wrote: > Now that the PC keyboard has a trap handler adhering to the MMIO fault > handler prototype, let's switch over to the joint registration routine. > > This allows us to get rid of the ioport shim routines. > > Make the kbd_init() function static on the way. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > hw/i8042.c | 30 ++++-------------------------- > include/kvm/i8042.h | 1 - > 2 files changed, 4 insertions(+), 27 deletions(-) > > diff --git a/hw/i8042.c b/hw/i8042.c > index ab866662..20be36c4 100644 > --- a/hw/i8042.c > +++ b/hw/i8042.c > @@ -325,40 +325,18 @@ static void kbd_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len, > ioport__write8(data, value); > } > > -/* > - * Called when the OS has written to one of the keyboard's ports (0x60 or 0x64) > - */ > -static bool kbd_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > -{ > - kbd_io(vcpu, port, data, size, false, NULL); > - > - return true; > -} > - > -static bool kbd_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > -{ > - kbd_io(vcpu, port, data, size, true, NULL); > - > - return true; > -} > - > -static struct ioport_operations kbd_ops = { > - .io_in = kbd_in, > - .io_out = kbd_out, > -}; > - > -int kbd__init(struct kvm *kvm) > +static int kbd__init(struct kvm *kvm) > { > int r; > > kbd_reset(); > state.kvm = kvm; > - r = ioport__register(kvm, I8042_DATA_REG, &kbd_ops, 2, NULL); > + r = kvm__register_pio(kvm, I8042_DATA_REG, 2, kbd_io, NULL); > if (r < 0) > return r; > - r = ioport__register(kvm, I8042_COMMAND_REG, &kbd_ops, 2, NULL); > + r = kvm__register_pio(kvm, I8042_COMMAND_REG, 2, kbd_io, NULL); > if (r < 0) { > - ioport__unregister(kvm, I8042_DATA_REG); > + kvm__deregister_pio(kvm, I8042_DATA_REG); > return r; > } > > diff --git a/include/kvm/i8042.h b/include/kvm/i8042.h > index 3b4ab688..cd4ae6bb 100644 > --- a/include/kvm/i8042.h > +++ b/include/kvm/i8042.h > @@ -7,6 +7,5 @@ struct kvm; > > void mouse_queue(u8 c); > void kbd_queue(u8 c); > -int kbd__init(struct kvm *kvm); > > #endif Looks good, I also compile tested the code: Reviewed-by: Alexandru Elisei <alexandru.elisei@arm.com> Thanks, Alex
diff --git a/hw/i8042.c b/hw/i8042.c index ab866662..20be36c4 100644 --- a/hw/i8042.c +++ b/hw/i8042.c @@ -325,40 +325,18 @@ static void kbd_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len, ioport__write8(data, value); } -/* - * Called when the OS has written to one of the keyboard's ports (0x60 or 0x64) - */ -static bool kbd_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) -{ - kbd_io(vcpu, port, data, size, false, NULL); - - return true; -} - -static bool kbd_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) -{ - kbd_io(vcpu, port, data, size, true, NULL); - - return true; -} - -static struct ioport_operations kbd_ops = { - .io_in = kbd_in, - .io_out = kbd_out, -}; - -int kbd__init(struct kvm *kvm) +static int kbd__init(struct kvm *kvm) { int r; kbd_reset(); state.kvm = kvm; - r = ioport__register(kvm, I8042_DATA_REG, &kbd_ops, 2, NULL); + r = kvm__register_pio(kvm, I8042_DATA_REG, 2, kbd_io, NULL); if (r < 0) return r; - r = ioport__register(kvm, I8042_COMMAND_REG, &kbd_ops, 2, NULL); + r = kvm__register_pio(kvm, I8042_COMMAND_REG, 2, kbd_io, NULL); if (r < 0) { - ioport__unregister(kvm, I8042_DATA_REG); + kvm__deregister_pio(kvm, I8042_DATA_REG); return r; } diff --git a/include/kvm/i8042.h b/include/kvm/i8042.h index 3b4ab688..cd4ae6bb 100644 --- a/include/kvm/i8042.h +++ b/include/kvm/i8042.h @@ -7,6 +7,5 @@ struct kvm; void mouse_queue(u8 c); void kbd_queue(u8 c); -int kbd__init(struct kvm *kvm); #endif
Now that the PC keyboard has a trap handler adhering to the MMIO fault handler prototype, let's switch over to the joint registration routine. This allows us to get rid of the ioport shim routines. Make the kbd_init() function static on the way. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- hw/i8042.c | 30 ++++-------------------------- include/kvm/i8042.h | 1 - 2 files changed, 4 insertions(+), 27 deletions(-)