From patchwork Thu Mar 25 15:56:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 12164533 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8D3C433C1 for ; Thu, 25 Mar 2021 15:57:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B9A661A21 for ; Thu, 25 Mar 2021 15:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbhCYP52 (ORCPT ); Thu, 25 Mar 2021 11:57:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29827 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbhCYP5I (ORCPT ); Thu, 25 Mar 2021 11:57:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616687828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0//FBRo6OokAHUTq5nOdjoQhfXAjaYtHnLIY4ZWJ6U=; b=ZQ3ofn0Q7z/cRwXqcaiT/EO0SSqFEZwCfyUC/Gqwytg/sbWjYzTxJGJ1cllo2V+5zF6Zkf ToYa4aNj4yflkwItamZ1TsMgpmnOT3nDUrv8ViyAw6zkNnS5RZ+HeTtadFjqj/MLx89Iov yrXWL4h7BRBmUC1r/kmIY+ZAAMLTLCc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-z6Elz8moOMeskB22z9nwNA-1; Thu, 25 Mar 2021 11:57:03 -0400 X-MC-Unique: z6Elz8moOMeskB22z9nwNA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98A961012EE0; Thu, 25 Mar 2021 15:57:02 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.194.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B2E05D736; Thu, 25 Mar 2021 15:57:01 +0000 (UTC) From: Andrew Jones To: kvm@vger.kernel.org Cc: nikos.nikoleris@arm.com, alexandru.elisei@arm.com Subject: [PATCH kvm-unit-tests 1/2] arm64: argc is an int Date: Thu, 25 Mar 2021 16:56:56 +0100 Message-Id: <20210325155657.600897-2-drjones@redhat.com> In-Reply-To: <20210325155657.600897-1-drjones@redhat.com> References: <20210325155657.600897-1-drjones@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org If argc isn't aligned to eight bytes then loading it as if it's eight bytes wide is a bad idea. It's only four bytes wide, so we should only load four bytes. Reported-by: Nikos Nikoleris Signed-off-by: Andrew Jones Reviewed-by: Nikos Nikoleris --- arm/cstart64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arm/cstart64.S b/arm/cstart64.S index 89321dad7aba..0a85338bcdae 100644 --- a/arm/cstart64.S +++ b/arm/cstart64.S @@ -100,7 +100,7 @@ start: 1: /* run the test */ adrp x0, __argc - ldr x0, [x0, :lo12:__argc] + ldr w0, [x0, :lo12:__argc] adrp x1, __argv add x1, x1, :lo12:__argv adrp x2, __environ