| Message ID | 20210326070334.12310-1-dongli.zhang@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] KVM: x86: remove unused declaration of kvm_write_tsc() | expand |
Dongli Zhang <dongli.zhang@oracle.com> writes: > The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do > not attempt TSC synchronization on guest writes"). Remove its unused > declaration. It's not just not used, it's not present. Let me try to rephrase the commit message a bit: " Commit 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on guest writes") renamed kvm_write_tsc() to kvm_synchronize_tsc() and made it 'static'. Remove the leftover declaration from x86.h Fixes: 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on guest writes") " The subject line should probably also get adjusted like "KVM: x86: remove dangling declaration of kvm_write_tsc()" > > Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> > --- > arch/x86/kvm/x86.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h > index 39eb04887141..9035e34aa156 100644 > --- a/arch/x86/kvm/x86.h > +++ b/arch/x86/kvm/x86.h > @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu) > void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs); > void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip); > > -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr); > u64 get_kvmclock_ns(struct kvm *kvm); > > int kvm_read_guest_virt(struct kvm_vcpu *vcpu,
On 26/03/21 08:03, Dongli Zhang wrote: > The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do > not attempt TSC synchronization on guest writes"). Remove its unused > declaration. > > Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> > --- > arch/x86/kvm/x86.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h > index 39eb04887141..9035e34aa156 100644 > --- a/arch/x86/kvm/x86.h > +++ b/arch/x86/kvm/x86.h > @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu) > void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs); > void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip); > > -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr); > u64 get_kvmclock_ns(struct kvm *kvm); > > int kvm_read_guest_virt(struct kvm_vcpu *vcpu, > Queued, thanks (with slight editing of the commit message as Vitaly mentioned). Paolo
diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h index 39eb04887141..9035e34aa156 100644 --- a/arch/x86/kvm/x86.h +++ b/arch/x86/kvm/x86.h @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu) void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs); void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip); -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr); u64 get_kvmclock_ns(struct kvm *kvm); int kvm_read_guest_virt(struct kvm_vcpu *vcpu,
The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on guest writes"). Remove its unused declaration. Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> --- arch/x86/kvm/x86.h | 1 - 1 file changed, 1 deletion(-)