From patchwork Tue Apr 20 19:00:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 12214999 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC977C433B4 for ; Tue, 20 Apr 2021 19:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3D88613C9 for ; Tue, 20 Apr 2021 19:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233719AbhDTTCI (ORCPT ); Tue, 20 Apr 2021 15:02:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45735 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233702AbhDTTCC (ORCPT ); Tue, 20 Apr 2021 15:02:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618945290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Ma7KqF/omEAl7IA6u7SjFcPlLYC7wcbkLXbqukcVVc=; b=LU3fhmp7DJe5elG6r32mfKvBtd8lWy6vDyKNHsAUHGRrZGxrAgKlTZg1klZMpSlPQIF+b/ lWxHP6H73tN946QW/7ZlFrBpDMKiOmdgsB2bdlLYsedGRYlHFv17sGA9DPJgqXaU8sZIx9 r7cI3iNWd2w+HTBZN4U7XsYhw+QcnH8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-DkAIbEGLOaWfi8vSdV-k7Q-1; Tue, 20 Apr 2021 15:01:28 -0400 X-MC-Unique: DkAIbEGLOaWfi8vSdV-k7Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 423E41966326; Tue, 20 Apr 2021 19:01:27 +0000 (UTC) Received: from gator.home (unknown [10.40.195.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FAB119701; Tue, 20 Apr 2021 19:01:07 +0000 (UTC) From: Andrew Jones To: kvm@vger.kernel.org Cc: alexandru.elisei@arm.com, nikos.nikoleris@arm.com, andre.przywara@arm.com, eric.auger@redhat.com Subject: [PATCH kvm-unit-tests v2 7/8] chr-testdev: Silently fail init Date: Tue, 20 Apr 2021 21:00:01 +0200 Message-Id: <20210420190002.383444-8-drjones@redhat.com> In-Reply-To: <20210420190002.383444-1-drjones@redhat.com> References: <20210420190002.383444-1-drjones@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org If there's no virtio-console / chr-testdev configured, then the user probably didn't want them. Just silently fail rather than stating the obvious. Reviewed-by: Nikos Nikoleris Reviewed-by: Alexandru Elisei Signed-off-by: Andrew Jones --- lib/chr-testdev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/chr-testdev.c b/lib/chr-testdev.c index 6890f63c8b29..b3c641a833fe 100644 --- a/lib/chr-testdev.c +++ b/lib/chr-testdev.c @@ -54,11 +54,8 @@ void chr_testdev_init(void) int ret; vcon = virtio_bind(VIRTIO_ID_CONSOLE); - if (vcon == NULL) { - printf("%s: %s: can't find a virtio-console\n", - __func__, TESTDEV_NAME); + if (vcon == NULL) return; - } ret = vcon->config->find_vqs(vcon, 2, vqs, NULL, io_names); if (ret < 0) {