diff mbox series

[kvm-unit-tests] s390x: Fix vector stfle checks

Message ID 20210503124713.68975-1-frankja@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] s390x: Fix vector stfle checks | expand

Commit Message

Janosch Frank May 3, 2021, 12:47 p.m. UTC
134 is for bcd
135 is for the vector enhancements

Not the other way around...

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Suggested-by: David Hildenbrand <david@redhat.com>
---
 s390x/vector.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Hildenbrand May 3, 2021, 12:52 p.m. UTC | #1
On 03.05.21 14:47, Janosch Frank wrote:
> 134 is for bcd
> 135 is for the vector enhancements
> 
> Not the other way around...
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> ---
>   s390x/vector.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/s390x/vector.c b/s390x/vector.c
> index d1b6a571..b052de55 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -53,7 +53,7 @@ static void test_add(void)
>   /* z14 vector extension test */
>   static void test_ext1_nand(void)
>   {
> -	bool has_vext = test_facility(134);
> +	bool has_vext = test_facility(135);
>   	static struct prm {
>   		__uint128_t a,b,c;
>   	} prm __attribute__((aligned(16)));
> @@ -79,7 +79,7 @@ static void test_ext1_nand(void)
>   /* z14 bcd extension test */
>   static void test_bcd_add(void)
>   {
> -	bool has_bcd = test_facility(135);
> +	bool has_bcd = test_facility(134);
>   	static struct prm {
>   		__uint128_t a,b,c;
>   	} prm __attribute__((aligned(16)));
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

thanks!
Cornelia Huck May 3, 2021, 12:54 p.m. UTC | #2
On Mon,  3 May 2021 12:47:13 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> 134 is for bcd
> 135 is for the vector enhancements
> 
> Not the other way around...
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> ---
>  s390x/vector.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Claudio Imbrenda May 3, 2021, 1:06 p.m. UTC | #3
On Mon,  3 May 2021 12:47:13 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> 134 is for bcd
> 135 is for the vector enhancements
> 
> Not the other way around...
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  s390x/vector.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/s390x/vector.c b/s390x/vector.c
> index d1b6a571..b052de55 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -53,7 +53,7 @@ static void test_add(void)
>  /* z14 vector extension test */
>  static void test_ext1_nand(void)
>  {
> -	bool has_vext = test_facility(134);
> +	bool has_vext = test_facility(135);
>  	static struct prm {
>  		__uint128_t a,b,c;
>  	} prm __attribute__((aligned(16)));
> @@ -79,7 +79,7 @@ static void test_ext1_nand(void)
>  /* z14 bcd extension test */
>  static void test_bcd_add(void)
>  {
> -	bool has_bcd = test_facility(135);
> +	bool has_bcd = test_facility(134);
>  	static struct prm {
>  		__uint128_t a,b,c;
>  	} prm __attribute__((aligned(16)));
diff mbox series

Patch

diff --git a/s390x/vector.c b/s390x/vector.c
index d1b6a571..b052de55 100644
--- a/s390x/vector.c
+++ b/s390x/vector.c
@@ -53,7 +53,7 @@  static void test_add(void)
 /* z14 vector extension test */
 static void test_ext1_nand(void)
 {
-	bool has_vext = test_facility(134);
+	bool has_vext = test_facility(135);
 	static struct prm {
 		__uint128_t a,b,c;
 	} prm __attribute__((aligned(16)));
@@ -79,7 +79,7 @@  static void test_ext1_nand(void)
 /* z14 bcd extension test */
 static void test_bcd_add(void)
 {
-	bool has_bcd = test_facility(135);
+	bool has_bcd = test_facility(134);
 	static struct prm {
 		__uint128_t a,b,c;
 	} prm __attribute__((aligned(16)));