| Message ID | 20210531072743.363171-2-lingshan.zhu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | update virtio id table | expand |
On Mon, 31 May 2021 15:27:42 +0800 Zhu Lingshan <lingshan.zhu@intel.com> wrote: > This commit updates virtio id table by adding transitional device > ids > > Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> > --- > include/uapi/linux/virtio_ids.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h > index f0c35ce8628c..fcc9ec6a73c1 100644 > --- a/include/uapi/linux/virtio_ids.h > +++ b/include/uapi/linux/virtio_ids.h > @@ -57,4 +57,16 @@ > #define VIRTIO_ID_BT 28 /* virtio bluetooth */ > #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ > > +/* > + * Virtio Transitional IDs > + */ > + > +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */ > +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */ > +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */ > +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */ > +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */ > +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */ > +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */ > + > #endif /* _LINUX_VIRTIO_IDS_H */ Isn't this a purely virtio-pci concept? (The spec lists the virtio ids in the common section, and those transitional ids in the pci section.) IOW, is there a better, virtio-pci specific, header for this?
On 5/31/2021 3:58 PM, Cornelia Huck wrote: > On Mon, 31 May 2021 15:27:42 +0800 > Zhu Lingshan <lingshan.zhu@intel.com> wrote: > >> This commit updates virtio id table by adding transitional device >> ids >> virtio_pci_common.h >> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> >> --- >> include/uapi/linux/virtio_ids.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h >> index f0c35ce8628c..fcc9ec6a73c1 100644 >> --- a/include/uapi/linux/virtio_ids.h >> +++ b/include/uapi/linux/virtio_ids.h >> @@ -57,4 +57,16 @@ >> #define VIRTIO_ID_BT 28 /* virtio bluetooth */ >> #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ >> >> +/* >> + * Virtio Transitional IDs >> + */ >> + >> +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */ >> +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */ >> +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */ >> +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */ >> +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */ >> +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */ >> +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */ >> + >> #endif /* _LINUX_VIRTIO_IDS_H */ > Isn't this a purely virtio-pci concept? (The spec lists the virtio ids > in the common section, and those transitional ids in the pci section.) > IOW, is there a better, virtio-pci specific, header for this? Hi Cornelia, yes they are pure virtio-pci transitional concept. There is a virtio_pci.h, but not looks like a good place for these stuffs, Michael ever suggested to add these ids to virtio_ids.h, so I have chosen this file. https://www.spinics.net/lists/netdev/msg739269.html Thanks Zhu Lingshan >
On Mon, May 31, 2021 at 05:57:47PM +0800, Zhu, Lingshan wrote: > > > On 5/31/2021 3:58 PM, Cornelia Huck wrote: > > On Mon, 31 May 2021 15:27:42 +0800 > > Zhu Lingshan <lingshan.zhu@intel.com> wrote: > > > > > This commit updates virtio id table by adding transitional device > > > ids > > > virtio_pci_common.h > > > Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> > > > --- > > > include/uapi/linux/virtio_ids.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h > > > index f0c35ce8628c..fcc9ec6a73c1 100644 > > > --- a/include/uapi/linux/virtio_ids.h > > > +++ b/include/uapi/linux/virtio_ids.h > > > @@ -57,4 +57,16 @@ > > > #define VIRTIO_ID_BT 28 /* virtio bluetooth */ > > > #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ > > > +/* > > > + * Virtio Transitional IDs > > > + */ > > > + > > > +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */ > > > +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */ > > > +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */ > > > +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */ > > > +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */ > > > +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */ > > > +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */ > > > + > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > Isn't this a purely virtio-pci concept? (The spec lists the virtio ids > > in the common section, and those transitional ids in the pci section.) > > IOW, is there a better, virtio-pci specific, header for this? > Hi Cornelia, > > yes they are pure virtio-pci transitional concept. There is a virtio_pci.h, > but not looks like > a good place for these stuffs, Michael ever suggested to add these ids to > virtio_ids.h, so I have > chosen this file. > > https://www.spinics.net/lists/netdev/msg739269.html Didn't think straight, virtio_pci.h is better. > Thanks > Zhu Lingshan > >
diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h index f0c35ce8628c..fcc9ec6a73c1 100644 --- a/include/uapi/linux/virtio_ids.h +++ b/include/uapi/linux/virtio_ids.h @@ -57,4 +57,16 @@ #define VIRTIO_ID_BT 28 /* virtio bluetooth */ #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ +/* + * Virtio Transitional IDs + */ + +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */ +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */ +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */ +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */ +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */ +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */ +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */ + #endif /* _LINUX_VIRTIO_IDS_H */
This commit updates virtio id table by adding transitional device ids Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> --- include/uapi/linux/virtio_ids.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)