| Message ID | 20210611235701.3941724-8-dmatlack@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: x86/mmu: Fast page fault support for the TDP MMU | expand |
On Fri, Jun 11, 2021 at 4:57 PM David Matlack <dmatlack@google.com> wrote: > > There is a missing break statement which causes a fallthrough to the > next statement where optarg will be null and a segmentation fault will > be generated. > > Fixes: 9e965bb75aae ("KVM: selftests: Add backing src parameter to dirty_log_perf_test") > Signed-off-by: David Matlack <dmatlack@google.com> Reviewed-by: Ben Gardon > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 04a2641261be..80cbd3a748c0 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -312,6 +312,7 @@ int main(int argc, char *argv[]) > break; > case 'o': > p.partition_vcpu_memory_access = false; > + break; > case 's': > p.backing_src = parse_backing_src_type(optarg); > break; > -- > 2.32.0.272.g935e593368-goog >
diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c index 04a2641261be..80cbd3a748c0 100644 --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c @@ -312,6 +312,7 @@ int main(int argc, char *argv[]) break; case 'o': p.partition_vcpu_memory_access = false; + break; case 's': p.backing_src = parse_backing_src_type(optarg); break;
There is a missing break statement which causes a fallthrough to the next statement where optarg will be null and a segmentation fault will be generated. Fixes: 9e965bb75aae ("KVM: selftests: Add backing src parameter to dirty_log_perf_test") Signed-off-by: David Matlack <dmatlack@google.com> --- tools/testing/selftests/kvm/dirty_log_perf_test.c | 1 + 1 file changed, 1 insertion(+)