diff mbox series

[v5,2/8] KVM: arm64: Add missing field descriptor for MDCR_EL2

Message ID 20210827101609.2808181-3-tabba@google.com (mailing list archive)
State New, archived
Headers show
Series KVM: arm64: Fixed features for protected VMs | expand

Commit Message

Fuad Tabba Aug. 27, 2021, 10:16 a.m. UTC
It's not currently used. Added for completeness.

No functional change intended.

Suggested-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Fuad Tabba <tabba@google.com>
---
 arch/arm64/include/asm/kvm_arm.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Jones Sept. 8, 2021, 12:38 p.m. UTC | #1
On Fri, Aug 27, 2021 at 11:16:03AM +0100, Fuad Tabba wrote:
> It's not currently used. Added for completeness.
> 
> No functional change intended.
> 
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Fuad Tabba <tabba@google.com>
> ---
>  arch/arm64/include/asm/kvm_arm.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
> index 327120c0089f..a39fcf318c77 100644
> --- a/arch/arm64/include/asm/kvm_arm.h
> +++ b/arch/arm64/include/asm/kvm_arm.h
> @@ -295,6 +295,7 @@
>  #define MDCR_EL2_HPMFZO		(UL(1) << 29)
>  #define MDCR_EL2_MTPME		(UL(1) << 28)
>  #define MDCR_EL2_TDCC		(UL(1) << 27)
> +#define MDCR_EL2_HLP		(UL(1) << 26)
>  #define MDCR_EL2_HCCD		(UL(1) << 23)
>  #define MDCR_EL2_TTRF		(UL(1) << 19)
>  #define MDCR_EL2_HPMD		(UL(1) << 17)
> -- 
> 2.33.0.259.gc128427fd7-goog
>

If we're proactively adding bits per the most recent spec, then I guess we
could also add HPMFZS (bit 36). Otherwise,

Reviewed-by: Andrew Jones <drjones@redhat.com>
Fuad Tabba Sept. 22, 2021, 9:34 a.m. UTC | #2
Hi Andrew,

On Wed, Sep 8, 2021 at 1:38 PM Andrew Jones <drjones@redhat.com> wrote:
>
> On Fri, Aug 27, 2021 at 11:16:03AM +0100, Fuad Tabba wrote:
> > It's not currently used. Added for completeness.
> >
> > No functional change intended.
> >
> > Suggested-by: Marc Zyngier <maz@kernel.org>
> > Signed-off-by: Fuad Tabba <tabba@google.com>
> > ---
> >  arch/arm64/include/asm/kvm_arm.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
> > index 327120c0089f..a39fcf318c77 100644
> > --- a/arch/arm64/include/asm/kvm_arm.h
> > +++ b/arch/arm64/include/asm/kvm_arm.h
> > @@ -295,6 +295,7 @@
> >  #define MDCR_EL2_HPMFZO              (UL(1) << 29)
> >  #define MDCR_EL2_MTPME               (UL(1) << 28)
> >  #define MDCR_EL2_TDCC                (UL(1) << 27)
> > +#define MDCR_EL2_HLP         (UL(1) << 26)
> >  #define MDCR_EL2_HCCD                (UL(1) << 23)
> >  #define MDCR_EL2_TTRF                (UL(1) << 19)
> >  #define MDCR_EL2_HPMD                (UL(1) << 17)
> > --
> > 2.33.0.259.gc128427fd7-goog
> >
>
> If we're proactively adding bits per the most recent spec, then I guess we
> could also add HPMFZS (bit 36). Otherwise,

Seems someone has beaten me to it. HPMFZS is in 5.15-rc2 at least
(which I'm going to be rebasing on/respinning).

Thanks,
/fuad

>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
>
diff mbox series

Patch

diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
index 327120c0089f..a39fcf318c77 100644
--- a/arch/arm64/include/asm/kvm_arm.h
+++ b/arch/arm64/include/asm/kvm_arm.h
@@ -295,6 +295,7 @@ 
 #define MDCR_EL2_HPMFZO		(UL(1) << 29)
 #define MDCR_EL2_MTPME		(UL(1) << 28)
 #define MDCR_EL2_TDCC		(UL(1) << 27)
+#define MDCR_EL2_HLP		(UL(1) << 26)
 #define MDCR_EL2_HCCD		(UL(1) << 23)
 #define MDCR_EL2_TTRF		(UL(1) << 19)
 #define MDCR_EL2_HPMD		(UL(1) << 17)