| Message ID | 20210827105407.313916-1-drjones@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests,v2] Makefile: Don't trust PWD | expand |
On 8/27/21 12:54 PM, Andrew Jones wrote: > PWD comes from the environment and it's possible that it's already > set to something which isn't the full path of the current working > directory. Use the make variable $(CURDIR) instead. > > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index f7b9f28c9319..6792b93c4e16 100644 > --- a/Makefile > +++ b/Makefile > @@ -119,7 +119,7 @@ cscope: cscope_dirs = lib lib/libfdt lib/linux $(TEST_DIR) $(ARCH_LIBDIRS) lib/a > cscope: > $(RM) ./cscope.* > find -L $(cscope_dirs) -maxdepth 1 \ > - -name '*.[chsS]' -exec realpath --relative-base=$(PWD) {} \; | sort -u > ./cscope.files > + -name '*.[chsS]' -exec realpath --relative-base=$(CURDIR) {} \; | sort -u > ./cscope.files > cscope -bk > > .PHONY: tags > Perfect for me, works as expected on Z. Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
On 27/08/2021 12.54, Andrew Jones wrote: > PWD comes from the environment and it's possible that it's already > set to something which isn't the full path of the current working > directory. Use the make variable $(CURDIR) instead. > > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index f7b9f28c9319..6792b93c4e16 100644 > --- a/Makefile > +++ b/Makefile > @@ -119,7 +119,7 @@ cscope: cscope_dirs = lib lib/libfdt lib/linux $(TEST_DIR) $(ARCH_LIBDIRS) lib/a > cscope: > $(RM) ./cscope.* > find -L $(cscope_dirs) -maxdepth 1 \ > - -name '*.[chsS]' -exec realpath --relative-base=$(PWD) {} \; | sort -u > ./cscope.files > + -name '*.[chsS]' -exec realpath --relative-base=$(CURDIR) {} \; | sort -u > ./cscope.files > cscope -bk > > .PHONY: tags > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Fri, Aug 27, 2021 at 12:54:07PM +0200, Andrew Jones wrote: > PWD comes from the environment and it's possible that it's already > set to something which isn't the full path of the current working > directory. Use the make variable $(CURDIR) instead. > > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index f7b9f28c9319..6792b93c4e16 100644 > --- a/Makefile > +++ b/Makefile > @@ -119,7 +119,7 @@ cscope: cscope_dirs = lib lib/libfdt lib/linux $(TEST_DIR) $(ARCH_LIBDIRS) lib/a > cscope: > $(RM) ./cscope.* > find -L $(cscope_dirs) -maxdepth 1 \ > - -name '*.[chsS]' -exec realpath --relative-base=$(PWD) {} \; | sort -u > ./cscope.files > + -name '*.[chsS]' -exec realpath --relative-base=$(CURDIR) {} \; | sort -u > ./cscope.files > cscope -bk > > .PHONY: tags > -- > 2.31.1 > Applied to misc/queue and merged to master. Thanks, drew
diff --git a/Makefile b/Makefile index f7b9f28c9319..6792b93c4e16 100644 --- a/Makefile +++ b/Makefile @@ -119,7 +119,7 @@ cscope: cscope_dirs = lib lib/libfdt lib/linux $(TEST_DIR) $(ARCH_LIBDIRS) lib/a cscope: $(RM) ./cscope.* find -L $(cscope_dirs) -maxdepth 1 \ - -name '*.[chsS]' -exec realpath --relative-base=$(PWD) {} \; | sort -u > ./cscope.files + -name '*.[chsS]' -exec realpath --relative-base=$(CURDIR) {} \; | sort -u > ./cscope.files cscope -bk .PHONY: tags
PWD comes from the environment and it's possible that it's already set to something which isn't the full path of the current working directory. Use the make variable $(CURDIR) instead. Suggested-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Andrew Jones <drjones@redhat.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)