diff mbox series

[v2,1/7] nitro_enclaves: Enable Arm64 support

Message ID 20210827133230.29816-2-andraprs@amazon.com (mailing list archive)
State New, archived
Headers show
Series nitro_enclaves: Add support for Arm64 | expand

Commit Message

Paraschiv, Andra-Irina Aug. 27, 2021, 1:32 p.m. UTC 
Update the kernel config to enable the Nitro Enclaves kernel driver for
Arm64 support.

Changelog

v1 -> v2

* No changes.

Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
---
 drivers/virt/nitro_enclaves/Kconfig | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Greg Kroah-Hartman Aug. 27, 2021, 2:25 p.m. UTC | #1 
On Fri, Aug 27, 2021 at 04:32:24PM +0300, Andra Paraschiv wrote:
> Update the kernel config to enable the Nitro Enclaves kernel driver for
> Arm64 support.
> 
> Changelog
> 
> v1 -> v2
> 
> * No changes.
> 

changelogs for different all go below the --- line, as is documented.
No need for them here in the changelog text itself, right?

Please fix up and send a v3 series.

thanks,

greg k-h
Paraschiv, Andra-Irina Aug. 27, 2021, 3:02 p.m. UTC | #2 
On 27/08/2021 17:25, Greg KH wrote:
> On Fri, Aug 27, 2021 at 04:32:24PM +0300, Andra Paraschiv wrote:
>> Update the kernel config to enable the Nitro Enclaves kernel driver for
>> Arm64 support.
>>
>> Changelog
>>
>> v1 -> v2
>>
>> * No changes.
>>
> changelogs for different all go below the --- line, as is documented.
> No need for them here in the changelog text itself, right?
>
> Please fix up and send a v3 series.

Alright, I can modify the patches so that the changelog is after the line.

I followed the same pattern as the initial time, when I received 
feedback to have the changelogs in the commit message, before SoB(s).

But that's fine with me, I can switch to this way of doing it, as 
mentioned also in the docs.

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
Greg Kroah-Hartman Aug. 27, 2021, 3:24 p.m. UTC | #3 
On Fri, Aug 27, 2021 at 06:02:57PM +0300, Paraschiv, Andra-Irina wrote:
> 
> 
> On 27/08/2021 17:25, Greg KH wrote:
> > On Fri, Aug 27, 2021 at 04:32:24PM +0300, Andra Paraschiv wrote:
> > > Update the kernel config to enable the Nitro Enclaves kernel driver for
> > > Arm64 support.
> > > 
> > > Changelog
> > > 
> > > v1 -> v2
> > > 
> > > * No changes.
> > > 
> > changelogs for different all go below the --- line, as is documented.
> > No need for them here in the changelog text itself, right?
> > 
> > Please fix up and send a v3 series.
> 
> Alright, I can modify the patches so that the changelog is after the line.
> 
> I followed the same pattern as the initial time, when I received feedback to
> have the changelogs in the commit message, before SoB(s).

Only the crazy drm developers seem to use that format :)

> But that's fine with me, I can switch to this way of doing it, as mentioned
> also in the docs.

Thank you.

greg k-h
diff mbox series

Patch

diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
index 8c9387a232df8..f53740b941c0f 100644
--- a/drivers/virt/nitro_enclaves/Kconfig
+++ b/drivers/virt/nitro_enclaves/Kconfig
@@ -1,17 +1,13 @@ 
 # SPDX-License-Identifier: GPL-2.0
 #
-# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 
 # Amazon Nitro Enclaves (NE) support.
 # Nitro is a hypervisor that has been developed by Amazon.
 
-# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
-# the NE kernel driver can be built for aarch64 arch.
-# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
-
 config NITRO_ENCLAVES
 	tristate "Nitro Enclaves Support"
-	depends on X86 && HOTPLUG_CPU && PCI && SMP
+	depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
 	help
 	  This driver consists of support for enclave lifetime management
 	  for Nitro Enclaves (NE).