diff mbox series

[v3,1/7] nitro_enclaves: Enable Arm64 support

Message ID 20210827154930.40608-2-andraprs@amazon.com (mailing list archive)
State New, archived
Headers show
Series nitro_enclaves: Add support for Arm64 | expand

Commit Message

Paraschiv, Andra-Irina Aug. 27, 2021, 3:49 p.m. UTC
Update the kernel config to enable the Nitro Enclaves kernel driver for
Arm64 support.

Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
---
Changelog

v1 -> v2

* No changes.

v2 -> v3

* Move changelog after the "---" line.
---
 drivers/virt/nitro_enclaves/Kconfig | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

George-Aurelian Popescu Aug. 30, 2021, 3:59 p.m. UTC | #1
On Fri, Aug 27, 2021 at 06:49:24PM +0300, Andra Paraschiv wrote:
> Update the kernel config to enable the Nitro Enclaves kernel driver for
> Arm64 support.
> 
> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
> Acked-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> Changelog
> 
> v1 -> v2
> 
> * No changes.
> 
> v2 -> v3
> 
> * Move changelog after the "---" line.
> ---
>  drivers/virt/nitro_enclaves/Kconfig | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
> index 8c9387a232df8..f53740b941c0f 100644
> --- a/drivers/virt/nitro_enclaves/Kconfig
> +++ b/drivers/virt/nitro_enclaves/Kconfig
> @@ -1,17 +1,13 @@
>  # SPDX-License-Identifier: GPL-2.0
>  #
> -# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> +# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>  
>  # Amazon Nitro Enclaves (NE) support.
>  # Nitro is a hypervisor that has been developed by Amazon.
>  
> -# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
> -# the NE kernel driver can be built for aarch64 arch.
> -# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
> -
>  config NITRO_ENCLAVES
>  	tristate "Nitro Enclaves Support"
> -	depends on X86 && HOTPLUG_CPU && PCI && SMP
> +	depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>  	help
>  	  This driver consists of support for enclave lifetime management
>  	  for Nitro Enclaves (NE).
> -- 
> 2.20.1 (Apple Git-117)
> 

Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>

Awesome,
George



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
Paraschiv, Andra-Irina Aug. 30, 2021, 6:30 p.m. UTC | #2
On 30/08/2021 18:59, George-Aurelian Popescu wrote:
> On Fri, Aug 27, 2021 at 06:49:24PM +0300, Andra Paraschiv wrote:
>> Update the kernel config to enable the Nitro Enclaves kernel driver for
>> Arm64 support.
>>
>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>> Acked-by: Stefano Garzarella <sgarzare@redhat.com>
>> ---
>> Changelog
>>
>> v1 -> v2
>>
>> * No changes.
>>
>> v2 -> v3
>>
>> * Move changelog after the "---" line.
>> ---
>>   drivers/virt/nitro_enclaves/Kconfig | 8 ++------
>>   1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
>> index 8c9387a232df8..f53740b941c0f 100644
>> --- a/drivers/virt/nitro_enclaves/Kconfig
>> +++ b/drivers/virt/nitro_enclaves/Kconfig
>> @@ -1,17 +1,13 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   #
>> -# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>> +# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>>   
>>   # Amazon Nitro Enclaves (NE) support.
>>   # Nitro is a hypervisor that has been developed by Amazon.
>>   
>> -# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
>> -# the NE kernel driver can be built for aarch64 arch.
>> -# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>> -
>>   config NITRO_ENCLAVES
>>   	tristate "Nitro Enclaves Support"
>> -	depends on X86 && HOTPLUG_CPU && PCI && SMP
>> +	depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>>   	help
>>   	  This driver consists of support for enclave lifetime management
>>   	  for Nitro Enclaves (NE).
>> -- 
>> 2.20.1 (Apple Git-117)
>>
> Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>
>

Thanks, George, for review.

Greg, let me know if other updates are needed for the patch series. 
Otherwise, please include the patches in the char-misc tree and we can 
target the current merge window, for v5.15. Thank you.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
Greg KH Aug. 31, 2021, 6:43 a.m. UTC | #3
On Mon, Aug 30, 2021 at 09:30:04PM +0300, Paraschiv, Andra-Irina wrote:
> 
> 
> On 30/08/2021 18:59, George-Aurelian Popescu wrote:
> > On Fri, Aug 27, 2021 at 06:49:24PM +0300, Andra Paraschiv wrote:
> > > Update the kernel config to enable the Nitro Enclaves kernel driver for
> > > Arm64 support.
> > > 
> > > Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
> > > Acked-by: Stefano Garzarella <sgarzare@redhat.com>
> > > ---
> > > Changelog
> > > 
> > > v1 -> v2
> > > 
> > > * No changes.
> > > 
> > > v2 -> v3
> > > 
> > > * Move changelog after the "---" line.
> > > ---
> > >   drivers/virt/nitro_enclaves/Kconfig | 8 ++------
> > >   1 file changed, 2 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
> > > index 8c9387a232df8..f53740b941c0f 100644
> > > --- a/drivers/virt/nitro_enclaves/Kconfig
> > > +++ b/drivers/virt/nitro_enclaves/Kconfig
> > > @@ -1,17 +1,13 @@
> > >   # SPDX-License-Identifier: GPL-2.0
> > >   #
> > > -# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> > > +# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> > >   # Amazon Nitro Enclaves (NE) support.
> > >   # Nitro is a hypervisor that has been developed by Amazon.
> > > -# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
> > > -# the NE kernel driver can be built for aarch64 arch.
> > > -# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
> > > -
> > >   config NITRO_ENCLAVES
> > >   	tristate "Nitro Enclaves Support"
> > > -	depends on X86 && HOTPLUG_CPU && PCI && SMP
> > > +	depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
> > >   	help
> > >   	  This driver consists of support for enclave lifetime management
> > >   	  for Nitro Enclaves (NE).
> > > -- 
> > > 2.20.1 (Apple Git-117)
> > > 
> > Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>
> > 
> 
> Thanks, George, for review.
> 
> Greg, let me know if other updates are needed for the patch series.
> Otherwise, please include the patches in the char-misc tree and we can
> target the current merge window, for v5.15. Thank you.

It's too late for 5.15-rc1, I will queue them up after 5.15-rc1 is out,
thanks.

greg k-h
Paraschiv, Andra-Irina Aug. 31, 2021, 7:51 a.m. UTC | #4
On 31/08/2021 09:43, Greg KH wrote:
> On Mon, Aug 30, 2021 at 09:30:04PM +0300, Paraschiv, Andra-Irina wrote:
>>
>> On 30/08/2021 18:59, George-Aurelian Popescu wrote:
>>> On Fri, Aug 27, 2021 at 06:49:24PM +0300, Andra Paraschiv wrote:
>>>> Update the kernel config to enable the Nitro Enclaves kernel driver for
>>>> Arm64 support.
>>>>
>>>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>>>> Acked-by: Stefano Garzarella <sgarzare@redhat.com>
>>>> ---
>>>> Changelog
>>>>
>>>> v1 -> v2
>>>>
>>>> * No changes.
>>>>
>>>> v2 -> v3
>>>>
>>>> * Move changelog after the "---" line.
>>>> ---
>>>>    drivers/virt/nitro_enclaves/Kconfig | 8 ++------
>>>>    1 file changed, 2 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
>>>> index 8c9387a232df8..f53740b941c0f 100644
>>>> --- a/drivers/virt/nitro_enclaves/Kconfig
>>>> +++ b/drivers/virt/nitro_enclaves/Kconfig
>>>> @@ -1,17 +1,13 @@
>>>>    # SPDX-License-Identifier: GPL-2.0
>>>>    #
>>>> -# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>>>> +# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>>>>    # Amazon Nitro Enclaves (NE) support.
>>>>    # Nitro is a hypervisor that has been developed by Amazon.
>>>> -# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
>>>> -# the NE kernel driver can be built for aarch64 arch.
>>>> -# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>>>> -
>>>>    config NITRO_ENCLAVES
>>>>            tristate "Nitro Enclaves Support"
>>>> - depends on X86 && HOTPLUG_CPU && PCI && SMP
>>>> + depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>>>>            help
>>>>              This driver consists of support for enclave lifetime management
>>>>              for Nitro Enclaves (NE).
>>>> --
>>>> 2.20.1 (Apple Git-117)
>>>>
>>> Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>
>>>
>> Thanks, George, for review.
>>
>> Greg, let me know if other updates are needed for the patch series.
>> Otherwise, please include the patches in the char-misc tree and we can
>> target the current merge window, for v5.15. Thank you.
> It's too late for 5.15-rc1, I will queue them up after 5.15-rc1 is out,
> thanks.

Ack, thanks for info. Then would be the next rc, no functional codebase 
changes being included. Or just let me know if other release phase would 
be targeted.

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
Paraschiv, Andra-Irina Nov. 4, 2021, 7:03 p.m. UTC | #5
On 31/08/2021 10:51, Paraschiv, Andra-Irina wrote:
> 
> 
> On 31/08/2021 09:43, Greg KH wrote:
>> On Mon, Aug 30, 2021 at 09:30:04PM +0300, Paraschiv, Andra-Irina wrote:
>>>
>>> On 30/08/2021 18:59, George-Aurelian Popescu wrote:
>>>> On Fri, Aug 27, 2021 at 06:49:24PM +0300, Andra Paraschiv wrote:
>>>>> Update the kernel config to enable the Nitro Enclaves kernel driver 
>>>>> for
>>>>> Arm64 support.
>>>>>
>>>>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>>>>> Acked-by: Stefano Garzarella <sgarzare@redhat.com>
>>>>> ---
>>>>> Changelog
>>>>>
>>>>> v1 -> v2
>>>>>
>>>>> * No changes.
>>>>>
>>>>> v2 -> v3
>>>>>
>>>>> * Move changelog after the "---" line.
>>>>> ---
>>>>>    drivers/virt/nitro_enclaves/Kconfig | 8 ++------
>>>>>    1 file changed, 2 insertions(+), 6 deletions(-)
>>>>>
>>>>> diff --git a/drivers/virt/nitro_enclaves/Kconfig 
>>>>> b/drivers/virt/nitro_enclaves/Kconfig
>>>>> index 8c9387a232df8..f53740b941c0f 100644
>>>>> --- a/drivers/virt/nitro_enclaves/Kconfig
>>>>> +++ b/drivers/virt/nitro_enclaves/Kconfig
>>>>> @@ -1,17 +1,13 @@
>>>>>    # SPDX-License-Identifier: GPL-2.0
>>>>>    #
>>>>> -# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights 
>>>>> Reserved.
>>>>> +# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All 
>>>>> Rights Reserved.
>>>>>    # Amazon Nitro Enclaves (NE) support.
>>>>>    # Nitro is a hypervisor that has been developed by Amazon.
>>>>> -# TODO: Add dependency for ARM64 once NE is supported on Arm 
>>>>> platforms. For now,
>>>>> -# the NE kernel driver can be built for aarch64 arch.
>>>>> -# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>>>>> -
>>>>>    config NITRO_ENCLAVES
>>>>>            tristate "Nitro Enclaves Support"
>>>>> - depends on X86 && HOTPLUG_CPU && PCI && SMP
>>>>> + depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>>>>>            help
>>>>>              This driver consists of support for enclave lifetime 
>>>>> management
>>>>>              for Nitro Enclaves (NE).
>>>>> -- 
>>>>> 2.20.1 (Apple Git-117)
>>>>>
>>>> Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>
>>>>
>>> Thanks, George, for review.
>>>
>>> Greg, let me know if other updates are needed for the patch series.
>>> Otherwise, please include the patches in the char-misc tree and we can
>>> target the current merge window, for v5.15. Thank you.
>> It's too late for 5.15-rc1, I will queue them up after 5.15-rc1 is out,
>> thanks.
> 
> Ack, thanks for info. Then would be the next rc, no functional codebase 
> changes being included. Or just let me know if other release phase would 
> be targeted.

I see the patch series has been merged into the mainline. Thanks, Greg.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
diff mbox series

Patch

diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
index 8c9387a232df8..f53740b941c0f 100644
--- a/drivers/virt/nitro_enclaves/Kconfig
+++ b/drivers/virt/nitro_enclaves/Kconfig
@@ -1,17 +1,13 @@ 
 # SPDX-License-Identifier: GPL-2.0
 #
-# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 
 # Amazon Nitro Enclaves (NE) support.
 # Nitro is a hypervisor that has been developed by Amazon.
 
-# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
-# the NE kernel driver can be built for aarch64 arch.
-# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
-
 config NITRO_ENCLAVES
 	tristate "Nitro Enclaves Support"
-	depends on X86 && HOTPLUG_CPU && PCI && SMP
+	depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
 	help
 	  This driver consists of support for enclave lifetime management
 	  for Nitro Enclaves (NE).