diff mbox series

KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page

Message ID 20210830145336.27183-1-justin.he@arm.com (mailing list archive)
State New, archived
Headers show
Series KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page | expand

Commit Message

Jia He Aug. 30, 2021, 2:53 p.m. UTC
After reverting and restoring the fast tlb invalidation patch series,
the mmio_cached is not removed. Hence a unused field is left in
kvm_mmu_page.

Cc: Sean Christopherson <seanjc@google.com>
Signed-off-by: Jia He <justin.he@arm.com>
---
 arch/x86/kvm/mmu/mmu_internal.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Sean Christopherson Sept. 1, 2021, 7:57 p.m. UTC | #1
On Mon, Aug 30, 2021, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
> 
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jia He <justin.he@arm.com>

Reviewed-by: Sean Christopherson <seanjc@google.com> 

There's also additional cleanup we can do to take advantage of the free byte.
I'll include this patch in a follow-up mini-series to hopefully make life a bit
easier for Paolo.

Thanks!
Paolo Bonzini Sept. 6, 2021, 10:13 a.m. UTC | #2
On 30/08/21 16:53, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
> 
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
>   arch/x86/kvm/mmu/mmu_internal.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
> index 35567293c1fd..3e6f21c1871a 100644
> --- a/arch/x86/kvm/mmu/mmu_internal.h
> +++ b/arch/x86/kvm/mmu/mmu_internal.h
> @@ -37,7 +37,6 @@ struct kvm_mmu_page {
>   
>   	bool unsync;
>   	u8 mmu_valid_gen;
> -	bool mmio_cached;
>   	bool lpage_disallowed; /* Can't be replaced by an equiv large page */
>   
>   	/*
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
index 35567293c1fd..3e6f21c1871a 100644
--- a/arch/x86/kvm/mmu/mmu_internal.h
+++ b/arch/x86/kvm/mmu/mmu_internal.h
@@ -37,7 +37,6 @@  struct kvm_mmu_page {
 
 	bool unsync;
 	u8 mmu_valid_gen;
-	bool mmio_cached;
 	bool lpage_disallowed; /* Can't be replaced by an equiv large page */
 
 	/*