diff mbox series

[next] vfio/pci: add missing identifier name in argument of function prototype

Message ID 20210902212631.54260-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show
Series [next] vfio/pci: add missing identifier name in argument of function prototype | expand

Commit Message

Colin King Sept. 2, 2021, 9:26 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The function prototype is missing an identifier name. Add one.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/vfio/pci/vfio_pci_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Gunthorpe Sept. 3, 2021, 12:24 p.m. UTC | #1
On Thu, Sep 02, 2021 at 10:26:31PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function prototype is missing an identifier name. Add one.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/vfio/pci/vfio_pci_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It seems fine, but is there a reason to just pick this one case and
not clean the whole subsystem?

Eg i see a couple more cases in the headers

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason
diff mbox series

Patch

diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
index 68198e0f2a63..a03b5a99c2da 100644
--- a/drivers/vfio/pci/vfio_pci_core.c
+++ b/drivers/vfio/pci/vfio_pci_core.c
@@ -565,7 +565,7 @@  static bool vfio_pci_dev_below_slot(struct pci_dev *pdev, struct pci_slot *slot)
 }
 
 struct vfio_pci_walk_info {
-	int (*fn)(struct pci_dev *, void *data);
+	int (*fn)(struct pci_dev *pdev, void *data);
 	void *data;
 	struct pci_dev *pdev;
 	bool slot;